* [PATCH] hda: STAC927x power management
@ 2008-02-20 22:00 Matthew Ranostay
2008-02-21 7:04 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Ranostay @ 2008-02-20 22:00 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai
Fix issue on STAC927x codecs that first DAC was getting powered down even if was being used.
Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
---
diff -r 30701aaf404c pci/hda/patch_sigmatel.c
--- a/pci/hda/patch_sigmatel.c Wed Feb 20 12:13:29 2008 +0100
+++ b/pci/hda/patch_sigmatel.c Wed Feb 20 14:16:59 2008 -0700
@@ -2893,7 +2893,8 @@ static void stac92xx_power_down(struct h
/* power down inactive DACs */
hda_nid_t *dac;
for (dac = spec->dac_list; *dac; dac++)
- if (!is_in_dac_nids(spec, *dac))
+ if (!is_in_dac_nids(spec, *dac) &&
+ spec->multiout.hp_nid != *dac)
snd_hda_codec_write_cache(codec, *dac, 0,
AC_VERB_SET_POWER_STATE, AC_PWRST_D3);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hda: STAC927x power management
2008-02-20 22:00 [PATCH] hda: STAC927x power management Matthew Ranostay
@ 2008-02-21 7:04 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-02-21 7:04 UTC (permalink / raw)
To: Matthew Ranostay; +Cc: alsa-devel
At Wed, 20 Feb 2008 17:00:39 -0500,
Matthew Ranostay wrote:
>
> Fix issue on STAC927x codecs that first DAC was getting powered down even if was being used.
>
> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
Thanks, applied now to HG tree.
I guess we can use check_in_dac_nids() instead?
Takashi
> ---
> diff -r 30701aaf404c pci/hda/patch_sigmatel.c
> --- a/pci/hda/patch_sigmatel.c Wed Feb 20 12:13:29 2008 +0100
> +++ b/pci/hda/patch_sigmatel.c Wed Feb 20 14:16:59 2008 -0700
> @@ -2893,7 +2893,8 @@ static void stac92xx_power_down(struct h
> /* power down inactive DACs */
> hda_nid_t *dac;
> for (dac = spec->dac_list; *dac; dac++)
> - if (!is_in_dac_nids(spec, *dac))
> + if (!is_in_dac_nids(spec, *dac) &&
> + spec->multiout.hp_nid != *dac)
> snd_hda_codec_write_cache(codec, *dac, 0,
> AC_VERB_SET_POWER_STATE, AC_PWRST_D3);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-21 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-20 22:00 [PATCH] hda: STAC927x power management Matthew Ranostay
2008-02-21 7:04 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.