From: Patrick McHardy <kaber@trash.net>
To: Peter Warasin <peter@endian.com>
Cc: netfilter-devel@vger.kernel.org,
ebtables-devel@lists.sourceforge.net,
Bart De Schuymer <bdschuym@pandora.be>
Subject: Re: [PATCH 1/2] Adds ebt_nflog watcher to kernel.
Date: Thu, 21 Feb 2008 15:13:03 +0100 [thread overview]
Message-ID: <47BD86EF.7060809@trash.net> (raw)
In-Reply-To: <20080205185617.732255000@andrew.endian.com>
Peter Warasin wrote:
> This patch adds the ebtables nflog watcher to the
> kernel in order to allow ebtables log through the
> nfnetlink_log backend.
This seems mostly fine to me. A few minor comments:
> +#define EBT_NFLOG_PREFIX_SIZE 30
People found the 30 character limit to small for iptables,
which is why I increased it to 64 in NFLOG. For consistency
it would be better to use the same value here in my opinion.
> +static struct ebt_watcher nflog = {
This could be __read_mostly.
If you'll resend the patch based on net-2.6.26 I'll queue it
if Bart has no objections.
next prev parent reply other threads:[~2008-02-21 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 18:29 [PATCH 0/2] adds ebt_nflog watcher Peter Warasin
2008-02-05 18:29 ` [PATCH 1/2] Adds ebt_nflog watcher to kernel Peter Warasin
2008-02-21 14:13 ` Patrick McHardy [this message]
2008-02-25 23:03 ` [PATCH resend " Peter Warasin
[not found] ` <47C34933.8000301-k8AlXt1uIdjQT0dZR+AlfA@public.gmane.org>
2008-02-25 23:24 ` Bart De Schuymer
[not found] ` <1203981841.2959.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-26 2:50 ` Patrick McHardy
2008-02-27 0:46 ` Pablo Neira Ayuso
2008-03-17 16:25 ` [Ebtables-devel] " Peter Warasin
2008-03-17 16:25 ` Patrick McHardy
2008-03-17 22:12 ` Bart De Schuymer
2008-04-08 17:31 ` Patrick McHardy
2008-02-05 18:29 ` [PATCH 2/2] Adds nflog watcher to ebtables Peter Warasin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD86EF.7060809@trash.net \
--to=kaber@trash.net \
--cc=bdschuym@pandora.be \
--cc=ebtables-devel@lists.sourceforge.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=peter@endian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.