From: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
To: Bart De Schuymer <bdschuym-LPO8gxj9N8aZIoH1IeqzKA@public.gmane.org>
Cc: Peter Warasin <peter-k8AlXt1uIdjQT0dZR+AlfA@public.gmane.org>,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ebtables-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH resend 1/2] Adds ebt_nflog watcher to kernel.
Date: Tue, 26 Feb 2008 03:50:29 +0100 [thread overview]
Message-ID: <47C37E75.2080803@trash.net> (raw)
In-Reply-To: <1203981841.2959.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Bart De Schuymer wrote:
> Op di, 26-02-2008 te 00:03 +0100, schreef Peter Warasin:
>> Hi
>>
>> Patrick McHardy wrote:
>>> Peter Warasin wrote:
>>> > This patch adds the ebtables nflog watcher to the
>>> > kernel
>>> This seems mostly fine to me. A few minor comments:
>>> If you'll resend the patch based on net-2.6.26 I'll queue it
>>> if Bart has no objections.
>> I re-based on net-2.6.26 and changed what you mentioned.
>> Patch is attached
>
> It looks fine, I'm just wondering what the flags and the pad in struct
> ebt_nflog_info are for...
Both have their origin in NFLOG.
The flags were intended for something I still want to add, a reliable
log mode where packets are dropped when netlink transmission or
memory allocation fails. I can't really remember why I added the
padding, but in any case it doesn't hurt since the structure size
is usually padded to a multiple of 4/8 anyways.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-26 2:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 18:29 [PATCH 0/2] adds ebt_nflog watcher Peter Warasin
2008-02-05 18:29 ` [PATCH 1/2] Adds ebt_nflog watcher to kernel Peter Warasin
2008-02-21 14:13 ` Patrick McHardy
2008-02-25 23:03 ` [PATCH resend " Peter Warasin
[not found] ` <47C34933.8000301-k8AlXt1uIdjQT0dZR+AlfA@public.gmane.org>
2008-02-25 23:24 ` Bart De Schuymer
[not found] ` <1203981841.2959.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-26 2:50 ` Patrick McHardy [this message]
2008-02-27 0:46 ` Pablo Neira Ayuso
2008-03-17 16:25 ` [Ebtables-devel] " Peter Warasin
2008-03-17 16:25 ` Patrick McHardy
2008-03-17 22:12 ` Bart De Schuymer
2008-04-08 17:31 ` Patrick McHardy
2008-02-05 18:29 ` [PATCH 2/2] Adds nflog watcher to ebtables Peter Warasin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C37E75.2080803@trash.net \
--to=kaber-dcujhnylwpneowh0uzbu5w@public.gmane.org \
--cc=bdschuym-LPO8gxj9N8aZIoH1IeqzKA@public.gmane.org \
--cc=ebtables-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter-k8AlXt1uIdjQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.