From: Jeremy Fitzhardinge <jeremy@goop.org>
To: yamahata@valinux.co.jp
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xensource.com, linux-ia64@vger.kernel.org,
xen-ia64-devel@lists.xensource.com,
Chris Wright <chrisw@sous-sol.org>,
"Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen
Date: Thu, 21 Feb 2008 19:38:18 +0000 [thread overview]
Message-ID: <47BDD32A.6030201@goop.org> (raw)
In-Reply-To: <20080221091002.222498000@ls.local.valinux.co.jp>
yamahata@valinux.co.jp wrote:
> diff --git a/arch/x86/xen/events.c b/drivers/xen/events.c
> similarity index 95%
> rename from arch/x86/xen/events.c
> rename to drivers/xen/events.c
> index dcf613e..7474739 100644
> --- a/arch/x86/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -37,7 +37,9 @@
> #include <xen/interface/xen.h>
> #include <xen/interface/event_channel.h>
>
> -#include "xen-ops.h"
> +#ifdef CONFIG_X86
> +# include "../arch/x86/xen/xen-ops.h"
> +#endif
Hm. Perhaps it would be better to move whatever definition you need
into a header in a common place (or move xen-ops.h entirely).
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: yamahata@valinux.co.jp
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xensource.com, linux-ia64@vger.kernel.org,
xen-ia64-devel@lists.xensource.com,
Chris Wright <chrisw@sous-sol.org>,
"Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific part.
Date: Thu, 21 Feb 2008 11:38:18 -0800 [thread overview]
Message-ID: <47BDD32A.6030201@goop.org> (raw)
In-Reply-To: <20080221091002.222498000@ls.local.valinux.co.jp>
yamahata@valinux.co.jp wrote:
> diff --git a/arch/x86/xen/events.c b/drivers/xen/events.c
> similarity index 95%
> rename from arch/x86/xen/events.c
> rename to drivers/xen/events.c
> index dcf613e..7474739 100644
> --- a/arch/x86/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -37,7 +37,9 @@
> #include <xen/interface/xen.h>
> #include <xen/interface/event_channel.h>
>
> -#include "xen-ops.h"
> +#ifdef CONFIG_X86
> +# include "../arch/x86/xen/xen-ops.h"
> +#endif
Hm. Perhaps it would be better to move whatever definition you need
into a header in a common place (or move xen-ops.h entirely).
J
next prev parent reply other threads:[~2008-02-21 19:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 8:45 [PATCH 00/11] Xen arch portability patches yamahata
2008-02-21 8:45 ` [PATCH 01/11] xen: add missing __HYPERVISOR_arch_definisions which ia64 needs yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 02/11] xen: add missing VIRQ_ARCH_definitions which ia64/xen needs yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 03/11] xen: add missing definitions for xen grant table " yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 19:40 ` [PATCH 03/11] xen: add missing definitions for xen grant table Jeremy Fitzhardinge
2008-02-21 19:40 ` [PATCH 03/11] xen: add missing definitions for xen grant table which ia64/xen needs Jeremy Fitzhardinge
2008-02-21 19:40 ` Jeremy Fitzhardinge
2008-02-21 8:45 ` [PATCH 04/11] xen: add missing definitions in include/xen/interface/vcpu.h " yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 05/11] xen: move features.c from arch/x86/xen/features.c to drivers/xen yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific part yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 19:38 ` Jeremy Fitzhardinge
2008-02-21 19:38 ` Jeremy Fitzhardinge [this message]
2008-02-21 19:38 ` Jeremy Fitzhardinge
2008-02-22 3:47 ` [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific par Isaku Yamahata
2008-02-22 3:47 ` [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific part Isaku Yamahata
2008-02-22 3:47 ` Isaku Yamahata
2008-02-21 8:45 ` [PATCH 07/11] xen: make include/xen/page.h portable moving those definitions under asm dir yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 08/11] xen: replace callers of alloc_vm_area()/free_vm_area() with xen_ prefixed one yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 09/11] xen: make grant table arch portable yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 10/11] xen: import include/xen/interface/callback.h which ia64/xen needs yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 8:45 ` [PATCH 11/11] xen: import arch generic part of xencomm yamahata
2008-02-21 8:45 ` yamahata
2008-02-21 19:35 ` [PATCH 00/11] Xen arch portability patches Jeremy Fitzhardinge
2008-02-21 19:35 ` Jeremy Fitzhardinge
2008-02-21 19:35 ` Jeremy Fitzhardinge
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 01/11] xen: add missing __HYPERVISOR_arch_[0-7] definisions which ia64 needs Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 02/11] xen: add missing VIRQ_ARCH_[0-7] definitions which ia64/xen needs Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 03/11] xen: add missing definitions for xen grant table " Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 04/11] xen: add missing definitions in include/xen/interface/vcpu.h " Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 05/11] xen: move features.c from arch/x86/xen/features.c to drivers/xen Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific part Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 07/11] xen: make include/xen/page.h portable moving those definitions under asm dir Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 08/11] xen: replace callers of alloc_vm_area()/free_vm_area() with xen_ prefixed one Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 09/11] xen: make grant table arch portable Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 10/11] xen: import include/xen/interface/callback.h which ia64/xen needs Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
2008-02-22 5:07 ` [PATCH 11/11] xen: import arch generic part of xencomm Isaku Yamahata
2008-02-22 5:07 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BDD32A.6030201@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
--cc=xen-ia64-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.