All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ned Forrester <nforrester-/d+BM93fTQY@public.gmane.org>
To: Atsushi Nemoto <anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>
Cc: david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	marc.pignat-7TsPiqsLilE@public.gmane.org
Subject: Re: [PATCH] atmel_spi: support zero length	transfer
Date: Fri, 22 Feb 2008 09:28:11 -0500	[thread overview]
Message-ID: <47BEDBFB.5040305@whoi.edu> (raw)
In-Reply-To: <20080222.231510.56565462.anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>

Atsushi Nemoto wrote:

> If the driver could not handle zero length transfer, then the driver
> should reject it (just like unsupported transfer mode).  Then the
> behavior will be 'assert chip select and wait some time' or 'rejected
> by the driver'.

This would be OK.  It would not be hard to fix pxa2xx_spi, for example,
to reject zero-length transfers in DMA mode, as long as it is acceptable
to reject the message in mid-message.  If it were necessary to scan a
whole message for zero-length transfers and refuse to queue an offending
message, then that adds burden to all messages.

-- 
Ned Forrester                                       nforrester-/d+BM93fTQY@public.gmane.org
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

WARNING: multiple messages have this Message-ID (diff)
From: Ned Forrester <nforrester@whoi.edu>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: marc.pignat@hevs.ch, david-b@pacbell.net,
	spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [spi-devel-general] [PATCH] atmel_spi: support zero length	transfer
Date: Fri, 22 Feb 2008 09:28:11 -0500	[thread overview]
Message-ID: <47BEDBFB.5040305@whoi.edu> (raw)
In-Reply-To: <20080222.231510.56565462.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:

> If the driver could not handle zero length transfer, then the driver
> should reject it (just like unsupported transfer mode).  Then the
> behavior will be 'assert chip select and wait some time' or 'rejected
> by the driver'.

This would be OK.  It would not be hard to fix pxa2xx_spi, for example,
to reject zero-length transfers in DMA mode, as long as it is acceptable
to reject the message in mid-message.  If it were necessary to scan a
whole message for zero-length transfers and refuse to queue an offending
message, then that adds burden to all messages.

-- 
Ned Forrester                                       nforrester@whoi.edu
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079


  parent reply	other threads:[~2008-02-22 14:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 15:54 [PATCH] atmel_spi: support zero length transfer Atsushi Nemoto
2008-02-20 15:54 ` Atsushi Nemoto
     [not found] ` <20080221.005432.07645461.anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>
2008-02-20 17:55   ` Marc Pignat
2008-02-20 17:55     ` Marc Pignat
     [not found]     ` <200802201855.02605.marc.pignat-7TsPiqsLilE@public.gmane.org>
2008-02-21  1:52       ` Atsushi Nemoto
2008-02-21  1:52         ` Atsushi Nemoto
     [not found]         ` <20080221.105233.41199605.nemoto-IGagC74glE2asRnM1LW+pc8NsWr+9BEh@public.gmane.org>
2008-02-21  9:26           ` Marc Pignat
2008-02-21  9:26             ` Marc Pignat
2008-02-21 19:23             ` David Brownell
     [not found]               ` <20080221192334.EE97A230A58-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-02-22  9:30                 ` Marc Pignat
2008-02-22  9:30                   ` Marc Pignat
     [not found]                   ` <200802221030.32263.marc.pignat-7TsPiqsLilE@public.gmane.org>
2008-02-22 14:15                     ` Atsushi Nemoto
2008-02-22 14:15                       ` Atsushi Nemoto
     [not found]                       ` <20080222.231510.56565462.anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>
2008-02-22 14:28                         ` Ned Forrester [this message]
2008-02-22 14:28                           ` [spi-devel-general] " Ned Forrester
2008-02-22 19:06                           ` David Brownell
     [not found]                             ` <20080222190613.0043B229B4D-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-02-22 19:52                               ` Ned Forrester
2008-02-22 19:52                                 ` [spi-devel-general] " Ned Forrester
2008-02-22 18:58                         ` David Brownell
2008-02-22 18:58                           ` [spi-devel-general] " David Brownell
2008-02-23  2:55                     ` David Brownell
2008-02-23  2:55                       ` David Brownell
     [not found]                       ` <200802221855.25892.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-02-25  8:15                         ` Marc Pignat
2008-02-25  8:15                           ` Marc Pignat
2008-02-22 14:07                 ` Ned Forrester
2008-02-22 14:07                   ` [spi-devel-general] " Ned Forrester
2008-02-22 19:02                   ` David Brownell
     [not found]                     ` <20080222190228.2B0CB28E363-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-02-22 19:36                       ` Ned Forrester
2008-02-22 19:36                         ` [spi-devel-general] " Ned Forrester
     [not found]                         ` <47BF2455.8030904-/d+BM93fTQY@public.gmane.org>
2008-02-23  2:37                           ` David Brownell
2008-02-23  2:37                             ` [spi-devel-general] " David Brownell
2008-02-25  0:25                           ` Atsushi Nemoto
2008-02-25  0:25                             ` [spi-devel-general] " Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BEDBFB.5040305@whoi.edu \
    --to=nforrester-/d+bm93ftqy@public.gmane.org \
    --cc=anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org \
    --cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marc.pignat-7TsPiqsLilE@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.