From: Mark Pearson <devnull.port@googlemail.com>
To: Karol Kozimor <sziwan@hell.org.pl>
Cc: Julia Lawall <julia@diku.dk>,
corentincj@iksaif.net, sziwan@users.sourceforge.net,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and &
Date: Wed, 27 Feb 2008 18:29:15 +0000 [thread overview]
Message-ID: <47C5ABFB.3050607@googlemail.com> (raw)
In-Reply-To: <7C626792-02A6-4BE6-B5F2-D75899F3990C@hell.org.pl>
Karol Kozimor wrote:
> On 26-02-2008, at 21:42, Julia Lawall wrote:
>> if (invert) /* invert target value */
>> - led_out = !led_out & 0x1;
>> + led_out = !(led_out & 0x1);
>>
>> if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
>> printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
>
>
> IIRC we're just supposed to flip the last bit here, so the original code
> is correct.
> Best regards,
>
Seems an odd way of doing:
led_out ^= 0x01;
It this due to some optimisation?
Cheers, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Pearson <devnull.port@googlemail.com>
To: Karol Kozimor <sziwan@hell.org.pl>
Cc: Julia Lawall <julia@diku.dk>,
corentincj@iksaif.net, sziwan@users.sourceforge.net,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
Date: Wed, 27 Feb 2008 19:29:15 +0100 [thread overview]
Message-ID: <47C5ABFB.3050607@googlemail.com> (raw)
In-Reply-To: <7C626792-02A6-4BE6-B5F2-D75899F3990C@hell.org.pl>
Karol Kozimor wrote:
> On 26-02-2008, at 21:42, Julia Lawall wrote:
>> if (invert) /* invert target value */
>> - led_out = !led_out & 0x1;
>> + led_out = !(led_out & 0x1);
>>
>> if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
>> printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
>
>
> IIRC we're just supposed to flip the last bit here, so the original code
> is correct.
> Best regards,
>
Seems an odd way of doing:
led_out ^= 0x01;
It this due to some optimisation?
Cheers, Mark.
next prev parent reply other threads:[~2008-02-27 18:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 20:42 [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Julia Lawall
2008-02-26 20:42 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Julia Lawall
2008-02-27 17:03 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Karol Kozimor
2008-02-27 17:03 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Karol Kozimor
2008-02-27 17:41 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Julia Lawall
2008-02-27 17:41 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Julia Lawall
2008-02-27 18:29 ` Mark Pearson [this message]
2008-02-27 18:29 ` Mark Pearson
2008-02-29 5:55 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Andrew Morton
2008-02-29 5:55 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Andrew Morton
2008-02-29 6:10 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Matthew Wilcox
2008-02-29 6:10 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Matthew Wilcox
2008-02-29 6:14 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Matthew Wilcox
2008-02-29 6:14 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Matthew Wilcox
2008-02-29 6:19 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Andrew Morton
2008-02-29 6:19 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Andrew Morton
2008-02-29 11:01 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Julia Lawall
2008-02-29 11:01 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Julia Lawall
2008-02-29 11:08 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Andrew Morton
2008-02-29 11:08 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Andrew Morton
2008-02-29 18:06 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Mark Pearson
2008-02-29 18:06 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Mark Pearson
2008-02-29 21:33 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of.and & Andrew Morton
2008-02-29 21:33 ` [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and & Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C5ABFB.3050607@googlemail.com \
--to=devnull.port@googlemail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentincj@iksaif.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sziwan@hell.org.pl \
--cc=sziwan@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.