[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[Kim Phillips]

erratum 5.6 states the autoneg completion bit is functional only if the
autoneg bit is asserted.

This fixes any secondarily-issued networking commands on non-gigabit
links on the mpc8360 mds board.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
gvb, please test, and give us your blessings if this fixes your second
ping failing issue.

To go through biggerbadderben, for 1.3.2.

 drivers/qe/uec_phy.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/qe/uec_phy.c b/drivers/qe/uec_phy.c
index c549b6b..cf9921b 100644
--- a/drivers/qe/uec_phy.c
+++ b/drivers/qe/uec_phy.c
@@ -574,6 +574,7 @@ void marvell_phy_interface_mode (struct eth_device *dev,
 {
 	uec_private_t *uec = (uec_private_t *) dev->priv;
 	struct uec_mii_info *mii_info;
+	u16 status;
 
 	if (!uec->mii_info) {
 		printf ("%s: the PHY not intialized\n", __FUNCTION__);
@@ -609,6 +610,13 @@ void marvell_phy_interface_mode (struct eth_device *dev,
 		phy_write (mii_info, 0x00, 0x8100);
 		udelay (1000000);
 	}
+
+	/* handle 88e1111 rev.B2 erratum 5.6 */
+	if (mii_info->autoneg) {
+		status = phy_read (mii_info, PHY_BMCR);
+		phy_write (mii_info, PHY_BMCR, status | PHY_BMCR_AUTON);
+	}
+	/* now the B2 will correctly report autoneg completion status */
 }
 
 void change_phy_interface_mode (struct eth_device *dev, enet_interface_e mode)
-- 
1.5.4.23.gef5b9

[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[Jerry Van Baren]

Kim Phillips wrote:
> erratum 5.6 states the autoneg completion bit is functional only if the
> autoneg bit is asserted.
> 
> This fixes any secondarily-issued networking commands on non-gigabit
> links on the mpc8360 mds board.
> 
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> gvb, please test, and give us your blessings if this fixes your second
> ping failing issue.
> 
> To go through biggerbadderben, for 1.3.2.
> 
>  drivers/qe/uec_phy.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)

YES!  That fixed the problem for real.

Ben (Wolfgang), please apply to 1.3.2rc2, this fixes a very real problem.

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

Thanks, Kim!
gvb

[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[Ben Warren]

Wolfgang,

Please pull directly into 1.3.2 if possible

thanks,
Ben

Acked-by: Ben Warren <biggerbadderben@gmail.com>

On Wed, Feb 27, 2008 at 4:06 PM, Kim Phillips
<kim.phillips@freescale.com> wrote:
> erratum 5.6 states the autoneg completion bit is functional only if the
>  autoneg bit is asserted.
>
>  This fixes any secondarily-issued networking commands on non-gigabit
>  links on the mpc8360 mds board.
>
>  Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>  ---
>  gvb, please test, and give us your blessings if this fixes your second
>  ping failing issue.
>
>  To go through biggerbadderben, for 1.3.2.
>
>   drivers/qe/uec_phy.c |    8 ++++++++
>   1 files changed, 8 insertions(+), 0 deletions(-)
>
>  diff --git a/drivers/qe/uec_phy.c b/drivers/qe/uec_phy.c
>  index c549b6b..cf9921b 100644
>  --- a/drivers/qe/uec_phy.c
>  +++ b/drivers/qe/uec_phy.c
>  @@ -574,6 +574,7 @@ void marvell_phy_interface_mode (struct eth_device *dev,
>   {
>         uec_private_t *uec = (uec_private_t *) dev->priv;
>         struct uec_mii_info *mii_info;
>  +       u16 status;
>
>         if (!uec->mii_info) {
>                 printf ("%s: the PHY not intialized\n", __FUNCTION__);
>  @@ -609,6 +610,13 @@ void marvell_phy_interface_mode (struct eth_device *dev,
>                 phy_write (mii_info, 0x00, 0x8100);
>                 udelay (1000000);
>         }
>  +
>  +       /* handle 88e1111 rev.B2 erratum 5.6 */
>  +       if (mii_info->autoneg) {
>  +               status = phy_read (mii_info, PHY_BMCR);
>  +               phy_write (mii_info, PHY_BMCR, status | PHY_BMCR_AUTON);
>  +       }
>  +       /* now the B2 will correctly report autoneg completion status */
>   }
>
>   void change_phy_interface_mode (struct eth_device *dev, enet_interface_e mode)
>  --
>  1.5.4.23.gef5b9
>
>

[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[Wolfgang Denk]

In message <20080227150639.494b5061.kim.phillips@freescale.com> you wrote:
> erratum 5.6 states the autoneg completion bit is functional only if the
> autoneg bit is asserted.
> 
> This fixes any secondarily-issued networking commands on non-gigabit
> links on the mpc8360 mds board.
> 
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Eeeek!
'eval' on strings should have been named 'evil'.    -- Tom Phoenix in
        <Pine.GSO.3.96.980526121813.27437N-100000@user2.teleport.com>

[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6

[Wolfgang Denk]

In message <f8328f7c0802271646v1d3b289j265f1360bc400bbe@mail.gmail.com> you wrote:
> Wolfgang,
> 
> Please pull directly into 1.3.2 if possible

Sure, done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gew?hnlich glaubt der Mensch,  wenn er nur Worte h?rt,  es m?sse sich
dabei doch auch was denken lassen.                 -- Goethe, Faust I