All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>
Subject: Re: [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace	directory
Date: Thu, 28 Feb 2008 08:16:26 +0000	[thread overview]
Message-ID: <47C66DDA.7000808@qumranet.com> (raw)
In-Reply-To: <1204142247.2532.70.camel@basalt>

Hollis Blanchard wrote:
>> It doesn't have to be a package; it can be as simple as a tarball that 
>> people have to make; && sudo make install before compiling kvm, the same 
>> as other prerequisite libraries.
>>     
>
> Sure. Let's put that tarball inside the qemu directory, and then have it
> extracted and built automatically when the user types "make".
>
> I'm really not clear on what advantage you think will be gained here.
>
>   

If the package never changes in kvm-specific ways, there is no point in 
including it in kvm. The user can install it once, just like they 
install the X devel packages (for example) which we don't carry in kvm 
either.

Is it indeed the case that no modifications are needed for kvm?

>> The barrier should be whether we need to carry local changes or not.  If 
>> we can use upstream as is, then it should be installed independently.
>>     
>
> So let me get this straight... you think it's cool to awk kernel source,
>   

Awking the kernel source is not done for the sheer pleasure of it. It is 
painful to maintain and I only do it out of necessity.

> but not to copy library code that was designed to be copied in the first
> place? Seriously? Would it be more palatable to you if I ran awk over
> arch/powerpc/boot/libdft?
>   

Including the source in kvm is of course preferable to awk, but less 
preferable to an external dependency.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>
Subject: Re: [kvm-ppc-devel] Top level kvm-userspace	directory getting	crowded ...	need new dir	for qemu dependencies
Date: Thu, 28 Feb 2008 10:16:26 +0200	[thread overview]
Message-ID: <47C66DDA.7000808@qumranet.com> (raw)
In-Reply-To: <1204142247.2532.70.camel@basalt>

Hollis Blanchard wrote:
>> It doesn't have to be a package; it can be as simple as a tarball that 
>> people have to make; && sudo make install before compiling kvm, the same 
>> as other prerequisite libraries.
>>     
>
> Sure. Let's put that tarball inside the qemu directory, and then have it
> extracted and built automatically when the user types "make".
>
> I'm really not clear on what advantage you think will be gained here.
>
>   

If the package never changes in kvm-specific ways, there is no point in 
including it in kvm. The user can install it once, just like they 
install the X devel packages (for example) which we don't carry in kvm 
either.

Is it indeed the case that no modifications are needed for kvm?

>> The barrier should be whether we need to carry local changes or not.  If 
>> we can use upstream as is, then it should be installed independently.
>>     
>
> So let me get this straight... you think it's cool to awk kernel source,
>   

Awking the kernel source is not done for the sheer pleasure of it. It is 
painful to maintain and I only do it out of necessity.

> but not to copy library code that was designed to be copied in the first
> place? Seriously? Would it be more palatable to you if I ran awk over
> arch/powerpc/boot/libdft?
>   

Including the source in kvm is of course preferable to awk, but less 
preferable to an external dependency.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-28  8:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25  6:50 Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Jerone Young
2008-02-25  9:00 ` Avi Kivity
2008-02-26 17:24   ` Jerone Young
2008-02-27 10:59     ` Avi Kivity
2008-02-27 16:29     ` Hollis Blanchard
2008-02-27 16:34       ` Avi Kivity
2008-02-27 16:48         ` Alexander Graf
2008-02-27 16:59           ` Avi Kivity
2008-02-27 17:07             ` Alexander Graf
2008-02-27 18:56           ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Hollis Blanchard
2008-02-27 18:56             ` Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Hollis Blanchard
2008-02-27 19:18             ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Alexander Graf
2008-02-27 19:18               ` Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Alexander Graf
2008-02-27 20:22               ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace Hollis Blanchard
2008-02-27 20:22                 ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Hollis Blanchard
2008-02-27 21:20                 ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Alexander Graf
2008-02-27 21:20                   ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Alexander Graf
2008-02-27 22:19                   ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace Hollis Blanchard
2008-02-27 22:19                     ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Hollis Blanchard
2008-02-27 22:32                     ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Alexander Graf
2008-02-27 22:32                       ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Alexander Graf
2008-03-02 18:38                     ` Luca Barbato
2008-02-27 19:25             ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Avi Kivity
2008-02-27 19:25               ` Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Avi Kivity
2008-02-27 19:57               ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace Hollis Blanchard
2008-02-27 19:57                 ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Hollis Blanchard
2008-02-28  8:16                 ` Avi Kivity [this message]
2008-02-28  8:16                   ` Avi Kivity
2008-02-28 20:28                   ` [kvm-ppc-devel] [kvm-devel] Top level Jerone Young
2008-02-28 20:28                     ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Jerone Young
2008-03-02 16:41                     ` [kvm-ppc-devel] [kvm-devel] Top level kvm-userspace directory Avi Kivity
2008-03-02 16:41                       ` [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C66DDA.7000808@qumranet.com \
    --to=avi@qumranet.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.