All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net,
	kvm-ppc-devel@lists.sourceforge.net,
	Jerone Young <jyoung5@us.ibm.com>
Subject: Re: [kvm-ppc-devel] [kvm-devel] [PATCH] Fix qemu PPC breakage in
Date: Thu, 28 Feb 2008 08:23:08 +0000	[thread overview]
Message-ID: <47C66F6C.6050003@qumranet.com> (raw)
In-Reply-To: <1204151373.2532.112.camel@basalt>

Hollis Blanchard wrote:
> On Wed, 2008-02-27 at 16:14 -0600, Jerone Young wrote:
>   
>> # HG changeset patch
>> # User Jerone Young <jyoung5@us.ibm.com>
>> # Date 1204150440 21600
>> # Branch merge
>> # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
>> # Parent  64a281615f436e65ca7fb2f3c2721c374fbfc8be
>> Fix qemu PPC breakage in monitor.c
>>
>> Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64).
>>
>> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>>
>> diff --git a/qemu/monitor.c b/qemu/monitor.c
>> --- a/qemu/monitor.c
>> +++ b/qemu/monitor.c
>> @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con
>>         term_printf("invalid status: %s\n", status);
>>         return;
>>      }
>> +#if defined(TARGET_I386) || defined(TARGET_X86_64)
>>      qemu_system_cpu_hot_add(value, state);
>> +#endif
>>  }
>>
>>  static void do_info_jit(void)
>>     
>
> This should be submitted to qemu-devel too, no?
>
>   

qemu hasn't merged the cpu hotplug patches (yet?).

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net,
	kvm-ppc-devel@lists.sourceforge.net,
	Jerone Young <jyoung5@us.ibm.com>
Subject: Re: [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c
Date: Thu, 28 Feb 2008 10:23:08 +0200	[thread overview]
Message-ID: <47C66F6C.6050003@qumranet.com> (raw)
In-Reply-To: <1204151373.2532.112.camel@basalt>

Hollis Blanchard wrote:
> On Wed, 2008-02-27 at 16:14 -0600, Jerone Young wrote:
>   
>> # HG changeset patch
>> # User Jerone Young <jyoung5@us.ibm.com>
>> # Date 1204150440 21600
>> # Branch merge
>> # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
>> # Parent  64a281615f436e65ca7fb2f3c2721c374fbfc8be
>> Fix qemu PPC breakage in monitor.c
>>
>> Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64).
>>
>> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>>
>> diff --git a/qemu/monitor.c b/qemu/monitor.c
>> --- a/qemu/monitor.c
>> +++ b/qemu/monitor.c
>> @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con
>>         term_printf("invalid status: %s\n", status);
>>         return;
>>      }
>> +#if defined(TARGET_I386) || defined(TARGET_X86_64)
>>      qemu_system_cpu_hot_add(value, state);
>> +#endif
>>  }
>>
>>  static void do_info_jit(void)
>>     
>
> This should be submitted to qemu-devel too, no?
>
>   

qemu hasn't merged the cpu hotplug patches (yet?).

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-28  8:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 22:14 [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c Jerone Young
2008-02-27 22:14 ` Jerone Young
2008-02-27 22:29 ` [kvm-ppc-devel] " Hollis Blanchard
2008-02-27 22:29   ` Hollis Blanchard
2008-02-28  8:23   ` Avi Kivity [this message]
2008-02-28  8:23     ` Avi Kivity
2008-02-28  8:21 ` [kvm-ppc-devel] [kvm-devel] [PATCH] Fix qemu PPC breakage in Avi Kivity
2008-02-28  8:21   ` [PATCH] Fix qemu PPC breakage in monitor.c Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C66F6C.6050003@qumranet.com \
    --to=avi@qumranet.com \
    --cc=hollisb@us.ibm.com \
    --cc=jyoung5@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.