From: Kevin Wolf <kwolf@suse.de>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Srinivas Maturi <srinivas.maturi@oracle.com>,
xen-devel@lists.xensource.com
Subject: Re: xen-unstable build failure in tools/blktap/drivers for block-qcow2.c
Date: Thu, 28 Feb 2008 13:14:16 +0100 [thread overview]
Message-ID: <47C6A598.7010808@suse.de> (raw)
In-Reply-To: <C3EC3D06.1D279%Keir.Fraser@cl.cam.ac.uk>
> Properly speaking we should check those write() return values anyway. If we
> don't want to deviate from the qemu original sources that much then we could
> special-case CFLAGS to remove -Wno-unused for just that file.
Shouldn't -Wno-unused disable the check rather than enabling it?
Removing it causes even more warnings. Maturi's compiler just seems to
ignore that switch.
I could compile the code with both gcc 4.1.2 and 4.3.0 without any such
problems.
Kevin
next prev parent reply other threads:[~2008-02-28 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 20:08 xen-unstable build failure in tools/blktap/drivers for block-qcow2.c Srinivas Maturi
2008-02-28 10:27 ` Keir Fraser
2008-02-28 12:14 ` Kevin Wolf [this message]
2008-02-28 12:37 ` [PATCH] blktap: Fix unused warnings in block-qcow2.c Kevin Wolf
2008-02-28 13:02 ` xen-unstable build failure in tools/blktap/drivers for block-qcow2.c Keir Fraser
2008-02-28 18:59 ` Srinivas Maturi
2008-02-29 8:18 ` Kevin Wolf
2008-02-29 18:38 ` Srinivas Maturi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C6A598.7010808@suse.de \
--to=kwolf@suse.de \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=srinivas.maturi@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.