From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linuxppc-dev@ozlabs.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code
Date: Sat, 01 Mar 2008 14:43:15 -0500 [thread overview]
Message-ID: <47C9B1D3.3020402@redhat.com> (raw)
In-Reply-To: <tkrat.7e8e04e66a38dcd6@s5r6.in-berlin.de>
Stefan Richter wrote:
> Copied from ohci1394.c. This code is necessary to prevent machine check
> exceptions when reloading or resuming the driver.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
I was able to reproduce the system exception on resume with a 3rd-gen
Titanium PowerBook G4 667, and this patch does let the system resume
successfully now.
Not quite clear if there was possibly an updated version coming using
pci_enable_device() instead of the pair of pmac_call_feature() calls,
but either way, this is a definite must-have, at least for older ppc
macs -- my Aluminum PowerBook G4/1.67 suspends and resumes without this
patch just fine.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code
Date: Sat, 01 Mar 2008 14:43:15 -0500 [thread overview]
Message-ID: <47C9B1D3.3020402@redhat.com> (raw)
In-Reply-To: <tkrat.7e8e04e66a38dcd6@s5r6.in-berlin.de>
Stefan Richter wrote:
> Copied from ohci1394.c. This code is necessary to prevent machine check
> exceptions when reloading or resuming the driver.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
I was able to reproduce the system exception on resume with a 3rd-gen
Titanium PowerBook G4 667, and this patch does let the system resume
successfully now.
Not quite clear if there was possibly an updated version coming using
pci_enable_device() instead of the pair of pmac_call_feature() calls,
but either way, this is a definite must-have, at least for older ppc
macs -- my Aluminum PowerBook G4/1.67 suspends and resumes without this
patch just fine.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
next prev parent reply other threads:[~2008-03-01 19:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 1:42 [PATCH 0/3] firewire: PPC PMac updates Stefan Richter
2008-03-01 1:42 ` [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code Stefan Richter
2008-03-01 2:04 ` Stefan Richter
2008-03-01 2:59 ` Benjamin Herrenschmidt
2008-03-01 2:59 ` Benjamin Herrenschmidt
2008-03-01 8:06 ` Stefan Richter
2008-03-01 11:33 ` [PATCH 0/4] firewire, ieee1394: bus power lost after resume (PPC PMac) Stefan Richter
2008-03-01 11:34 ` [PATCH 1/4] firewire: fw-ohci: switch on bus power after resume on PPC PMac Stefan Richter
2008-03-01 11:34 ` Stefan Richter
2008-03-01 11:35 ` [PATCH 2/4] firewire: fw-ohci: refactor probe, remove, suspend, resume Stefan Richter
2008-03-01 11:35 ` Stefan Richter
2008-03-01 11:36 ` [PATCH 3/4] ieee1394: ohci1394: switch on bus power after resume on PPC PMac Stefan Richter
2008-03-01 11:36 ` Stefan Richter
2008-03-01 11:36 ` [PATCH 4/4] ieee1394: ohci1394: refactor probe, remove, suspend, resume Stefan Richter
2008-03-01 11:36 ` Stefan Richter
2008-03-01 19:43 ` Jarod Wilson [this message]
2008-03-01 19:43 ` [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code Jarod Wilson
2008-03-01 23:48 ` Benjamin Herrenschmidt
2008-03-01 23:48 ` Benjamin Herrenschmidt
2008-03-01 1:47 ` [PATCH 2/3] firewire: fw-ohci: Apple UniNorth 1st generation support Stefan Richter
2008-03-01 1:50 ` [PATCH 3/3] firewire: fw-ohci: shut up false compiler warning on PPC32 Stefan Richter
2008-03-01 3:17 ` Stephen Rothwell
2008-03-01 3:17 ` Stephen Rothwell
2008-03-01 8:10 ` Stefan Richter
2008-03-01 11:21 ` [PATCH 3/3 update] " Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C9B1D3.3020402@redhat.com \
--to=jwilson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.