From: Robert Reif <reif@earthlink.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] hw/slavio_timer.c remove unneeded qemu_irq_lower
Date: Sun, 02 Mar 2008 19:44:18 -0500 [thread overview]
Message-ID: <47CB49E2.2040908@earthlink.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 128 bytes --]
Remove unneeded qemu_irq_lower because user mode timers don't support
IRQs and the IRQ is lowered when switching to user mode.
[-- Attachment #2: timer.diff.txt --]
[-- Type: text/plain, Size: 751 bytes --]
diff -p -u -r1.30 slavio_timer.c
--- hw/slavio_timer.c 26 Jan 2008 09:13:46 -0000 1.30
+++ hw/slavio_timer.c 3 Mar 2008 00:35:28 -0000
@@ -192,7 +192,6 @@ static void slavio_timer_mem_writel(void
uint64_t count;
// set user counter MSW, reset counter
- qemu_irq_lower(s->irq);
s->limit = TIMER_MAX_COUNT64;
s->counthigh = val & (TIMER_MAX_COUNT64 >> 32);
s->reached = 0;
@@ -218,7 +217,6 @@ static void slavio_timer_mem_writel(void
uint64_t count;
// set user counter LSW, reset counter
- qemu_irq_lower(s->irq);
s->limit = TIMER_MAX_COUNT64;
s->count = val & TIMER_MAX_COUNT64;
s->reached = 0;
reply other threads:[~2008-03-03 0:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CB49E2.2040908@earthlink.net \
--to=reif@earthlink.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.