All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	linuxppc-dev@ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUG] 2.6.25-rc3-mm1 kernel panic while bootup on powerpc ()
Date: Tue, 04 Mar 2008 22:08:56 +0200	[thread overview]
Message-ID: <47CDAC58.6090207@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0803041205370.18277@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> I think this is the correct fix.
> 
> The NUMA fallback logic should be passing local_flags to kmem_get_pages() 
> and not simply the flags.
> 
> Maybe a stable candidate since we are now simply 
> passing on flags to the page allocator on the fallback path.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>

Indeed, good catch. I spotted the same thing just few seconds ago.

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

Was it you Kamalesh that reported this? Can you please re-test?

WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	linuxppc-dev@ozlabs.org, Andy Whitcroft <apw@shadowen.org>,
	linux-mm@kvack.org
Subject: Re: [BUG] 2.6.25-rc3-mm1 kernel panic while bootup on powerpc ()
Date: Tue, 04 Mar 2008 22:08:56 +0200	[thread overview]
Message-ID: <47CDAC58.6090207@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0803041205370.18277@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> I think this is the correct fix.
> 
> The NUMA fallback logic should be passing local_flags to kmem_get_pages() 
> and not simply the flags.
> 
> Maybe a stable candidate since we are now simply 
> passing on flags to the page allocator on the fallback path.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>

Indeed, good catch. I spotted the same thing just few seconds ago.

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

Was it you Kamalesh that reported this? Can you please re-test?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-04 20:10 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04  9:19 2.6.25-rc3-mm1 Andrew Morton
2008-03-04 11:59 ` 2.6.25-rc3-mm1 Cornelia Huck
2008-03-04 19:35   ` 2.6.25-rc3-mm1 Greg KH
2008-03-04 13:12 ` [BUG] 2.6.25-rc3-mm1 kernel panic while bootup on powerpc () Kamalesh Babulal
2008-03-04 13:12   ` Kamalesh Babulal
2008-03-04 14:40   ` Michael Neuling
2008-03-04 14:40     ` Michael Neuling
2008-03-04 18:33     ` Andrew Morton
2008-03-04 18:33       ` Andrew Morton
2008-03-05  8:23       ` Benjamin Herrenschmidt
2008-03-05  8:23         ` Benjamin Herrenschmidt
2008-03-06  0:03       ` Benjamin Herrenschmidt
2008-03-06  0:03         ` Benjamin Herrenschmidt
2008-03-06  0:44         ` Andrew Morton
2008-03-06  0:44           ` Andrew Morton
2008-03-06  0:52           ` Benjamin Herrenschmidt
2008-03-06  0:52             ` Benjamin Herrenschmidt
2008-03-04 18:36   ` Andrew Morton
2008-03-04 18:36     ` Andrew Morton
2008-03-04 18:36     ` Andrew Morton
2008-03-04 18:47     ` Pekka Enberg
2008-03-04 18:47       ` Pekka Enberg
2008-03-04 18:47       ` Pekka Enberg
2008-03-04 19:18     ` Pekka Enberg
2008-03-04 19:18       ` Pekka Enberg
2008-03-04 19:18       ` Pekka Enberg
2008-03-04 19:35       ` Mel Gorman
2008-03-04 19:35         ` Mel Gorman
2008-03-04 19:41         ` Pekka Enberg
2008-03-04 19:41           ` Pekka Enberg
2008-03-04 19:56           ` Christoph Lameter
2008-03-04 19:56             ` Christoph Lameter
2008-03-04 20:01             ` Pekka J Enberg
2008-03-04 20:01               ` Pekka J Enberg
2008-03-04 20:02               ` Christoph Lameter
2008-03-04 20:02                 ` Christoph Lameter
2008-03-04 20:07               ` Christoph Lameter
2008-03-04 20:07                 ` Christoph Lameter
2008-03-04 20:08                 ` Pekka Enberg [this message]
2008-03-04 20:08                   ` Pekka Enberg
2008-03-05  2:28                   ` Kamalesh Babulal
2008-03-05  2:28                     ` Kamalesh Babulal
2008-03-04 20:34                 ` Andrew Morton
2008-03-04 20:34                   ` Andrew Morton
2008-03-04 20:44                   ` Pekka Enberg
2008-03-04 20:44                     ` Pekka Enberg
2008-03-04 21:44                     ` Christoph Lameter
2008-03-04 21:44                       ` Christoph Lameter
2008-03-05 14:02                   ` Mel Gorman
2008-03-05 14:02                     ` Mel Gorman
2008-03-05 14:31                 ` Mel Gorman
2008-03-05 14:31                   ` Mel Gorman
2008-03-04 20:01           ` Christoph Lameter
2008-03-04 20:01             ` Christoph Lameter
2008-03-05  8:22   ` Benjamin Herrenschmidt
2008-03-05  8:22     ` Benjamin Herrenschmidt
2008-03-04 16:35 ` 2.6.25-rc3-mm1 (IDE) Randy Dunlap
2008-03-06 21:14   ` Bartlomiej Zolnierkiewicz
2008-03-04 16:45 ` 2.6.25-rc3-mm1 (CCISS) Randy Dunlap
2008-03-04 17:02   ` Miller, Mike (OS Dev)
2008-03-04 17:14     ` Randy Dunlap
2008-03-04 18:14       ` Jens Axboe
2008-03-04 19:12 ` [PATCH 2.6.25-rc3-mm1] fix ext2 borkage Hugh Dickins
2008-03-04 19:20 ` [BUG] 2.6.25-rc3-mm1 kernel bug while running libhugetlbfs Kamalesh Babulal
2008-03-04 19:20   ` Kamalesh Babulal
2008-03-04 19:51   ` Andrew Morton
2008-03-04 19:51     ` Andrew Morton
2008-03-04 22:01     ` Adam Litke
2008-03-04 22:01       ` Adam Litke
2008-03-05  7:52       ` Kamalesh Babulal
2008-03-05  7:52         ` Kamalesh Babulal
2008-03-04 20:24 ` 2.6.25-rc3-mm1 (wakeup) Randy Dunlap
2008-03-04 22:33   ` Rafael J. Wysocki
2008-03-05  7:40     ` Sam Ravnborg
2008-03-04 21:26 ` 2.6.25-rc3-mm1 (9p docs) Randy Dunlap
2008-03-04 21:43   ` Eric Van Hensbergen
2008-03-05  7:21 ` 2.6.25-rc3-mm1 - PROFILE_LIKELY redux Valdis.Kletnieks
2008-03-05 17:45   ` Andi Kleen
2008-03-05 18:02     ` Andrew Morton
2008-03-05 18:22       ` Andi Kleen
2008-03-05 22:26       ` Valdis.Kletnieks
2008-03-05 23:49         ` Andrew Morton
2008-03-05 19:59     ` Valdis.Kletnieks
2008-03-05 21:56       ` Andi Kleen
2008-03-05 10:51 ` prctl(0x8) -> EINVAL [Was: 2.6.25-rc3-mm1] Jiri Slaby
2008-03-05 10:59   ` Jiri Slaby
2008-03-05 14:06   ` Serge E. Hallyn
2008-03-05 15:18     ` Jiri Slaby
2008-03-09 16:28     ` Andrew Morgan
2008-03-05 13:04 ` 2.6.25-rc3-mm1 Pavel Emelyanov
2008-03-05 13:12   ` 2.6.25-rc3-mm1 (SYSFS=n breaks module engine) Pavel Emelyanov
2008-03-05 13:31   ` 2.6.25-rc3-mm1 Kay Sievers
2008-03-05 13:38     ` 2.6.25-rc3-mm1 Pavel Emelyanov
2008-03-05 13:54       ` 2.6.25-rc3-mm1 Kay Sievers
2008-03-05 14:28         ` 2.6.25-rc3-mm1 Pavel Emelyanov
2008-03-05 16:40   ` 2.6.25-rc3-mm1 Greg KH
2008-03-05 16:59     ` 2.6.25-rc3-mm1 Pavel Emelyanov
2008-03-05 17:07       ` 2.6.25-rc3-mm1 Greg KH
2008-03-05 21:34 ` 2.6.25-rc3-mm1 ppc64 boot hang Badari Pulavarty
2008-03-05 21:34   ` Badari Pulavarty
2008-03-05 21:54   ` Andrew Morton
2008-03-05 21:54     ` Andrew Morton
2008-03-05 22:35     ` Badari Pulavarty
2008-03-05 22:35       ` Badari Pulavarty
2008-03-05 23:17     ` Stephen Rothwell
2008-03-05 23:17       ` Stephen Rothwell
2008-03-07  3:58 ` 2.6.25-rc3-mm1 - BUG at system shutdown time Valdis.Kletnieks
2008-03-07  6:16   ` Andrew Morton
2008-03-07  7:52     ` Valdis.Kletnieks
2008-03-07  8:06       ` Thomas Gleixner
2008-03-07  8:23         ` Valdis.Kletnieks
2008-03-07  8:34           ` Thomas Gleixner
2008-03-07 19:30             ` Valdis.Kletnieks
2008-03-12  7:32   ` Andrew Morton
2008-03-13  2:19     ` Valdis.Kletnieks
2008-03-13  2:32       ` Andrew Morton
2008-03-13  3:57         ` Valdis.Kletnieks
2008-03-13  4:27           ` Andrew Morton
2008-03-14 18:50             ` Valdis.Kletnieks
2008-03-21 13:41       ` Ingo Molnar
2008-03-21 19:38         ` Valdis.Kletnieks
2008-03-21 19:58           ` Ingo Molnar
2008-03-21 20:05             ` Valdis.Kletnieks
2008-03-21 20:12               ` Ingo Molnar
2008-03-22  3:11                 ` Hoo-fscking-ray - (was " Valdis.Kletnieks
2008-03-22 12:09                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CDAC58.6090207@cs.helsinki.fi \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.