Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Emelianov <xemul@openvz.org>,
	Hugh Dickins <hugh@veritas.com>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>,
	YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
	taka@valinux.co.jp, linux-mm@kvack.org,
	David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)
Date: Fri, 07 Mar 2008 18:59:00 +0530	[thread overview]
Message-ID: <47D1431C.6060107@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830803070509v1ec83aeet9f63bfd61a00ef19@mail.gmail.com>

Paul Menage wrote:
> On Fri, Mar 7, 2008 at 4:58 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>>  > Or rather, it's the other way around - cgroup_disable=cpuset will
>>  > instead disable the "cpu" subsystem if "cpu" comes before "cpuset" in
>>  > the subsystem list.
>>  >
>>
>>  Would it? I must be missing something, since we do a strncmp with ss->name.
>>  I would expect that to match whole strings.
>>
> 
> No, strncmp only checks the first n characters - so in that case,
> you'd be checking for !strncmp("cpuset", "cpu", 3), which will return
> true

Aaah.. I see the problem now.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

WARNING: multiple messages have this Message-ID (diff)

From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Emelianov <xemul@openvz.org>,
	Hugh Dickins <hugh@veritas.com>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>,
	YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
	taka@valinux.co.jp, linux-mm@kvack.org,
	David Rientjes <rientjes@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)
Date: Fri, 07 Mar 2008 18:59:00 +0530	[thread overview]
Message-ID: <47D1431C.6060107@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830803070509v1ec83aeet9f63bfd61a00ef19@mail.gmail.com>

Paul Menage wrote:
> On Fri, Mar 7, 2008 at 4:58 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>>  > Or rather, it's the other way around - cgroup_disable=cpuset will
>>  > instead disable the "cpu" subsystem if "cpu" comes before "cpuset" in
>>  > the subsystem list.
>>  >
>>
>>  Would it? I must be missing something, since we do a strncmp with ss->name.
>>  I would expect that to match whole strings.
>>
> 
> No, strncmp only checks the first n characters - so in that case,
> you'd be checking for !strncmp("cpuset", "cpu", 3), which will return
> true

Aaah.. I see the problem now.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2008-03-07 13:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07  8:57 [PATCH] Add cgroup support for enabling controllers at boot time (v2) Balbir Singh
2008-03-07  8:57 ` Balbir Singh
2008-03-07  8:57 ` [PATCH] Make memory resource control aware of boot options (v2) Balbir Singh
2008-03-07  8:57   ` Balbir Singh
2008-03-07  9:06   ` Andrew Morton
2008-03-07  9:06     ` Andrew Morton
2008-03-07  9:08     ` Andrew Morton
2008-03-07  9:08       ` Andrew Morton
2008-03-07  9:15       ` Balbir Singh
2008-03-07  9:15         ` Balbir Singh
2008-03-07  9:04 ` [PATCH] Add cgroup support for enabling controllers at boot time (v2) David Rientjes
2008-03-07  9:04   ` David Rientjes
2008-03-07  9:25 ` Paul Menage
2008-03-07  9:25   ` Paul Menage
2008-03-07 12:26   ` Paul Menage
2008-03-07 12:26     ` Paul Menage
2008-03-07 12:58     ` Balbir Singh
2008-03-07 12:58       ` Balbir Singh
2008-03-07 13:09       ` Paul Menage
2008-03-07 13:09         ` Paul Menage
2008-03-07 13:29         ` Balbir Singh [this message]
2008-03-07 13:29           ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D1431C.6060107@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=rientjes@google.com \
    --cc=skumar@linux.vnet.ibm.com \
    --cc=taka@valinux.co.jp \
    --cc=xemul@openvz.org \
    --cc=yamamoto@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.