All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] [6/13] Core maskable allocator
Date: Fri, 07 Mar 2008 09:33:02 -0800	[thread overview]
Message-ID: <47D17C4E.9000302@oracle.com> (raw)
In-Reply-To: <20080307173146.GI7365@one.firstfloor.org>

Andi Kleen wrote:
>>> +	maskzone=size[MG] Set size of maskable DMA zone to size.
>>> +		 force	Always allocate from the mask zone (for testing)
>>                  ^^^^^^^^^^^^^ ??
> 
> What is your question?

That line seems odd.  Is it correct?
Why 2 spaces between force and Always?  Why is Always capitalized?
Could one of those words be dropped?  They seem a bit redundant.

-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] [6/13] Core maskable allocator
Date: Fri, 07 Mar 2008 09:33:02 -0800	[thread overview]
Message-ID: <47D17C4E.9000302@oracle.com> (raw)
In-Reply-To: <20080307173146.GI7365@one.firstfloor.org>

Andi Kleen wrote:
>>> +	maskzone=size[MG] Set size of maskable DMA zone to size.
>>> +		 force	Always allocate from the mask zone (for testing)
>>                  ^^^^^^^^^^^^^ ??
> 
> What is your question?

That line seems odd.  Is it correct?
Why 2 spaces between force and Always?  Why is Always capitalized?
Could one of those words be dropped?  They seem a bit redundant.

-- 
~Randy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-07 17:34 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07  9:07 [PATCH] [0/13] General DMA zone rework Andi Kleen
2008-03-07  9:07 ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [2/13] Make get_order(0) return 0 Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [3/13] Make kvm bad_page symbol static Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [4/13] Prepare page_alloc for the maskable allocator Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07 18:19   ` Sam Ravnborg
2008-03-07 18:19     ` Sam Ravnborg
2008-03-07 18:36     ` Cyrill Gorcunov
2008-03-07 18:36       ` Cyrill Gorcunov
2008-03-07 19:02     ` Andi Kleen
2008-03-07 19:02       ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [5/13] Add mask allocator statistics to vmstat.[ch] Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-08  2:24   ` Christoph Lameter
2008-03-08  2:24     ` Christoph Lameter
2008-03-07  9:07 ` [PATCH] [6/13] Core maskable allocator Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07 10:53   ` Johannes Weiner
2008-03-07 10:53     ` Johannes Weiner
2008-03-07 11:14     ` Andi Kleen
2008-03-07 11:14       ` Andi Kleen
2008-03-07 17:05   ` Randy Dunlap
2008-03-07 17:05     ` Randy Dunlap
2008-03-07 17:31     ` Andi Kleen
2008-03-07 17:31       ` Andi Kleen
2008-03-07 17:33       ` Randy Dunlap [this message]
2008-03-07 17:33         ` Randy Dunlap
2008-03-07 17:43         ` Andi Kleen
2008-03-07 17:43           ` Andi Kleen
2008-03-07 17:51           ` Randy Dunlap
2008-03-07 17:51             ` Randy Dunlap
2008-03-07 21:13   ` Cyrill Gorcunov
2008-03-07 21:13     ` Cyrill Gorcunov
2008-03-07 23:28     ` Andi Kleen
2008-03-07 23:28       ` Andi Kleen
2008-03-08  5:03   ` KAMEZAWA Hiroyuki
2008-03-08  5:03     ` KAMEZAWA Hiroyuki
2008-03-08  5:41     ` KAMEZAWA Hiroyuki
2008-03-08  5:41       ` KAMEZAWA Hiroyuki
2008-03-08 11:41     ` Andi Kleen
2008-03-08 11:41       ` Andi Kleen
2008-03-11 15:34   ` Jonathan Corbet
2008-03-11 15:34     ` Jonathan Corbet
2008-03-11 15:54     ` Andi Kleen
2008-03-11 15:54       ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [7/13] Implement compat hooks for GFP_DMA Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [8/13] Enable the mask allocator for x86 Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07 18:32   ` Sam Ravnborg
2008-03-07 18:32     ` Sam Ravnborg
2008-03-07 19:03     ` Andi Kleen
2008-03-07 19:03       ` Andi Kleen
2008-03-07 19:09       ` Sam Ravnborg
2008-03-07 19:09         ` Sam Ravnborg
2008-03-08  2:37   ` Christoph Lameter
2008-03-08  2:37     ` Christoph Lameter
2008-03-08  6:35     ` Yinghai Lu
2008-03-08  6:35       ` Yinghai Lu
2008-03-08  7:31       ` Christoph Lameter
2008-03-08  7:31         ` Christoph Lameter
2008-03-08 11:54     ` Andi Kleen
2008-03-08 11:54       ` Andi Kleen
2008-03-10 17:13       ` Christoph Lameter
2008-03-10 17:13         ` Christoph Lameter
2008-03-07  9:07 ` [PATCH] [9/13] Remove set_dma_reserve Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [10/13] Switch the 32bit dma_alloc_coherent functions over to use the maskable allocator Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [11/13] Switch x86-64 dma_alloc_coherent over to " Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07  9:07 ` [PATCH] [12/13] Add vmstat statistics for new swiotlb code Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-08  2:38   ` Christoph Lameter
2008-03-08  2:38     ` Christoph Lameter
2008-03-07  9:07 ` [PATCH] [13/13] Convert x86-64 swiotlb to use the mask allocator directly Andi Kleen
2008-03-07  9:07   ` Andi Kleen
2008-03-07 15:18 ` [PATCH] [0/13] General DMA zone rework Rene Herman
2008-03-07 15:18   ` Rene Herman
2008-03-07 15:22   ` Rene Herman
2008-03-07 15:22     ` Rene Herman
2008-03-07 15:31     ` Andi Kleen
2008-03-07 15:31       ` Andi Kleen
2008-03-07 15:34   ` Andi Kleen
2008-03-07 15:34     ` Andi Kleen
2008-03-07 20:51 ` Luiz Fernando N. Capitulino
2008-03-07 20:51   ` Luiz Fernando N. Capitulino
2008-03-08  0:46   ` Andi Kleen
2008-03-08  0:46     ` Andi Kleen
2008-03-10 18:03     ` Luiz Fernando N. Capitulino
2008-03-10 18:03       ` Luiz Fernando N. Capitulino
2008-03-10 18:08       ` Andi Kleen
2008-03-10 18:08         ` Andi Kleen
2008-03-11 17:26         ` Luiz Fernando N. Capitulino
2008-03-11 17:26           ` Luiz Fernando N. Capitulino
2008-03-11 17:35           ` Andi Kleen
2008-03-11 17:35             ` Andi Kleen
2008-03-11 18:00             ` Luiz Fernando N. Capitulino
2008-03-11 18:00               ` Luiz Fernando N. Capitulino
2008-03-11 18:49               ` Andi Kleen
2008-03-11 18:49                 ` Andi Kleen
2008-03-11 19:36                 ` Luiz Fernando N. Capitulino
2008-03-11 19:36                   ` Luiz Fernando N. Capitulino
2008-03-08  2:42 ` Christoph Lameter
2008-03-08  2:42   ` Christoph Lameter
2008-03-08 11:57   ` Andi Kleen
2008-03-08 11:57     ` Andi Kleen
2008-03-10 17:14     ` Christoph Lameter
2008-03-10 17:14       ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D17C4E.9000302@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.