From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joe Perches <joe@perches.com>
Cc: e1000-devel@lists.sourceforge.net,
xfs-masters <xfs-masters@oss.sgi.com>,
kernel-janitors@vger.kernel.org, Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [E1000-devel] [PATCH] drivers/net: convert & to &&
Date: Fri, 07 Mar 2008 18:38:01 +0000 [thread overview]
Message-ID: <47D18B89.4000706@intel.com> (raw)
In-Reply-To: <1204914033.5541.74.camel@localhost>
Joe Perches wrote:
> On Thu, 2008-03-06 at 10:07 -0800, Kok, Auke wrote:
>> (which, BTW also could use the uint32_t -> u32 (etc) changes... while you're at it)
>
> I think this does what you want:
>
> for size in "8" "16" "32" "64" ; do \
> sed -r -i -e 's/\bu_{0,1}int'$size'_t\b/u'$size'/g' \
> $(grep -rPlw --include=*.[ch] 'u_{0,1}int'$size'_t' drivers/net/e1000 drivers/net/ixgb); done
>
> But why? boolean_t is used by 3 subsystems with local typedefs.
> These others are much more frequently used by kernel source.
afaik they're really meant for userspace related code and don't belong in our
driver from that perspective.
> $ grep -rPlw --include=*.[ch] "u{0,1}_{0,1}int(8|16|32|64)_t" * | wc -l
> 876
yes, a lot of that *is* userspace related code.
do the same search in drivers/net/ .... you'll see the only drivers using this for
everything is our old drivers...
Auke
WARNING: multiple messages have this Message-ID (diff)
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joe Perches <joe@perches.com>
Cc: e1000-devel@lists.sourceforge.net,
xfs-masters <xfs-masters@oss.sgi.com>,
kernel-janitors@vger.kernel.org, Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [E1000-devel] [PATCH] drivers/net: convert & to &&
Date: Fri, 07 Mar 2008 10:38:01 -0800 [thread overview]
Message-ID: <47D18B89.4000706@intel.com> (raw)
In-Reply-To: <1204914033.5541.74.camel@localhost>
Joe Perches wrote:
> On Thu, 2008-03-06 at 10:07 -0800, Kok, Auke wrote:
>> (which, BTW also could use the uint32_t -> u32 (etc) changes... while you're at it)
>
> I think this does what you want:
>
> for size in "8" "16" "32" "64" ; do \
> sed -r -i -e 's/\bu_{0,1}int'$size'_t\b/u'$size'/g' \
> $(grep -rPlw --include=*.[ch] 'u_{0,1}int'$size'_t' drivers/net/e1000 drivers/net/ixgb); done
>
> But why? boolean_t is used by 3 subsystems with local typedefs.
> These others are much more frequently used by kernel source.
afaik they're really meant for userspace related code and don't belong in our
driver from that perspective.
> $ grep -rPlw --include=*.[ch] "u{0,1}_{0,1}int(8|16|32|64)_t" * | wc -l
> 876
yes, a lot of that *is* userspace related code.
do the same search in drivers/net/ .... you'll see the only drivers using this for
everything is our old drivers...
Auke
next prev parent reply other threads:[~2008-03-07 18:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 17:41 [PATCH] drivers/net: convert & to && Julia Lawall
2008-03-06 17:41 ` Julia Lawall
2008-03-06 17:59 ` Joe Perches
2008-03-06 17:59 ` Joe Perches
2008-03-06 18:07 ` [E1000-devel] " Kok, Auke
2008-03-06 18:07 ` Kok, Auke
2008-03-07 1:22 ` [PATCH] drivers/net/e1000 - Convert boolean_t to bool Joe Perches
2008-03-07 1:22 ` Joe Perches
2008-03-07 1:24 ` [PATCH] drivers/net/ixgb - convert " Joe Perches
2008-03-07 1:24 ` Joe Perches
2008-03-07 17:14 ` Kok, Auke
2008-03-07 17:14 ` Kok, Auke
2008-03-07 18:20 ` [E1000-devel] [PATCH] drivers/net: convert & to && Joe Perches
2008-03-07 18:20 ` Joe Perches
2008-03-07 18:38 ` Kok, Auke [this message]
2008-03-07 18:38 ` Kok, Auke
2008-03-10 12:20 ` walter harms
2008-03-10 12:20 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D18B89.4000706@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.