htcuni.patch generic for all devices?

htcuni.patch generic for all devices?

[Junqian Gordon Xu]

htcuni.patch is not clean in .dev and breaks linux-rp_2.6.24 for all 
devices. My questions is why this patch was applied to all devices in 
thefirst place. Shouldn't this patch be put under the htcuniversal 
section, regardless if it's broken or not?

Regards
Gordon

#
# old_revision [b61252165c378556cbcf99189fda2993232e1c3e]
#
# patch "packages/linux/linux-rp_2.6.24.bb"
#  from [9e6dea22aa706ffd224579092a86fb5572432109]
#    to [f0a3a1d140b091261e05dbd98aab07db9a786aac]
#
============================================================
--- packages/linux/linux-rp_2.6.24.bb 
9e6dea22aa706ffd224579092a86fb5572432109
+++ packages/linux/linux-rp_2.6.24.bb 
f0a3a1d140b091261e05dbd98aab07db9a786aac
@@ -56,7 +56,6 @@ SRC_URI = "${KERNELORG_MIRROR}pub/linux/
             file://pxa-serial-hack.patch;patch=1;status=hack \
             file://connectplus-remove-ide-HACK.patch;patch=1;status=hack \
 
file://connectplus-prevent-oops-HACK.patch;patch=1;status=hack \
-           file://htcuni.patch;patch=1 \
             file://binutils-buildid-arm.patch;patch=1 \
             file://versatile-armv6.patch;patch=1 \
             file://defconfig-c7x0 \
@@ -194,6 +193,7 @@ SRC_URI_append_htcuniversal ="\

  SRC_URI_append_htcuniversal ="\
  	file://htcuni-acx.patch;patch=1;status=external \
+#       file://htcuni.patch;patch=1 \
  	"

  SRC_URI_append_zylonite ="\

Re: htcuni.patch generic for all devices?

[Stanislav Brabec]

Junqian Gordon Xu wrote:
> htcuni.patch is not clean in .dev and breaks linux-rp_2.6.24 for all 
> devices. My questions is why this patch was applied to all devices in 
> thefirst place. Shouldn't this patch be put under the htcuniversal 
> section, regardless if it's broken or not?

I am not a HTC Universal user, so I cannot test its function, but from
aspect of other devices, it looks clean and does not break my Zaurus
kernel.

Consequent reject in another patch sharpsl-rc is another problem,
trivial to fix.

Richard, what is your opinion? Do you prefer device specific patch sets
or making all clean enough patches generic?

-- 
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus

Re: htcuni.patch generic for all devices?

[Richard Purdie]

On Mon, 2008-03-10 at 11:22 +0100, Stanislav Brabec wrote:
> Junqian Gordon Xu wrote:
> > htcuni.patch is not clean in .dev and breaks linux-rp_2.6.24 for all 
> > devices. My questions is why this patch was applied to all devices in 
> > thefirst place. Shouldn't this patch be put under the htcuniversal 
> > section, regardless if it's broken or not?
> 
> I am not a HTC Universal user, so I cannot test its function, but from
> aspect of other devices, it looks clean and does not break my Zaurus
> kernel.
> 
> Consequent reject in another patch sharpsl-rc is another problem,
> trivial to fix.
> 
> Richard, what is your opinion? Do you prefer device specific patch sets
> or making all clean enough patches generic?

I favour making clean generic patches which are applied on all machines.
Anything intending to head for mainline needs to cope with this and the
patches are in linux-rp are mainly intended for mainline.

I know I didn't do that with the tosa checkin but I do hope to find time
to resolve that soon :)

I will try and test out the status of 2.6.24 and fix the various issues
I'm aware of today.

Cheers,

Richard