All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] fs/ocfs2/cluster/heartbeat.c: misplaced parentheses in o2hb_setup_one_bio()?
@ 2008-03-09 11:35 Roel Kluin
  2008-03-09 11:51 ` [Ocfs2-devel] " Roel Kluin
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-03-09 11:35 UTC (permalink / raw)
  To: ocfs2-devel

from fs/ocfs2/cluster/heartbeat.c:265:

vec_start = (cs << bits) % PAGE_CACHE_SIZE;

shouldn't this be

vec_start = cs << (bits % PAGE_CACHE_SIZE);

?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Ocfs2-devel] Re: fs/ocfs2/cluster/heartbeat.c: misplaced parentheses in o2hb_setup_one_bio()?
  2008-03-09 11:35 [Ocfs2-devel] fs/ocfs2/cluster/heartbeat.c: misplaced parentheses in o2hb_setup_one_bio()? Roel Kluin
@ 2008-03-09 11:51 ` Roel Kluin
  0 siblings, 0 replies; 2+ messages in thread
From: Roel Kluin @ 2008-03-09 11:51 UTC (permalink / raw)
  To: ocfs2-devel

Roel Kluin wrote:
> from fs/ocfs2/cluster/heartbeat.c:265:
> 
> vec_start = (cs << bits) % PAGE_CACHE_SIZE;
> 
> shouldn't this be
> 
> vec_start = cs << (bits % PAGE_CACHE_SIZE);
> 
> ?

Nevermind, it is probably right. Sorry for the noise.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-09 11:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-09 11:35 [Ocfs2-devel] fs/ocfs2/cluster/heartbeat.c: misplaced parentheses in o2hb_setup_one_bio()? Roel Kluin
2008-03-09 11:51 ` [Ocfs2-devel] " Roel Kluin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.