From: Roel Kluin <12o3l@tiscali.nl>
To: Segher Boessenkool <segher@kernel.crashing.org>,
akpm@linux-foundation.org
Cc: Colin Leroy <colin@colino.net>,
"Darrick J. Wong" <djwong@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Date: Mon, 10 Mar 2008 22:17:57 +0100 [thread overview]
Message-ID: <47D5A585.8050107@tiscali.nl> (raw)
In-Reply-To: <64d5b5e6dfd0d1820d21db323ef88e25@kernel.crashing.org>
Andrew, I think you may want this patch instead of the other
adt746x-logical-bitwise-confusion-in-set_max_duty_at_crit.patch
It includes suggested changes by Segher Boessenkool and I think this
version was tested by Darrick J. Wong
---
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index 9587869..2a2de73 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -566,11 +566,11 @@ static ssize_t set_max_duty_at_crit(struct device *dev,
const char *buf,
size_t count)
{
- u8 reg;
+ u8 reg, temp;
struct i2c_client *client = to_i2c_client(dev);
struct adt7473_data *data = i2c_get_clientdata(client);
- int temp = simple_strtol(buf, NULL, 10);
- temp = temp && 0xFF;
+
+ temp = simple_strtol(buf, NULL, 10) & 0xFF;
mutex_lock(&data->lock);
data->max_duty_at_overheat = temp;
WARNING: multiple messages have this Message-ID (diff)
From: Roel Kluin <12o3l@tiscali.nl>
To: Segher Boessenkool <segher@kernel.crashing.org>,
akpm@linux-foundation.org
Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
lkml <linux-kernel@vger.kernel.org>,
Colin Leroy <colin@colino.net>,
"Darrick J. Wong" <djwong@us.ibm.com>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Date: Mon, 10 Mar 2008 22:17:57 +0100 [thread overview]
Message-ID: <47D5A585.8050107@tiscali.nl> (raw)
In-Reply-To: <64d5b5e6dfd0d1820d21db323ef88e25@kernel.crashing.org>
Andrew, I think you may want this patch instead of the other
adt746x-logical-bitwise-confusion-in-set_max_duty_at_crit.patch
It includes suggested changes by Segher Boessenkool and I think this
version was tested by Darrick J. Wong
---
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index 9587869..2a2de73 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -566,11 +566,11 @@ static ssize_t set_max_duty_at_crit(struct device *dev,
const char *buf,
size_t count)
{
- u8 reg;
+ u8 reg, temp;
struct i2c_client *client = to_i2c_client(dev);
struct adt7473_data *data = i2c_get_clientdata(client);
- int temp = simple_strtol(buf, NULL, 10);
- temp = temp && 0xFF;
+
+ temp = simple_strtol(buf, NULL, 10) & 0xFF;
mutex_lock(&data->lock);
data->max_duty_at_overheat = temp;
next prev parent reply other threads:[~2008-03-10 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 0:04 ADT746X: logical-bitwise & confusion in set_max_duty_at_crit() Roel Kluin
2008-03-10 7:46 ` Colin Leroy
2008-03-10 8:06 ` Benjamin Herrenschmidt
2008-03-10 8:22 ` Roel Kluin
2008-03-10 8:22 ` Roel Kluin
2008-03-10 9:13 ` Segher Boessenkool
2008-03-10 9:13 ` Segher Boessenkool
2008-03-10 9:59 ` Roel Kluin
2008-03-10 9:59 ` Roel Kluin
2008-03-10 18:13 ` Darrick J. Wong
2008-03-10 18:13 ` Darrick J. Wong
2008-03-10 21:17 ` Roel Kluin [this message]
2008-03-10 21:17 ` Roel Kluin
2008-03-10 21:56 ` Segher Boessenkool
2008-03-10 21:56 ` Segher Boessenkool
2008-03-10 22:15 ` Roel Kluin
2008-03-10 22:15 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5A585.8050107@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=colin@colino.net \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.