All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi_bitbang: txrx_bufs zero status fix
@ 2008-03-11 10:05 Jan Nikitenko
  0 siblings, 0 replies; only message in thread
From: Jan Nikitenko @ 2008-03-11 10:05 UTC (permalink / raw)
  To: David Brownell; +Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

SPI controller drivers return number of bytes actually transfered from
bitbang->txrx_bufs() method. Returned zero number of bytes transfered
when non-zero number of bytes to transfer was requested should be
recognized as error.
The patch fixes that.

Signed-off-by: Jan Nikitenko <jan.nikitenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

---

 spi_bitbang.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

[-- Attachment #2: spi_bitbang-txrx_bufs-zero-status-fix.patch --]
[-- Type: text/plain, Size: 497 bytes --]

diff --git a/drivers/spi/spi_bitbang.c b/drivers/spi/spi_bitbang.c
index f7f8580..83c911b 100644
--- a/drivers/spi/spi_bitbang.c
+++ b/drivers/spi/spi_bitbang.c
@@ -345,7 +345,9 @@ static void bitbang_work(struct work_struct *work)
 				status = bitbang->txrx_bufs(spi, t);
 			}
 			if (status != t->len) {
-				if (status > 0)
+				/* zero status, meaning zero number of bytes
+				 * transfered, is also invalid in this case */
+				if (status >= 0)
 					status = -EMSGSIZE;
 				break;
 			}

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 210 bytes --]

_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-11 10:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-11 10:05 [PATCH] spi_bitbang: txrx_bufs zero status fix Jan Nikitenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.