Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Thomas Jacob]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hiya,

I've updated the geoip patchlet a bit so that it
compiles cleanly with current versions and it
seems to work for me (see attachment). This
is based on work done here:
http://bjerkeset.com/patches/geoip-match-2.6.22.patch.gz

Emails to the authors are bouncing, so I'll try
this list instead. Feel free to include the changes anywhere you like.

     Regards
         Thomas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Jan Engelhardt]

On Mar 13 2008 13:11, Thomas Jacob wrote:
>Hiya,
>
>I've updated the geoip patchlet a bit so that it
>compiles cleanly with current versions and it
>seems to work for me (see attachment). This
>is based on work done here:
>http://bjerkeset.com/patches/geoip-match-2.6.22.patch.gz
>
>Emails to the authors are bouncing, so I'll try
>this list instead. Feel free to include the changes anywhere you like.

Nicolas has an all-around updated geoip at
http://people.netfilter.org/acidfu/patchlets/ .
Better check back first :)

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Samuel Jean]

Hey Thomas --

On Thu, Mar 13, 2008 at 8:11 AM, Thomas Jacob <jacob@internet24.de> wrote:
> Hiya,
>
>  I've updated the geoip patchlet a bit so that it
>  compiles cleanly with current versions and it
>  seems to work for me (see attachment).

Thanks !

>  This is based on work done here:
>  http://bjerkeset.com/patches/geoip-match-2.6.22.patch.gz
>

Nicolas recently took over maintaining this patchlet. This link refers
to his latest release of geoip.

http://people.netfilter.org/acidfu/patchlets/geoip.tar.gz

I should have sent a patch months ago to update the URL in sources.list.
Sorry for the inconveniant.

Regards,
Samuel

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Samuel Jean]

Jan --

On Thu, Mar 13, 2008 at 8:52 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>  Nicolas has an all-around updated geoip at
>  http://people.netfilter.org/acidfu/patchlets/ .
>  Better check back first :)

Would you mind to send a patch to Patrick about this ?

--
# geoip, maintained by Nicolas Bouliane <acidfu@people.netfilter.org>
http://people.netfilter.org/acidfu/patchlets
--

I apologize to everyone, this i-will-do-it-later of me is enough.
I don't have the opportunity to do it at work. Thanks !


Samuel

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Thomas Jacob]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

On Thu, 2008-03-13 at 08:54 -0400, Samuel Jean wrote:
> Nicolas recently took over maintaining this patchlet. This link refers
> to his latest release of geoip.
> 
> http://people.netfilter.org/acidfu/patchlets/geoip.tar.gz
> 
> I should have sent a patch months ago to update the URL in sources.list.
> Sorry for the inconveniant.

No problem, I'd much rather rely on something done by you guys, that
is people who actually know anything about netfilter internals ;-)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Jan Engelhardt]

On Mar 13 2008 09:01, Samuel Jean wrote:
>Jan --
>
>On Thu, Mar 13, 2008 at 8:52 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>>  Nicolas has an all-around updated geoip at
>>  http://people.netfilter.org/acidfu/patchlets/ .
>>  Better check back first :)
>
>Would you mind to send a patch to Patrick about this ?

I am not sure whether this would go into mainline kernel.
  As I seem to recall, Nicolas still wanted to work on geoip,
but he was last seen in India with little time. I can see that the 
code does need cleanup, so I'll do that and import it into 
xtables-addons for the time being.

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Samuel Jean]

On Thu, Mar 13, 2008 at 9:31 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
>  On Mar 13 2008 09:01, Samuel Jean wrote:
>  >Would you mind to send a patch to Patrick about this ?
>
>  I am not sure whether this would go into mainline kernel.

Uhm.. I don't think it will ever go into mainline, geoip is
fully dependant on 3rd parties databases.

>  I can see that the
>  code does need cleanup, so I'll do that and import it into
>  xtables-addons for the time being.

Looks great but updating the patch-o-matic's sources.list file
with the proper URL and maintainer name will make people
stop wasting precious time hacking geoip unless they are
aware that geoip's been imported into xtables-addons.

And by the way, keep up the good work.

Samuel

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Pablo Neira Ayuso]

Samuel Jean wrote:
> Jan --
> 
> On Thu, Mar 13, 2008 at 8:52 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>>  Nicolas has an all-around updated geoip at
>>  http://people.netfilter.org/acidfu/patchlets/ .
>>  Better check back first :)
> 
> Would you mind to send a patch to Patrick about this ?
> 
> --
> # geoip, maintained by Nicolas Bouliane <acidfu@people.netfilter.org>
> http://people.netfilter.org/acidfu/patchlets

You mean to update the patch-o-matic file? I'll do this tonight.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Jan Engelhardt]

On Mar 13 2008 09:43, Samuel Jean wrote:
>On Thu, Mar 13, 2008 at 9:31 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>>
>>  On Mar 13 2008 09:01, Samuel Jean wrote:
>>  >Would you mind to send a patch to Patrick about this ?
>>
>>  I am not sure whether this would go into mainline kernel.
>
>Uhm.. I don't think it will ever go into mainline, geoip is
>fully dependant on 3rd parties databases.

Is the db redistributable; what does the license say?

BTW, geoip.c is coded like checkentry() could be called twice
without a destroy in between -- how is this possible anyway?

        /* 
         * If info->refcount is not NULL, then it means that checkentry() 
         * already initialized this entry. Increase a refcount to prevent 
         * destroy() of this entry. 
         */

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[NICOLAS BOULIANE]

Sorry guys I was in Varanasi for the last 2 weeks,
I will read the thread tomorrow.

thanks.

Nick

On Thu, Mar 13, 2008 at 1:12 PM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
>  On Mar 13 2008 09:43, Samuel Jean wrote:
>  >On Thu, Mar 13, 2008 at 9:31 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>  >>
>  >>  On Mar 13 2008 09:01, Samuel Jean wrote:
>  >>  >Would you mind to send a patch to Patrick about this ?
>  >>
>  >>  I am not sure whether this would go into mainline kernel.
>  >
>  >Uhm.. I don't think it will ever go into mainline, geoip is
>  >fully dependant on 3rd parties databases.
>
>  Is the db redistributable; what does the license say?
>
>  BTW, geoip.c is coded like checkentry() could be called twice
>  without a destroy in between -- how is this possible anyway?
>
>         /*
>          * If info->refcount is not NULL, then it means that checkentry()
>          * already initialized this entry. Increase a refcount to prevent
>          * destroy() of this entry.
>          */
>

Re: Updated geoip patchlet for Xtables 1.5.2 / 2.6.18--2.6.25 (was: iptables 1.4.0 / 2.6.24.3)

[Jan Engelhardt]

On Mar 13 2008 09:43, Samuel Jean wrote:
>
>>  I can see that the
>>  code does need cleanup, so I'll do that and import it into
>>  xtables-addons for the time being.
>
>Looks great but updating the patch-o-matic's sources.list file
>with the proper URL and maintainer name will make people
>stop wasting precious time hacking geoip unless they are
>aware that geoip's been imported into xtables-addons.
>And by the way, keep up the good work.

Well well, it is just a recent idea that lived for 48h so far.
But I am done with it now with the prerelease, please give it
some testing!
    git://dev.computergmbh.de/xtables-addons : "geoip" branch
or as .tar:
    http://jengelh.hopto.org/files/geoip/
    (you need geoip_iv0 too - the geoip database).

There was a fair bit to do, changelog is http://tinyurl.com/2xbvpa

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[NICOLAS BOULIANE]

Pablo,

# geoip, maintained by Samuel Jean <jix@bugmachine.ca>
http://people.netfilter.org/acidfu/patchlets/

Could you add me as the new official maintainer please ?
Nicolas Bouliane <acidfu@people.netfilter.org>

thanks,

Nick

On Fri, Mar 14, 2008 at 3:02 AM, NICOLAS BOULIANE <nicboul@gmail.com> wrote:
> Sorry guys I was in Varanasi for the last 2 weeks,
>  I will read the thread tomorrow.
>
>  thanks.
>
>  Nick
>
>
>
>  On Thu, Mar 13, 2008 at 1:12 PM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>  >
>  >  On Mar 13 2008 09:43, Samuel Jean wrote:
>  >  >On Thu, Mar 13, 2008 at 9:31 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>  >  >>
>  >  >>  On Mar 13 2008 09:01, Samuel Jean wrote:
>  >  >>  >Would you mind to send a patch to Patrick about this ?
>  >  >>
>  >  >>  I am not sure whether this would go into mainline kernel.
>  >  >
>  >  >Uhm.. I don't think it will ever go into mainline, geoip is
>  >  >fully dependant on 3rd parties databases.
>  >
>  >  Is the db redistributable; what does the license say?
>  >
>  >  BTW, geoip.c is coded like checkentry() could be called twice
>  >  without a destroy in between -- how is this possible anyway?
>  >
>  >         /*
>  >          * If info->refcount is not NULL, then it means that checkentry()
>  >          * already initialized this entry. Increase a refcount to prevent
>  >          * destroy() of this entry.
>  >          */
>  >
>

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[Pablo Neira Ayuso]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

NICOLAS BOULIANE wrote:
> Pablo,
> 
> # geoip, maintained by Samuel Jean <jix@bugmachine.ca>
> http://people.netfilter.org/acidfu/patchlets/
> 
> Could you add me as the new official maintainer please ?
> Nicolas Bouliane <acidfu@people.netfilter.org>

Is this patch enough?

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 464 bytes --]

Index: sources.list
===================================================================
--- sources.list	(revisión: 7406)
+++ sources.list	(copia de trabajo)
@@ -1,7 +1,7 @@
 # Add the URLs for external patchlets here
 # 
 
-# geoip, maintained by Samuel Jean <jix@bugmachine.ca>
+# geoip, maintained by Nicolas Bouliane <acidfu@people.netfilter.org>
 http://people.netfilter.org/acidfu/patchlets/
 
 # condition, maintained by Massimiliano Hofer <max@nucleus.it>

Re: Updated geoip patchlet for iptables 1.4.0 / 2.6.24.3

[NICOLAS BOULIANE]

Pablo,

Its perfect, thank you.

Nick

On Mon, Mar 17, 2008 at 7:36 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> NICOLAS BOULIANE wrote:
>  > Pablo,
>  >
>  > # geoip, maintained by Samuel Jean <jix@bugmachine.ca>
>  > http://people.netfilter.org/acidfu/patchlets/
>  >
>  > Could you add me as the new official maintainer please ?
>  > Nicolas Bouliane <acidfu@people.netfilter.org>
>
>  Is this patch enough?
>
>
>
>  --
>  "Los honestos son inadaptados sociales" -- Les Luthiers
>
> Index: sources.list
>  ===================================================================
>  --- sources.list        (revisión: 7406)
>  +++ sources.list        (copia de trabajo)
>  @@ -1,7 +1,7 @@
>   # Add the URLs for external patchlets here
>   #
>
>  -# geoip, maintained by Samuel Jean <jix@bugmachine.ca>
>  +# geoip, maintained by Nicolas Bouliane <acidfu@people.netfilter.org>
>   http://people.netfilter.org/acidfu/patchlets/
>
>   # condition, maintained by Massimiliano Hofer <max@nucleus.it>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html