All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [kvm-devel] [PATCH 2 of 7] Add libfdt support
Date: Sun, 16 Mar 2008 05:37:13 +0000	[thread overview]
Message-ID: <47DCB209.10505@codemonkey.ws> (raw)
In-Reply-To: <d96091321011ee86681f.1205514549@thinkpad.austin.ibm.com>

Instead of having an explicit --enable-libfdt, it would be nicer to 
compile probe for it and then provide a --disable-libfdt option.  Then 
it Just Works without a special configure flag.

Regards,

Anthony Liguori

Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5@us.ibm.com>
> # Date 1205507804 18000
> # Branch merge
> # Node ID d96091321011ee86681f00bbaf72337ebc937791
> # Parent  b573d2790e7813337bf26c76a5c773a59592da5d
> Add libfdt support to qemu
>
> This patch adds needed configuration options to compile in libfdt support
> into qemu.
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/qemu/Makefile.target b/qemu/Makefile.target
> --- a/qemu/Makefile.target
> +++ b/qemu/Makefile.target
> @@ -555,6 +555,11 @@ ifdef CONFIG_VNC_TLS
>  ifdef CONFIG_VNC_TLS
>  CPPFLAGS += $(CONFIG_VNC_TLS_CFLAGS)
>  LIBS += $(CONFIG_VNC_TLS_LIBS)
> +endif
> +
> +ifdef CONFIG_LIBFDT
> +LIBS += -lfdt
> +DEPLIBS += libfdt.a
>  endif
>  
>  # SCSI layer
> diff --git a/qemu/configure b/qemu/configure
> --- a/qemu/configure
> +++ b/qemu/configure
> @@ -112,6 +112,7 @@ uname_release=""
>  uname_release=""
>  curses="yes"
>  cpu_emulation="yes"
> +device_tree_support="no"
>  
>  # OS specific
>  targetos=`uname -s`
> @@ -345,6 +346,8 @@ for opt do
>    ;;
>    --disable-cpu-emulation) cpu_emulation="no"
>    ;;
> +  --enable-libfdt) device_tree_support="yes"
> +  ;;
>    *) echo "ERROR: unknown option $opt"; exit 1
>    ;;
>    esac
> @@ -449,6 +452,7 @@ echo "  --enable-uname-release=R Return 
>  echo "  --enable-uname-release=R Return R for uname -r in usermode emulation"
>  echo "  --sparc_cpu=V            Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
>  echo "  --disable-cpu-emulation  disables use of qemu cpu emulation code"
> +echo "  --enable-libfdt 	 enable libfdt support for device tree support"
>  echo ""
>  echo "NOTE: The object files are built at the place where configure is launched"
>  exit 1
> @@ -1186,6 +1190,10 @@ elif test "$target_cpu" = "ppcemb" ; the
>    echo "#define TARGET_ARCH \"ppcemb\"" >> $config_h
>    echo "#define TARGET_PPC 1" >> $config_h
>    echo "#define TARGET_PPCEMB 1" >> $config_h
> +  if test "$device_tree_support" = "yes" ; then
> +      echo "#define CONFIG_LIBFDT 1" >> $config_h
> +      echo "CONFIG_LIBFDT=1" >> $config_mak
> +  fi
>    configure_kvm
>  elif test "$target_cpu" = "ppc64" ; then
>    echo "TARGET_ARCH=ppc64" >> $config_mak
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [PATCH 2 of 7] Add libfdt support to qemu
Date: Sun, 16 Mar 2008 00:37:13 -0500	[thread overview]
Message-ID: <47DCB209.10505@codemonkey.ws> (raw)
In-Reply-To: <d96091321011ee86681f.1205514549@thinkpad.austin.ibm.com>

Instead of having an explicit --enable-libfdt, it would be nicer to 
compile probe for it and then provide a --disable-libfdt option.  Then 
it Just Works without a special configure flag.

Regards,

Anthony Liguori

Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5@us.ibm.com>
> # Date 1205507804 18000
> # Branch merge
> # Node ID d96091321011ee86681f00bbaf72337ebc937791
> # Parent  b573d2790e7813337bf26c76a5c773a59592da5d
> Add libfdt support to qemu
>
> This patch adds needed configuration options to compile in libfdt support
> into qemu.
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/qemu/Makefile.target b/qemu/Makefile.target
> --- a/qemu/Makefile.target
> +++ b/qemu/Makefile.target
> @@ -555,6 +555,11 @@ ifdef CONFIG_VNC_TLS
>  ifdef CONFIG_VNC_TLS
>  CPPFLAGS += $(CONFIG_VNC_TLS_CFLAGS)
>  LIBS += $(CONFIG_VNC_TLS_LIBS)
> +endif
> +
> +ifdef CONFIG_LIBFDT
> +LIBS += -lfdt
> +DEPLIBS += libfdt.a
>  endif
>  
>  # SCSI layer
> diff --git a/qemu/configure b/qemu/configure
> --- a/qemu/configure
> +++ b/qemu/configure
> @@ -112,6 +112,7 @@ uname_release=""
>  uname_release=""
>  curses="yes"
>  cpu_emulation="yes"
> +device_tree_support="no"
>  
>  # OS specific
>  targetos=`uname -s`
> @@ -345,6 +346,8 @@ for opt do
>    ;;
>    --disable-cpu-emulation) cpu_emulation="no"
>    ;;
> +  --enable-libfdt) device_tree_support="yes"
> +  ;;
>    *) echo "ERROR: unknown option $opt"; exit 1
>    ;;
>    esac
> @@ -449,6 +452,7 @@ echo "  --enable-uname-release=R Return 
>  echo "  --enable-uname-release=R Return R for uname -r in usermode emulation"
>  echo "  --sparc_cpu=V            Build qemu for Sparc architecture v7, v8, v8plus, v8plusa, v9"
>  echo "  --disable-cpu-emulation  disables use of qemu cpu emulation code"
> +echo "  --enable-libfdt 	 enable libfdt support for device tree support"
>  echo ""
>  echo "NOTE: The object files are built at the place where configure is launched"
>  exit 1
> @@ -1186,6 +1190,10 @@ elif test "$target_cpu" = "ppcemb" ; the
>    echo "#define TARGET_ARCH \"ppcemb\"" >> $config_h
>    echo "#define TARGET_PPC 1" >> $config_h
>    echo "#define TARGET_PPCEMB 1" >> $config_h
> +  if test "$device_tree_support" = "yes" ; then
> +      echo "#define CONFIG_LIBFDT 1" >> $config_h
> +      echo "CONFIG_LIBFDT=1" >> $config_mak
> +  fi
>    configure_kvm
>  elif test "$target_cpu" = "ppc64" ; then
>    echo "TARGET_ARCH=ppc64" >> $config_mak
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-16  5:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 17:09 [kvm-ppc-devel] [PATCH 0 of 7] [v2] PowerPC kvm-userspace patches Jerone Young
2008-03-14 17:09 ` Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 1 of 7] Add libfdt to KVM userspace Jerone Young
2008-03-14 17:09   ` Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu Jerone Young
2008-03-14 17:09   ` Jerone Young
2008-03-16  5:37   ` Anthony Liguori [this message]
2008-03-16  5:37     ` Anthony Liguori
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uboot() & gunzip Jerone Young
2008-03-14 17:09   ` [PATCH 3 of 7] Create new load_uboot() & gunzip support to uboot loader in Qemu Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device Jerone Young
2008-03-14 17:09   ` [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu Jerone Young
2008-03-14 19:06   ` [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo Hollis Blanchard
2008-03-14 19:06     ` [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu Hollis Blanchard
2008-03-14 20:00     ` [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo Jerone Young
2008-03-14 20:00       ` [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation Jerone Young
2008-03-14 17:09   ` [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 6 of 7] Modify PPC bamboo & ppc440 board Jerone Young
2008-03-14 17:09   ` [PATCH 6 of 7] Modify PPC bamboo & ppc440 board models Jerone Young
2008-03-14 17:09 ` [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on Jerone Young
2008-03-14 17:09   ` [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Jerone Young
2008-03-14 19:16   ` [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram Hollis Blanchard
2008-03-14 19:16     ` [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Hollis Blanchard
2008-03-14 20:07     ` [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram Jerone Young
2008-03-14 20:07       ` [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Jerone Young
2008-03-16  5:34   ` [kvm-ppc-devel] [kvm-devel] [PATCH 7 of 7] Add ability to Anthony Liguori
2008-03-16  5:34     ` [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Anthony Liguori
2008-03-14 21:20 ` [kvm-ppc-devel] [PATCH 0 of 7] [v2] PowerPC Hollis Blanchard
2008-03-14 21:20   ` [kvm-ppc-devel] [PATCH 0 of 7] [v2] PowerPC kvm-userspace patches Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DCB209.10505@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jyoung5@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.