* [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings
@ 2018-12-25 2:44 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-25 2:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Mike Rapoport, Alastair D'Silva, Frederic Barrat,
Alexey Kardashevskiy, David Gibson, Andrew Donnellan,
Andrew Morton
Cc: linuxppc-dev, kernel-janitors, YueHaibing, linux-kernel
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/powernv/pci-ioda.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index 1d6406a..c4cf230 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -3147,8 +3147,8 @@ static int pnv_pci_diag_data_set(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(pnv_pci_diag_data_fops, NULL,
- pnv_pci_diag_data_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(pnv_pci_diag_data_fops, NULL, pnv_pci_diag_data_set,
+ "%llu\n");
#endif /* CONFIG_DEBUG_FS */
@@ -3173,8 +3173,8 @@ static void pnv_pci_ioda_create_dbgfs(void)
continue;
}
- debugfs_create_file("dump_diag_regs", 0200, phb->dbgfs, hose,
- &pnv_pci_diag_data_fops);
+ debugfs_create_file_unsafe("dump_diag_regs", 0200, phb->dbgfs,
+ hose, &pnv_pci_diag_data_fops);
}
#endif /* CONFIG_DEBUG_FS */
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings
@ 2018-12-25 2:44 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-25 2:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Mike Rapoport, Alastair D'Silva, Frederic Barrat,
Alexey Kardashevskiy, David Gibson, Andrew Donnellan,
Andrew Morton
Cc: YueHaibing, linuxppc-dev, linux-kernel, kernel-janitors
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/powernv/pci-ioda.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index 1d6406a..c4cf230 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -3147,8 +3147,8 @@ static int pnv_pci_diag_data_set(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(pnv_pci_diag_data_fops, NULL,
- pnv_pci_diag_data_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(pnv_pci_diag_data_fops, NULL, pnv_pci_diag_data_set,
+ "%llu\n");
#endif /* CONFIG_DEBUG_FS */
@@ -3173,8 +3173,8 @@ static void pnv_pci_ioda_create_dbgfs(void)
continue;
}
- debugfs_create_file("dump_diag_regs", 0200, phb->dbgfs, hose,
- &pnv_pci_diag_data_fops);
+ debugfs_create_file_unsafe("dump_diag_regs", 0200, phb->dbgfs,
+ hose, &pnv_pci_diag_data_fops);
}
#endif /* CONFIG_DEBUG_FS */
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings
2018-12-25 2:44 ` YueHaibing
(?)
@ 2019-11-14 9:08 ` Michael Ellerman
-1 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-11-14 9:08 UTC (permalink / raw)
To: YueHaibing, Benjamin Herrenschmidt, Paul Mackerras, Mike Rapoport,
Alastair D'Silva, Frederic Barrat, Alexey Kardashevskiy,
David Gibson, Andrew Donnellan, Andrew Morton
Cc: kernel-janitors, linuxppc-dev, linux-kernel
On Tue, 2018-12-25 at 02:44:36 UTC, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bfa2325e5b8b800cc6720cad8d2f066cd0136bee
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings
@ 2019-11-14 9:08 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-11-14 9:08 UTC (permalink / raw)
To: YueHaibing, Benjamin Herrenschmidt, Paul Mackerras, Mike Rapoport,
Alastair D'Silva, Frederic Barrat, Alexey Kardashevskiy,
David Gibson, Andrew Donnellan, Andrew Morton
Cc: linuxppc-dev, kernel-janitors, YueHaibing, linux-kernel
On Tue, 2018-12-25 at 02:44:36 UTC, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bfa2325e5b8b800cc6720cad8d2f066cd0136bee
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings
@ 2019-11-14 9:08 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-11-14 9:08 UTC (permalink / raw)
To: YueHaibing, Benjamin Herrenschmidt, Paul Mackerras, Mike Rapoport,
Alastair D'Silva, Frederic Barrat, Alexey Kardashevskiy,
David Gibson, Andrew Donnellan, Andrew Morton
Cc: kernel-janitors, YueHaibing, linuxppc-dev, linux-kernel
On Tue, 2018-12-25 at 02:44:36 UTC, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bfa2325e5b8b800cc6720cad8d2f066cd0136bee
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-14 10:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-25 2:44 [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings YueHaibing
2018-12-25 2:44 ` YueHaibing
2019-11-14 9:08 ` Michael Ellerman
2019-11-14 9:08 ` Michael Ellerman
2019-11-14 9:08 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.