Re: [RFC] move to opkg / md5 error on big-endian machine

["Jeremy Lainé" <jeremy.laine@bolloretelecom.eu>]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

opkg systematically fails to check the MD5 checksums on big-endian
targets. The reason for this is that md5.c was taken from glibc, and
it only sets the endianness correctly if _LIBC is defined:

#ifdef _LIBC
# include <endian.h>
# if __BYTE_ORDER == __BIG_ENDIAN
#  define WORDS_BIGENDIAN 1
# endif
[snip]
#endif

Attached is a patch thats sets WORDS_BIGENDIAN on big-endian machines
without touching the code, and fixes the MD5 errors I was getting.

Rather than putting this patch into OE, maybe we should push this
upstream?

Cheers,

- --
Jeremy LAINE
Bolloré telecom | 11bis, rue Scribe | F-75009 Paris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH4VLbCL1n3lVB9EYRArVFAJ9M22nqlh2jqV+OKg7HqNsgIC/hBgCfa2R8
VdUuk6OIo5W72sXs/8tQ8G8=
=DyiG
-----END PGP SIGNATURE-----


[-- Attachment #2: check_endianness.patch --]
[-- Type: text/x-diff, Size: 1048 bytes --]

diff -urN opkg.orig/configure.ac opkg/configure.ac
--- opkg.orig/configure.ac	2008-03-19 10:43:40.000000000 +0100
+++ opkg/configure.ac	2008-03-19 18:37:08.000000000 +0100
@@ -93,6 +93,10 @@
 AC_TYPE_SIZE_T
 AC_CHECK_MEMBERS([struct stat.st_rdev])
 
+# Checks endianness
+AC_C_BIGENDIAN(ENDIAN_CFLAGS="-DWORDS_BIGENDIAN=1",)
+AC_SUBST(BIGENDIAN_CFLAGS)
+
 # Don't do annoying tests that don't work when cross-compiling, just trust them.
 # The AC_FUNC_MEMCMP test doesn't work during a cross-compile, disable.
 # AC_FUNC_MEMCMP
diff -urN opkg.orig/libopkg/Makefile.am opkg/libopkg/Makefile.am
--- opkg.orig/libopkg/Makefile.am	2008-03-19 10:43:40.000000000 +0100
+++ opkg/libopkg/Makefile.am	2008-03-19 18:36:19.000000000 +0100
@@ -59,7 +59,7 @@
 	$(opkg_cmd_sources) $(opkg_db_sources) \
 	$(opkg_util_sources) $(opkg_list_sources)
 
-libopkg_la_CFLAGS = $(ALL_CFLAGS)  $(CURL_CFLAGS) $(GPGME_CFLAGS)
+libopkg_la_CFLAGS = $(ALL_CFLAGS) $(BIGENDIAN_CFLAGS) $(CURL_CFLAGS) $(GPGME_CFLAGS)
 lib_LTLIBRARIES = libopkg.la
 
 

[-- Attachment #3: check_endianness.patch.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]