[uml-devel] small patch for small install problem of uml_utilities

[uml-devel] small patch for small install problem of uml_utilities

[Christian Krause]

Hi,

During packaging of uml_utilities I've found a small problem during 
"make install":

in tools-20070815/humsify/Makefile the binary is installed via
"install -o 0755 $(BIN) $(DESTDIR)$(BIN_DIR)".
It looks like that "-o" is just a typo and that the intention was to set 
the mode with "-m 0755" and not the owner (with -o 0755, which makes no 
sense ;-) ).

Here is my patch I've used to fix the problem. Probably you can apply it 
to the official sources as well:

diff -uNr tools-20070815.orig/humfsify/Makefile 
tools-20070815/humfsify/Makefile
--- tools-20070815.orig/humfsify/Makefile       2006-05-25 
20:37:01.000000000 +0200
+++ tools-20070815/humfsify/Makefile    2008-03-19 20:29:50.000000000 +0100
@@ -4,7 +4,7 @@

 install:
        install -d $(DESTDIR)$(BIN_DIR)
-       install -o 0755 $(BIN) $(DESTDIR)$(BIN_DIR)
+       install -m 0755 $(BIN) $(DESTDIR)$(BIN_DIR)

 clean:
        rm -f *~


Thanks & Best regards,
Christian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] small patch for small install problem of uml_utilities

[Jeff Dike]

On Wed, Mar 19, 2008 at 08:41:59PM +0100, Christian Krause wrote:
> During packaging of uml_utilities I've found a small problem during 
> "make install":

> -       install -o 0755 $(BIN) $(DESTDIR)$(BIN_DIR)
> +       install -m 0755 $(BIN) $(DESTDIR)$(BIN_DIR)

Looks right, thanks.

		Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel