Fix permissions of /proc/net

Fix permissions of /proc/net

[Andre Noll]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
Author: Andre Noll <maan@congo.fml.local>
Date:   Wed Mar 19 11:39:55 2008 +0100

From: Andre Noll <maan@systemlinux.org>

commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
broke ganglia and probably other applications that read /proc/net/dev.

This is due to the change of permissions of /proc/net that was
introduced in that commit.

Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net

This patch restores the permissions to the old value which makes ganglia
happy again.

Signed-off-by: Andre Noll <maan@systemlinux.org>

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 8a10f6f..81d7d14 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
 	DIR("fd",         S_IRUSR|S_IXUSR, fd),
 	DIR("fdinfo",     S_IRUSR|S_IXUSR, fdinfo),
 #ifdef CONFIG_NET
-	DIR("net",        S_IRUGO|S_IXUSR, net),
+	DIR("net",        S_IRUGO|S_IXUGO, net),
 #endif
 	REG("environ",    S_IRUSR, environ),
 	INF("auxv",       S_IRUSR, pid_auxv),
-- 
The only person who always got his work done by Friday was Robinson Crusoe

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Fix permissions of /proc/net

[Pavel Emelyanov]

Andre Noll wrote:
> commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
> Author: Andre Noll <maan@congo.fml.local>
> Date:   Wed Mar 19 11:39:55 2008 +0100
> 
> From: Andre Noll <maan@systemlinux.org>
> 
> commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
> broke ganglia and probably other applications that read /proc/net/dev.

This also broke the postfix, as it was reported in bug #10286
and described in detail by Benjamin.

> This is due to the change of permissions of /proc/net that was
> introduced in that commit.
> 
> Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
> After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net
> 
> This patch restores the permissions to the old value which makes ganglia
> happy again.

And it fixes the problem reported by Benjamin.
Thanks, Andre!

> Signed-off-by: Andre Noll <maan@systemlinux.org>

Acked-by: Pavel Emelyanov <xemul@openvz.org>
 
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 8a10f6f..81d7d14 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
>  	DIR("fd",         S_IRUSR|S_IXUSR, fd),
>  	DIR("fdinfo",     S_IRUSR|S_IXUSR, fdinfo),
>  #ifdef CONFIG_NET
> -	DIR("net",        S_IRUGO|S_IXUSR, net),
> +	DIR("net",        S_IRUGO|S_IXUGO, net),
>  #endif
>  	REG("environ",    S_IRUSR, environ),
>  	INF("auxv",       S_IRUSR, pid_auxv),

Re: Fix permissions of /proc/net

[David Miller]

From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 20 Mar 2008 10:56:31 +0300

> Andre Noll wrote:
> > Signed-off-by: Andre Noll <maan@systemlinux.org>
> 
> Acked-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks everyone.