All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Pavel Machek <pavel@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	pm list <linux-pm@lists.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	David Brownell <david-b@pacbell.net>, Greg KH <greg@kroah.com>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Shaohua Li <shaohua.li@intel.com>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6)
Date: Thu, 20 Mar 2008 18:50:44 +0300	[thread overview]
Message-ID: <47E287D4.3060906@gmail.com> (raw)
In-Reply-To: <20080320151931.GD5615@khazad-dum.debian.net>

Henrique de Moraes Holschuh wrote:
> On Wed, 19 Mar 2008, Pavel Machek wrote:
>   
>>     Also, for polling mode to work on Acers, we need
>>     to insert a delay.
>>     
>
> Can we, in the future, always trigger any such performance damaging "fixups"
> based on DMI white/black lists?  As a rule?
>   
Poll mode is not supposed to be entered on any non-broken HW.
The fact that it happens now with Thinkpads at suspend is a bug.
EC region should not be accessed with interrupts of GPEs disabled.
> This is not the first time I see a vendor push broken crap, and everyone
> else who did it right get the shaft, because people don't like to add
> quirks to common code.  We get performance enhancement features disabled,
> mdelays added...
>
> And for the do-as-windows-does crowd, they do it on vendor­issued device
> drivers, which obviously don't hork everyone else's devices.  Our equivalent
> solution is to key things to DMI matches.   This is worth keeping in mind,
> because the ACPI subsystem seems to be a common target for such bad
> behaviour.
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Pavel Machek <pavel@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	pm list <linux-pm@lists.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	David Brownell <david-b@pacbell.net>, Greg KH <greg@kroah.com>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Shaohua Li <shaohua.li@intel.com>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6)
Date: Thu, 20 Mar 2008 18:50:44 +0300	[thread overview]
Message-ID: <47E287D4.3060906@gmail.com> (raw)
In-Reply-To: <20080320151931.GD5615@khazad-dum.debian.net>

Henrique de Moraes Holschuh wrote:
> On Wed, 19 Mar 2008, Pavel Machek wrote:
>   
>>     Also, for polling mode to work on Acers, we need
>>     to insert a delay.
>>     
>
> Can we, in the future, always trigger any such performance damaging "fixups"
> based on DMI white/black lists?  As a rule?
>   
Poll mode is not supposed to be entered on any non-broken HW.
The fact that it happens now with Thinkpads at suspend is a bug.
EC region should not be accessed with interrupts of GPEs disabled.
> This is not the first time I see a vendor push broken crap, and everyone
> else who did it right get the shaft, because people don't like to add
> quirks to common code.  We get performance enhancement features disabled,
> mdelays added...
>
> And for the do-as-windows-does crowd, they do it on vendor­issued device
> drivers, which obviously don't hork everyone else's devices.  Our equivalent
> solution is to key things to DMI matches.   This is worth keeping in mind,
> because the ACPI subsystem seems to be a common target for such bad
> behaviour.
>
>   


  parent reply	other threads:[~2008-03-20 15:50 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12  0:29 Suspend and hibernation patchset Rafael J. Wysocki
2008-03-17 22:17 ` Suspend and hibernation patchset against -rc6 Rafael J. Wysocki
2008-03-17 22:17 ` Rafael J. Wysocki
2008-03-18 12:07   ` Pavel Machek
2008-03-18 12:07   ` Pavel Machek
2008-03-18 13:06   ` suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6) Pavel Machek
2008-03-18 13:07     ` Pavel Machek
2008-03-18 13:07     ` Pavel Machek
2008-03-18 17:07       ` Pavel Machek
2008-03-18 17:07         ` Pavel Machek
2008-03-18 18:48         ` Alexey Starikovskiy
2008-03-18 18:48           ` Alexey Starikovskiy
2008-03-18 23:00           ` Pavel Machek
2008-03-18 23:00             ` Pavel Machek
2008-03-18 17:31       ` Linus Torvalds
2008-03-18 17:31         ` Linus Torvalds
2008-03-18 22:52         ` Pavel Machek
2008-03-18 22:52           ` Pavel Machek
2008-03-18 23:05           ` Pavel Machek
2008-03-18 23:05             ` Pavel Machek
2008-03-19  0:40           ` Linus Torvalds
2008-03-19  0:40             ` Linus Torvalds
2008-03-19 10:19             ` Pavel Machek
2008-03-19 10:19               ` Pavel Machek
2008-03-19 14:42               ` Linus Torvalds
2008-03-19 14:42                 ` Linus Torvalds
2008-03-19 20:24                 ` Pavel Machek
2008-03-19 20:24                 ` Pavel Machek
2008-03-19 10:56             ` Pavel Machek
2008-03-19 10:56               ` Pavel Machek
2008-03-19 11:48             ` Pavel Machek
2008-03-19 11:48               ` Pavel Machek
2008-03-19 14:47               ` Linus Torvalds
2008-03-19 14:47                 ` Linus Torvalds
2008-03-19 14:54                 ` Pavel Machek
2008-03-19 14:54                   ` Pavel Machek
2008-03-19 20:23                 ` Pavel Machek
2008-03-19 20:23                   ` Pavel Machek
2008-03-19 20:35                   ` Alexey Starikovskiy
2008-03-19 20:35                     ` Alexey Starikovskiy
2008-03-19 20:47                     ` Rafael J. Wysocki
2008-03-19 20:47                     ` Rafael J. Wysocki
2008-03-19 20:58                     ` Pavel Machek
2008-03-19 20:58                       ` Pavel Machek
2008-03-19 21:07                       ` Alexey Starikovskiy
2008-03-19 21:07                         ` Alexey Starikovskiy
2008-03-19 21:43                       ` Rafael J. Wysocki
2008-03-19 21:56                         ` Rafael J. Wysocki
2008-03-19 21:56                         ` [linux-pm] " Rafael J. Wysocki
2008-03-19 21:57                         ` Pavel Machek
2008-03-19 21:58                           ` Rafael J. Wysocki
2008-03-19 22:02                             ` Pavel Machek
2008-03-19 22:13                               ` Rafael J. Wysocki
2008-03-19 22:13                               ` Rafael J. Wysocki
2008-03-19 22:21                                 ` Pavel Machek
2008-03-19 22:21                                 ` Pavel Machek
2008-03-19 22:02                             ` Pavel Machek
2008-03-19 21:58                           ` Rafael J. Wysocki
2008-03-19 21:57                         ` Pavel Machek
2008-03-19 21:43                       ` Rafael J. Wysocki
2008-03-20 15:06           ` Henrique de Moraes Holschuh
2008-03-20 15:06           ` Henrique de Moraes Holschuh
2008-03-20 15:53             ` Pavel Machek
2008-03-20 15:53             ` Pavel Machek
2008-03-18 23:20         ` Pavel Machek
2008-03-18 23:20           ` Pavel Machek
2008-03-18 23:45           ` Alexey Starikovskiy
2008-03-18 23:45             ` Alexey Starikovskiy
2008-03-19 11:49             ` Pavel Machek
2008-03-19 11:49               ` Pavel Machek
2008-03-20 15:19           ` Henrique de Moraes Holschuh
2008-03-20 15:19           ` Henrique de Moraes Holschuh
2008-03-20 15:19             ` Henrique de Moraes Holschuh
2008-03-20 15:50             ` Alexey Starikovskiy
2008-03-20 15:50             ` Alexey Starikovskiy [this message]
2008-03-20 15:50               ` Alexey Starikovskiy
2008-03-20 22:26               ` Henrique de Moraes Holschuh
2008-03-20 22:26               ` Henrique de Moraes Holschuh
2008-03-18 23:43         ` Pavel Machek
2008-03-18 23:43           ` Pavel Machek
2008-03-18 13:06   ` Pavel Machek
2008-03-26 23:51   ` Suspend and hibernation patchset against -rc7 Rafael J. Wysocki
2008-04-02  0:27     ` Suspend and hibernation patchset against -rc8 Rafael J. Wysocki
2008-04-13 17:39       ` Suspend and hibernation patchset against -rc9 Rafael J. Wysocki
2008-04-13 17:39       ` Rafael J. Wysocki
2008-04-02  0:27     ` Suspend and hibernation patchset against -rc8 Rafael J. Wysocki
2008-03-26 23:51   ` Suspend and hibernation patchset against -rc7 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E287D4.3060906@gmail.com \
    --to=aystarik@gmail.com \
    --cc=astarikovskiy@suse.de \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=hmh@hmh.eng.br \
    --cc=johannes@sipsolutions.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    --cc=shaohua.li@intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.