* [NETFILTER 01/02]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()
@ 2008-03-20 17:54 Patrick McHardy
2008-03-20 22:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2008-03-20 17:54 UTC (permalink / raw)
To: David S. Miller; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 01.diff --]
[-- Type: text/x-diff, Size: 1038 bytes --]
commit 3e760ed979f6dbf063ced2117328ffee56620bbd
Author: Roel Kluin <12o3l@tiscali.nl>
Date: Thu Mar 20 18:34:39 2008 +0100
[NETFILTER]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 6213787..898f192 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -842,7 +842,7 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
set_h225_addr = rcu_dereference(set_h225_addr_hook);
if ((setup->options & eSetup_UUIE_destCallSignalAddress) &&
- (set_h225_addr) && ct->status && IPS_NAT_MASK &&
+ (set_h225_addr) && ct->status & IPS_NAT_MASK &&
get_h225_addr(ct, *data, &setup->destCallSignalAddress,
&addr, &port) &&
memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NETFILTER 01/02]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()
2008-03-20 17:54 [NETFILTER 01/02]: nf_conntrack_h323: logical-bitwise & confusion in process_setup() Patrick McHardy
@ 2008-03-20 22:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-03-20 22:06 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 20 Mar 2008 18:54:54 +0100
> [NETFILTER]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()
>
> logical-bitwise & confusion
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-20 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-20 17:54 [NETFILTER 01/02]: nf_conntrack_h323: logical-bitwise & confusion in process_setup() Patrick McHardy
2008-03-20 22:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.