All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm-devel@lists.sourceforge.net,
	Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] kvm.h: __user requires compiler.h
Date: Sun, 23 Mar 2008 10:42:27 +0200	[thread overview]
Message-ID: <47E617F3.7080509@qumranet.com> (raw)
In-Reply-To: <47E41AC9.1030003@codemonkey.ws>

Anthony Liguori wrote:
> This patch breaks QEMU build when doing a 'make sync'.  When you do a 
> top-level ./configure, libkvm is built with kerneldir pointing to 
> kvm-userspace/kernel/include.  While linux/kvm.h is present there, 
> there isn't a linux/compiler.h.
>
> The host kernelpath isn't normally part of the libkvm or QEMU build.  
> So we have a couple options.
>
> 1) make the host kernelpath (/lib/modules/$(uname -r)/build/include) 
> part of the libkvm/QEMU build.
>
> 2) Do something else about __user
>
> Suggestions?  #1 might be a pain since there may be include conflicts 
> between the host kernel include and kernel/include.
>

We could hack 'make sync' to strip out __user (just like we run 
unifdef).  Of course the reasons for including linux/compiler.h are 
still valid, so it needs to remain.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-23  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12 17:10 [PATCH] kvm.h: __user requires compiler.h Christian Borntraeger
2008-03-18  6:50 ` Avi Kivity
2008-03-21 20:30 ` Anthony Liguori
2008-03-23  8:42   ` Avi Kivity [this message]
2008-03-24 19:46   ` Christian Borntraeger
2008-03-24 20:04     ` Avi Kivity
2008-03-25 15:42       ` Christian Borntraeger
2008-03-25 16:23         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E617F3.7080509@qumranet.com \
    --to=avi@qumranet.com \
    --cc=anthony@codemonkey.ws \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.