All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [PATCH] kvm.h: __user requires compiler.h
Date: Tue, 25 Mar 2008 18:23:19 +0200	[thread overview]
Message-ID: <47E926F7.6050503@qumranet.com> (raw)
In-Reply-To: <200803251642.42092.borntraeger@de.ibm.com>

Christian Borntraeger wrote:
> Am Montag, 24. März 2008 schrieb Avi Kivity:
>   
>> Christian Borntraeger wrote:
>>     
>>> Am Freitag, 21. März 2008 schrieb Anthony Liguori:
>>>   
>>>       
>>>> This patch breaks QEMU build when doing a 'make sync'.  When you do a 
>>>> top-level ./configure, libkvm is built with kerneldir pointing to 
>>>> kvm-userspace/kernel/include.  While linux/kvm.h is present there,
>>>>         
> [...] 
>   
>> Maybe we should generate the 'make sync' headers using 'make 
>> headers_install'.
>>     
>
> headers_install works because there is 
>
> # Eliminate the contents of (and inclusions of) compiler.h
> HDRSED  := sed  -e "s/ inline / __inline__ /g" \
>                 -e "s/[[:space:]]__user[[:space:]]\{1,\}/ /g" \
>                 -e "s/(__user[[:space:]]\{1,\}/ (/g" \
>                 -e "s/[[:space:]]__force[[:space:]]\{1,\}/ /g" \
>                 -e "s/(__force[[:space:]]\{1,\}/ (/g" \
>                 -e "s/[[:space:]]__iomem[[:space:]]\{1,\}/ /g" \
>                 -e "s/(__iomem[[:space:]]\{1,\}/ (/g" \
>                 -e "s/[[:space:]]__attribute_const__[[:space:]]\{1,\}/\ /g" 
> \
>                 -e "s/[[:space:]]__attribute_const__$$//" \
>                 -e "/^\#include <linux\/compiler.h>/d"
>
> in scripts/Makefile.headersinst
>
> If you dont want to do something like for make sync, what about providing a 
> dummy compiler.h, which has
> only this line?
> #define __user 
>   

I already added something similar, see 
bcb30c8bafc7cac75c38981a57bc1f94521e83f4.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

      reply	other threads:[~2008-03-25 16:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12 17:10 [PATCH] kvm.h: __user requires compiler.h Christian Borntraeger
2008-03-18  6:50 ` Avi Kivity
2008-03-21 20:30 ` Anthony Liguori
2008-03-23  8:42   ` Avi Kivity
2008-03-24 19:46   ` Christian Borntraeger
2008-03-24 20:04     ` Avi Kivity
2008-03-25 15:42       ` Christian Borntraeger
2008-03-25 16:23         ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E926F7.6050503@qumranet.com \
    --to=avi@qumranet.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.