All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [Qemu-devel] Coredump from qemu
Date: Sun, 23 Mar 2008 15:19:13 +0200	[thread overview]
Message-ID: <47E658D1.3000606@qumranet.com> (raw)
In-Reply-To: <c4e36d110803210646m5f82583fsce0ee88be9d3c029@mail.gmail.com>

Zdenek Kabelac wrote:
> Hi
>
> During execution of qemu I've got this crash:
>
> #0  0x0000000000407a29 in qemu_mod_timer (ts=0x2e8cf90,
> expire_time=130685351465) at /usr/src/debug/kvm-63/qemu/vl.c:1073
> #1  0x0000000000425590 in pcnet_ioport_writew (opaque=0x0,
> addr=1836332585, val=8090216)
>     at /usr/src/debug/kvm-63/qemu/hw/pcnet.c:1617
> #2  0x0000000000501cf1 in kvm_outw (opaque=<value optimized out>,
> addr=13865, data=29288)
>     at /usr/src/debug/kvm-63/qemu/qemu-kvm.c:457
> #3  0x000000000051e2a0 in kvm_run (kvm=0x2dbb030, vcpu=1) at libkvm.c:719
> #4  0x0000000000501646 in kvm_cpu_exec (env=<value optimized out>) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:127
> #5  0x00000000005021a5 in kvm_main_loop_cpu (env=0x2e8f010) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:307
> #6  0x0000000000502302 in ap_main_loop (_env=<value optimized out>) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:338
> #7  0x000000353420740a in start_thread () from /lib64/libpthread.so.0
> #8  0x00000035336e5d1d in clone () from /lib64/libc.so.6
>
> (gdb) print alarm_timer
> $1 = (struct qemu_alarm_timer *) 0x0
>
>
> It happend during detach of gdb and quit of the qemu itsell - I assume
> no all timers were probably stoped when quit_timers was executed ?
>
>   

Looks like.

> Maybe check for non NULL pointer is enough qemu_mod_timer?
>
>   

I think the correct solution is to allow devices to register a shutdown 
function, which would be called after main_loop() (but before 
quit_timers) , which would execute qemu_del_timer() in the case of 
pcnet.  It's also necessary for device hotremove.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [Qemu-devel] Coredump from qemu
Date: Sun, 23 Mar 2008 15:19:13 +0200	[thread overview]
Message-ID: <47E658D1.3000606@qumranet.com> (raw)
In-Reply-To: <c4e36d110803210646m5f82583fsce0ee88be9d3c029@mail.gmail.com>

Zdenek Kabelac wrote:
> Hi
>
> During execution of qemu I've got this crash:
>
> #0  0x0000000000407a29 in qemu_mod_timer (ts=0x2e8cf90,
> expire_time=130685351465) at /usr/src/debug/kvm-63/qemu/vl.c:1073
> #1  0x0000000000425590 in pcnet_ioport_writew (opaque=0x0,
> addr=1836332585, val=8090216)
>     at /usr/src/debug/kvm-63/qemu/hw/pcnet.c:1617
> #2  0x0000000000501cf1 in kvm_outw (opaque=<value optimized out>,
> addr=13865, data=29288)
>     at /usr/src/debug/kvm-63/qemu/qemu-kvm.c:457
> #3  0x000000000051e2a0 in kvm_run (kvm=0x2dbb030, vcpu=1) at libkvm.c:719
> #4  0x0000000000501646 in kvm_cpu_exec (env=<value optimized out>) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:127
> #5  0x00000000005021a5 in kvm_main_loop_cpu (env=0x2e8f010) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:307
> #6  0x0000000000502302 in ap_main_loop (_env=<value optimized out>) at
> /usr/src/debug/kvm-63/qemu/qemu-kvm.c:338
> #7  0x000000353420740a in start_thread () from /lib64/libpthread.so.0
> #8  0x00000035336e5d1d in clone () from /lib64/libc.so.6
>
> (gdb) print alarm_timer
> $1 = (struct qemu_alarm_timer *) 0x0
>
>
> It happend during detach of gdb and quit of the qemu itsell - I assume
> no all timers were probably stoped when quit_timers was executed ?
>
>   

Looks like.

> Maybe check for non NULL pointer is enough qemu_mod_timer?
>
>   

I think the correct solution is to allow devices to register a shutdown 
function, which would be called after main_loop() (but before 
quit_timers) , which would execute qemu_del_timer() in the case of 
pcnet.  It's also necessary for device hotremove.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2008-03-23 13:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 13:46 Coredump from qemu Zdenek Kabelac
2008-03-21 13:46 ` [Qemu-devel] " Zdenek Kabelac
2008-03-23 13:19 ` Avi Kivity [this message]
2008-03-23 13:19   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E658D1.3000606@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.