From: Avi Kivity <avi@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support
Date: Mon, 24 Mar 2008 09:47:28 +0200 [thread overview]
Message-ID: <47E75C90.1020706@qumranet.com> (raw)
In-Reply-To: <47E7550D.3070706@qumranet.com>
Avi Kivity wrote:
> Paul Brook wrote:
>>
>>>> a new timer will be fired to try inject it again soon (==0.1msec)
>>>>
>>
>> If the guest is missing interrupts, the chances of a 0.1ms interval
>> working are not great. Most likely It's either going trigger
>> immediately, or be delayed significantly and you're going to end up
>> even further behind.
>
> If 0.1 ms is within qemu's timeslice, then qemu should get the wakeup
> on time (assuming a host with high resolution timers).
>
>> If triggering immediately is OK then why not do that all the time?
>>
>
> Triggering immediately doesn't help, the guest likely has interrupts
> blocked processing the same interrupt.
>
>> If triggering immediately is not acceptable then you're still going
>> to loose interrupts.
>>
>
> You're still accounting for them, so if the load decreases eventually
> it's going to catch up.
>
>
btw, the better solution here is to wait until the guest is ready for
timer interrupt injection again, but that's not as easy as arming a timer.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org
Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support
Date: Mon, 24 Mar 2008 09:47:28 +0200 [thread overview]
Message-ID: <47E75C90.1020706@qumranet.com> (raw)
In-Reply-To: <47E7550D.3070706@qumranet.com>
Avi Kivity wrote:
> Paul Brook wrote:
>>
>>>> a new timer will be fired to try inject it again soon (==0.1msec)
>>>>
>>
>> If the guest is missing interrupts, the chances of a 0.1ms interval
>> working are not great. Most likely It's either going trigger
>> immediately, or be delayed significantly and you're going to end up
>> even further behind.
>
> If 0.1 ms is within qemu's timeslice, then qemu should get the wakeup
> on time (assuming a host with high resolution timers).
>
>> If triggering immediately is OK then why not do that all the time?
>>
>
> Triggering immediately doesn't help, the guest likely has interrupts
> blocked processing the same interrupt.
>
>> If triggering immediately is not acceptable then you're still going
>> to loose interrupts.
>>
>
> You're still accounting for them, so if the load decreases eventually
> it's going to catch up.
>
>
btw, the better solution here is to wait until the guest is ready for
timer interrupt injection again, but that's not as easy as arming a timer.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-03-24 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 14:27 [PATCH] [RFC] Fix time drift of rtc clock + general support Dor Laor
2008-03-23 14:27 ` [Qemu-devel] " Dor Laor
2008-03-23 16:19 ` Paul Brook
2008-03-23 16:19 ` Paul Brook
2008-03-23 22:40 ` Dor Laor
2008-03-23 22:40 ` Dor Laor
2008-03-23 23:29 ` Paul Brook
2008-03-23 23:29 ` Paul Brook
2008-03-24 7:15 ` Avi Kivity
2008-03-24 7:15 ` [kvm-devel] " Avi Kivity
2008-03-24 7:47 ` Avi Kivity [this message]
2008-03-24 7:47 ` Avi Kivity
2008-03-24 7:11 ` Avi Kivity
2008-03-24 7:11 ` [kvm-devel] " Avi Kivity
2008-03-24 13:45 ` Paul Brook
2008-03-24 13:45 ` [kvm-devel] " Paul Brook
2008-03-24 13:56 ` Avi Kivity
2008-03-24 13:56 ` [kvm-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E75C90.1020706@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.