From: yshi <yang.shi@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver
Date: Wed, 26 Mar 2008 10:52:28 +0800 [thread overview]
Message-ID: <47E9BA6C.2010502@windriver.com> (raw)
In-Reply-To: <20080325.194221.16658596.davem@davemloft.net>
David Miller 写道:
> From: Jeff Garzik <jgarzik@pobox.com>
> Date: Tue, 25 Mar 2008 22:23:24 -0400
>
>
>> This is bogus -- you should never need to slow down the hot path in such
>> a way.
>>
>
> Slow down in what way? Even on x86 saving the flags is just
> about as expensive as a plain sti/cli.
>
> I would in fact prefer to see drivers unconditionally use
> spin_lock_irqsave() et al. in the interrupt handler, for
> consistency.
>
Yes, I agree. Many NIC drivers do the same thing, like Gianfar, E1000, etc.
next prev parent reply other threads:[~2008-03-26 2:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:12 [PATCH] Improvev netconsole support for RTL8139 NIC driver yshi
2008-03-26 2:23 ` Jeff Garzik
2008-03-26 2:38 ` yshi
2008-03-26 2:42 ` David Miller
2008-03-26 2:52 ` yshi [this message]
2008-03-26 3:14 ` Jeff Garzik
2008-03-26 3:14 ` Jeff Garzik
2008-03-26 3:30 ` David Miller
2008-03-26 3:39 ` Jeff Garzik
2008-03-26 3:48 ` Jeff Garzik
2008-03-26 3:53 ` David Miller
2008-03-26 4:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E9BA6C.2010502@windriver.com \
--to=yang.shi@windriver.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.