All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: yang.shi@windriver.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver
Date: Tue, 25 Mar 2008 23:48:20 -0400	[thread overview]
Message-ID: <47E9C784.6050807@garzik.org> (raw)
In-Reply-To: <47E9C56F.2070508@pobox.com>

Jeff Garzik wrote:
> I am being realistic...  it's
> 
> * not needed
> * increases code size
> * increases number of CPU instructions executed
> * not needed

I also wonder if using spin_lock_irqsave() makes moving to a real-time 
kernel with interrupt threads more difficult for that driver.

And of course we're talking about a hot path here.

	Jeff



  reply	other threads:[~2008-03-26  3:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  2:12 [PATCH] Improvev netconsole support for RTL8139 NIC driver yshi
2008-03-26  2:23 ` Jeff Garzik
2008-03-26  2:38   ` yshi
2008-03-26  2:42   ` David Miller
2008-03-26  2:52     ` yshi
2008-03-26  3:14       ` Jeff Garzik
2008-03-26  3:14     ` Jeff Garzik
2008-03-26  3:30       ` David Miller
2008-03-26  3:39         ` Jeff Garzik
2008-03-26  3:48           ` Jeff Garzik [this message]
2008-03-26  3:53             ` David Miller
2008-03-26  4:32               ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E9C784.6050807@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yang.shi@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.