Re: [PATCH 0/2] Two more pasemi_mac patches for 2.6.26

[Jeff Garzik <jgarzik@pobox.com>]

Olof Johansson wrote:
> On Wed, Mar 26, 2008 at 12:12:30AM -0400, Jeff Garzik wrote:
>> Olof Johansson wrote:
>>> Hi Jeff,
>>>
>>> The below two patches go on top of the previous patches that were acked
>>> by you but applied to pasemi.git for feed up through powerpc.git.
>>>
>>> One is a couple of fixes for various corner cases in the jumbo support
>>> configuration. The second is addition of netpoll support, from Nate
>>> Case.
>>>
>>> Review/ack would be appreciated, I'll feed them up the same path as the
>>> other changes.
>> ACK 1-2, though I would consider closely patch #2, whether you need 
>> disable_irq() or spin_lock_irqsave() -- which is best for your specific 
>> driver + platform?
> 
> I'm tempted to leave the disable/enable_irq() in there. It's certainly
> heavier than doing cpu-side irq masking, but adding a spinlock to the
> common interrupt path seems worse to me. I didn't think we considered
> the polling to be a hot path anyway...

Definitely not a hot path :)