From: Olof Johansson <olof@lixom.net>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, pasemi-linux@ozlabs.org,
jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] pasemi_mac: Netpoll support
Date: Wed, 26 Mar 2008 10:08:28 -0500 [thread overview]
Message-ID: <20080326150828.GA6728@lixom.net> (raw)
In-Reply-To: <47EA445D.9090509@ru.mvista.com>
On Wed, Mar 26, 2008 at 03:41:01PM +0300, Valentine Barshak wrote:
>> + pasemi_mac_tx_intr(mac->tx->chan.irq, mac->tx);
>> + enable_irq(mac->tx->chan.irq);
>> +
>> + disable_irq(mac->rx->chan.irq);
>> + pasemi_mac_rx_intr(mac->rx->chan.irq, dev);
>
> Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)?
Yeah, it should. It used to take the netdev pointer instead. And the
void * argument means I never got a compiler warning from it.
Thanks!
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: jgarzik@pobox.com, linuxppc-dev@ozlabs.org,
pasemi-linux@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] pasemi_mac: Netpoll support
Date: Wed, 26 Mar 2008 10:08:28 -0500 [thread overview]
Message-ID: <20080326150828.GA6728@lixom.net> (raw)
In-Reply-To: <47EA445D.9090509@ru.mvista.com>
On Wed, Mar 26, 2008 at 03:41:01PM +0300, Valentine Barshak wrote:
>> + pasemi_mac_tx_intr(mac->tx->chan.irq, mac->tx);
>> + enable_irq(mac->tx->chan.irq);
>> +
>> + disable_irq(mac->rx->chan.irq);
>> + pasemi_mac_rx_intr(mac->rx->chan.irq, dev);
>
> Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)?
Yeah, it should. It used to take the netdev pointer instead. And the
void * argument means I never got a compiler warning from it.
Thanks!
-Olof
next prev parent reply other threads:[~2008-03-26 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 1:56 [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Olof Johansson
2008-03-26 1:57 ` [PATCH 1/2] pasemi_mac: Jumbo frame bugfixes Olof Johansson
2008-03-26 1:58 ` [PATCH 2/2] pasemi_mac: Netpoll support Olof Johansson
2008-03-26 12:41 ` Valentine Barshak
2008-03-26 12:41 ` Valentine Barshak
2008-03-26 15:08 ` Olof Johansson [this message]
2008-03-26 15:08 ` Olof Johansson
2008-03-27 22:40 ` [PATCH 2/2 v2] " Olof Johansson
2008-03-27 22:40 ` Olof Johansson
2008-03-29 2:11 ` Jeff Garzik
2008-03-29 2:11 ` Jeff Garzik
2008-03-26 4:12 ` [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Jeff Garzik
2008-03-27 19:22 ` Olof Johansson
2008-03-27 19:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326150828.GA6728@lixom.net \
--to=olof@lixom.net \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pasemi-linux@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.