From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, a.p.zijlstra@chello.nl,
galak@kernel.crashing.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU
Date: Fri, 28 Mar 2008 13:09:05 -0500 [thread overview]
Message-ID: <47ED3441.3090601@freescale.com> (raw)
In-Reply-To: <47ED33C6.3090202@freescale.com>
Timur Tabi wrote:
> Scott Wood wrote:
>
>> ...but not anywhere else. All user pointers should have a __user
>> annotation.
>
> Even in a typecast?
Yes. Otherwise, as far as sparse sees, you're passing a kernel pointer
to something expecting a user pointer.
-Scott
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
akpm@linux-foundation.org, York Sun <yorksun@freescale.com>
Subject: Re: [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU
Date: Fri, 28 Mar 2008 13:09:05 -0500 [thread overview]
Message-ID: <47ED3441.3090601@freescale.com> (raw)
In-Reply-To: <47ED33C6.3090202@freescale.com>
Timur Tabi wrote:
> Scott Wood wrote:
>
>> ...but not anywhere else. All user pointers should have a __user
>> annotation.
>
> Even in a typecast?
Yes. Otherwise, as far as sparse sees, you're passing a kernel pointer
to something expecting a user pointer.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: York Sun <yorksun@freescale.com>,
linux-fbdev-devel@lists.sourceforge.net,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, galak@kernel.crashing.org,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU
Date: Fri, 28 Mar 2008 13:09:05 -0500 [thread overview]
Message-ID: <47ED3441.3090601@freescale.com> (raw)
In-Reply-To: <47ED33C6.3090202@freescale.com>
Timur Tabi wrote:
> Scott Wood wrote:
>
>> ...but not anywhere else. All user pointers should have a __user
>> annotation.
>
> Even in a typecast?
Yes. Otherwise, as far as sparse sees, you're passing a kernel pointer
to something expecting a user pointer.
-Scott
next prev parent reply other threads:[~2008-03-28 18:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 2:40 v4 patch to add FSL DIU framebuffer driver York Sun
2008-03-28 2:40 ` York Sun
2008-03-28 2:40 ` [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU York Sun
2008-03-28 2:40 ` York Sun
2008-03-28 2:40 ` [PATCH 2/2 v4] Add DIU platform code for MPC8610HPCD York Sun
2008-03-28 2:40 ` York Sun
2008-03-28 17:19 ` Scott Wood
2008-03-28 17:19 ` Scott Wood
2008-03-28 17:19 ` Scott Wood
2008-03-28 17:30 ` [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU Scott Wood
2008-03-28 17:30 ` Scott Wood
2008-03-28 17:48 ` Anton Vorontsov
2008-03-28 17:48 ` Anton Vorontsov
2008-03-28 17:48 ` Anton Vorontsov
2008-03-28 18:18 ` York Sun
2008-03-28 18:18 ` York Sun
2008-03-28 18:07 ` Timur Tabi
2008-03-28 18:07 ` Timur Tabi
2008-03-28 18:07 ` Timur Tabi
2008-03-28 18:09 ` Scott Wood [this message]
2008-03-28 18:09 ` Scott Wood
2008-03-28 18:09 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED3441.3090601@freescale.com \
--to=scottwood@freescale.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.