All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: "Denis V. Lunev" <den@openvz.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, cramerj@intel.com,
	auke-jan.h.kok@intel.com
Subject: Re: [PATCH] [IXBGE]: Compilation fix for ixgbe_main.c.
Date: Fri, 28 Mar 2008 22:15:36 -0400	[thread overview]
Message-ID: <47EDA648.9080406@garzik.org> (raw)
In-Reply-To: <1206617957-32679-1-git-send-email-den@openvz.org>

Denis V. Lunev wrote:
> Under CONFIG_DCA the compilation is broken since the commit
> bd0362dde080cef377d99fa5beb5c25308c29c73 (ixgbe: Add optional
> DCA infrastructure).
> 
> IXGBE_SUCCESS is not defined anywhere, replace it with 0.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 7ad2993..cb371a8 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -367,7 +367,7 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)
>  		/* Always use CB2 mode, difference is masked
>  		 * in the CB driver. */
>  		IXGBE_WRITE_REG(&adapter->hw, IXGBE_DCA_CTRL, 2);
> -		if (dca_add_requester(dev) == IXGBE_SUCCESS) {
> +		if (dca_add_requester(dev) == 0) {
>  			ixgbe_setup_dca(adapter);
>  			break;
>  		}
> @@ -381,7 +381,7 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)
>  		break;
>  	}
>  
> -	return IXGBE_SUCCESS;
> +	return 0;
>  }
>  
>  #endif /* CONFIG_DCA */
> @@ -3605,7 +3605,7 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
>  		goto err_register;
>  
>  #ifdef CONFIG_DCA
> -	if (dca_add_requester(&pdev->dev) == IXGBE_SUCCESS) {
> +	if (dca_add_requester(&pdev->dev) == 0) {
>  		adapter->flags |= IXGBE_FLAG_DCA_ENABLED;

applied



      parent reply	other threads:[~2008-03-29  2:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 11:39 [PATCH] [IXBGE]: Compilation fix for ixgbe_main.c Denis V. Lunev
2008-03-27 15:26 ` Kok, Auke
2008-03-29  2:15 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EDA648.9080406@garzik.org \
    --to=jeff@garzik.org \
    --cc=auke-jan.h.kok@intel.com \
    --cc=cramerj@intel.com \
    --cc=davem@davemloft.net \
    --cc=den@openvz.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.