From: Avi Kivity <avi@qumranet.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
"Luck, Tony" <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, kvm-ia64-devel@lists.sourceforge.net,
kvm-devel@lists.sourceforge.net, Jes Sorensen <jes@sgi.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask
Date: Sun, 30 Mar 2008 11:42:03 +0000 [thread overview]
Message-ID: <47EF7C8B.90902@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCFF7EFE@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
>
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index 55232cc..b71820b 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -56,6 +56,9 @@ int smp_call_function(void(*func)(void *info), void
> *info, int retry, int wait);
>
> int smp_call_function_single(int cpuid, void (*func) (void *info), void
> *info,
> int retry, int wait);
> +int smp_call_function_mask(cpumask_t mask,
> + void (*func)(void *), void *info,
> + int wait);
>
>
For all other archs, smp_call_function_mask() is declared in <asm/smp.h>
so please define it there. A separate patch can move the declarations
to <linux/smp.h>, since it makes sense to have just one declaration (and
the uniprocessor version is declared there anyway).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
"Luck, Tony" <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, kvm-ia64-devel@lists.sourceforge.net,
kvm-devel@lists.sourceforge.net, Jes Sorensen <jes@sgi.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64
Date: Sun, 30 Mar 2008 14:42:03 +0300 [thread overview]
Message-ID: <47EF7C8B.90902@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCFF7EFE@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
>
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index 55232cc..b71820b 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -56,6 +56,9 @@ int smp_call_function(void(*func)(void *info), void
> *info, int retry, int wait);
>
> int smp_call_function_single(int cpuid, void (*func) (void *info), void
> *info,
> int retry, int wait);
> +int smp_call_function_mask(cpumask_t mask,
> + void (*func)(void *), void *info,
> + int wait);
>
>
For all other archs, smp_call_function_mask() is declared in <asm/smp.h>
so please define it there. A separate patch can move the declarations
to <linux/smp.h>, since it makes sense to have just one declaration (and
the uniprocessor version is declared there anyway).
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-03-30 11:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 9:59 [02/17][PATCH] Implement smp_call_function_mask for ia64 Zhang, Xiantao
2008-03-30 11:42 ` [kvm-ia64-devel] " Avi Kivity
2008-03-30 11:42 ` Avi Kivity [this message]
2008-03-30 11:42 ` Avi Kivity
2008-03-31 1:40 ` Zhang, Xiantao
2008-03-31 1:40 ` Zhang, Xiantao
2008-03-31 8:25 ` [02/17][PATCH] Implement smp_call_function_mask for ia64 - V8 Zhang, Xiantao
2008-03-31 9:12 ` Jes Sorensen
2008-03-31 9:12 ` Jes Sorensen
2008-03-31 9:12 ` Jes Sorensen
2008-03-31 10:17 ` [kvm-devel] [02/17][PATCH] Implement smp_call_function_mask foria64 " Zhang, Xiantao
2008-03-31 10:17 ` Zhang, Xiantao
2008-03-31 15:02 ` [02/17][PATCH] Implement smp_call_function_mask for ia64 " Jeremy Fitzhardinge
2008-03-31 15:02 ` Jeremy Fitzhardinge
2008-03-31 15:02 ` Jeremy Fitzhardinge
2008-04-01 8:34 ` Jes Sorensen
2008-04-01 8:34 ` Jes Sorensen
2008-04-01 8:34 ` Jes Sorensen
2008-04-01 16:06 ` Jeremy Fitzhardinge
2008-04-01 16:06 ` Jeremy Fitzhardinge
2008-04-01 16:06 ` Jeremy Fitzhardinge
2008-04-02 7:30 ` Jes Sorensen
2008-04-02 7:30 ` Jes Sorensen
2008-04-02 23:48 ` Luck, Tony
2008-04-02 23:48 ` Luck, Tony
2008-04-02 23:48 ` Luck, Tony
2008-04-02 7:30 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EF7C8B.90902@qumranet.com \
--to=avi@qumranet.com \
--cc=cotte@de.ibm.com \
--cc=jes@sgi.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=linux-ia64@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.