All of lore.kernel.org
 help / color / mirror / Atom feed
* 2.6.25-rc7-git5: Reported regressions from 2.6.24
@ 2008-03-31  0:28 Rafael J. Wysocki
  2008-03-31 17:48 ` Mark Lord
  2008-04-02 21:00 ` Bongani Hlope
  0 siblings, 2 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-03-31  0:28 UTC (permalink / raw)
  To: LKML; +Cc: Adrian Bunk, Andrew Morton, Linus Torvalds, Natalie Protasevich

This message contains a list of some regressions from 2.6.24, for which there
are no fixes in the mainline I know of.  If any of them have been fixed already,
please let me know.

If you know of any other unresolved regressions from 2.6.24, please let me know
either and I'll add them to the list.  Also, please let me know if any of the
entries below are invalid.


Listed regressions statistics:

  Date          Total  Pending  Unresolved
  ----------------------------------------
  2008-03-31      177       34          31
  2008-03-27      171       38          30
  2008-03-22      159       35          31
  2008-03-17      148       38          30
  2008-03-16      146       42          35
  2008-03-14      145       45          39
  2008-03-12      143       51          41
  2008-03-11      141       58          43
  2008-03-10      138       66          47
  2008-03-03      115       65          49
  2008-02-25       90       51          39
  2008-02-17       61       45          37


Unresolved regressions
----------------------

Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10369
Subject		: The never ending BEEEEP/__smp_call_function_mask with 2.6.25-rc7
Submitter	: Chr <chunkeey@web.de>
Date		: 2008-03-30 21:09 (1 days old)
References	: http://lkml.org/lkml/2008/3/30/87


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10368
Subject		: regression breaks lowmem reserved RAM
Submitter	: Andrea Arcangeli <andrea@qumranet.com>
Date		: 2008-03-28 20:49 (3 days old)
References	: http://lkml.org/lkml/2008/3/28/372


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10366
Subject		: 2.6.25-rc7: warn_on_slowpath triggered
Submitter	: Bob Tracy <rct@frus.com>
Date		: 2008-03-29 17:29 (2 days old)
References	: http://lkml.org/lkml/2008/3/29/125


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10365
Subject		: usb-storage, error reading the last 8 sectors, regression in 2.6.25-rc7
Submitter	: Sergey Dolgov <solkaa@gmail.com>
Date		: 2008-03-30 11:49 (1 days old)
References	: http://lkml.org/lkml/2008/3/30/11


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10364
Subject		: 2.6.25-rc7: V4L ioctl oops
Submitter	: Meelis Roos <mroos@linux.ee>
Date		: 2008-03-29 12:38 (2 days old)
References	: http://lkml.org/lkml/2008/3/29/24


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10349
Subject		: regression: am-utils stopped working in 2.6.25-rc*
Submitter	: Meelis Roos <mroos@linux.ee>
Date		: 2008-03-28 15:20 (3 days old)
References	: http://lkml.org/lkml/2008/3/28/174


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10346
Subject		: Linux 2.6.25-rc6: WARNING: at net/ipv4/tcp_input.c:2510
Submitter	: Georgi Chorbadzhiyski <gf@unixsol.org>
Date		: 2008-03-27 17:29 (4 days old)
References	: http://lkml.org/lkml/2008/3/27/246


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10345
Subject		: USB HID problems after resume
Submitter	: Mark Lord <lkml@rtr.ca>
Date		: 2008-03-27 11:29 (4 days old)
References	: http://lkml.org/lkml/2008/3/27/228
		  http://lkml.org/lkml/2008/3/28/346
Handled-By	: Greg KH <gregkh@suse.de>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10344
Subject		: [2.6.25-rc6] possible regression: X server dying
Submitter	: Tilman Schmidt <tilman@imap.cc>
Date		: 2008-03-24 23:38 (7 days old)
References	: http://lkml.org/lkml/2008/3/24/260
Handled-By	: Dave Airlie <airlied@gmail.com>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10324
Subject		: kernel panic ip_route_input
Submitter	: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Date		: 2008-03-25 12:48 (6 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10323
Subject		: panic using bridging on linus kernel 2.6.25-rc6
Submitter	: Andy Gospodarek <andy@greyhouse.net>
Date		: 2008-03-25 11:40 (6 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10320
Subject		: rt2x00 does not associate or give scan results
Submitter	: Marcus Better <marcus@better.se>
Date		: 2008-03-25 06:04 (6 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10319
Subject		: 2.6.25-rc6 regression - hang on resume
Submitter	: Soeren Sonnenburg <kernel@nn7.de>
Date		: 2008-03-25 04:44 (6 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10305
Subject		: 2.6.25-rc6: kernel BUG at fs/sysfs/file.c:89
Submitter	: Christian Kujau <lists@nerdbynature.de>
Date		: 2008-03-21 23:35 (10 days old)
References	: http://lkml.org/lkml/2008/3/21/408


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10302
Subject		: 2.6.25-git regression with snd-hda-intel on Dell XPS M1330, no analog sound
Submitter	: Andre Tomt <andre@tomt.net>
Date		: 2008-03-21 20:03 (10 days old)
References	: http://lkml.org/lkml/2008/3/21/295
Handled-By	: Matthew Ranostay <mranostay@embeddedalley.com>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10300
Subject		: volume wheel does not work in 2.6.25-rc6
Submitter	: Romano Giannetti <romano.giannetti@gmail.com>
Date		: 2008-03-21 11:42 (10 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10291
Subject		: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Submitter	: Tino Keitel <tino.keitel@gmx.de>
Date		: 2008-03-20 07:05 (11 days old)
References	: http://lkml.org/lkml/2008/3/20/23


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10290
Subject		: [BUG] Linux 2.6.25-rc6 - kernel BUG at fs/mpage.c:476! on powerpc
Submitter	: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Date		: 2008-03-20 13:13 (11 days old)
References	: http://lkml.org/lkml/2008/3/20/39


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10235
Subject		: 2.6.25-rc5: Blank Screen with Intel 945
Submitter	: Rafael J. Wysocki <rjw@sisk.pl>
Date		: 2008-03-12 12:02 (19 days old)
References	: http://lkml.org/lkml/2008/3/12/290
Handled-By	: Jesse Barnes <jbarnes@virtuousgeek.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10172
Subject		: kvm: INFO: inconsistent lock state
Submitter	: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date		: 2008-03-05 03:26 (26 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10156
Subject		: KVM &amp; Qemu crashed with infinite recursive kernel loop in the guest
Submitter	: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date		: 2008-02-28 11:25 (32 days old)
References	: http://lkml.org/lkml/2008/2/28/106


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10133
Subject		: INFO: possible circular locking in the resume
Submitter	: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date		: 2008-02-27 (33 days old)
References	: http://lkml.org/lkml/2008/2/26/479
Handled-By	: Gautham R Shenoy <ego@in.ibm.com>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10117
Subject		: 2.6.25-current-git hangs on boot (pci=nommconf helps)
Submitter	: Soeren Sonnenburg <kernel@nn7.de>
Date		: 2008-02-23 18:55 (37 days old)
References	: http://lkml.org/lkml/2008/2/23/263


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10093
Subject		: 2.6.25-current-git hangs on boot unless CONFIG_CPU_IDLE=n - Apple
Submitter	: Soeren Sonnenburg <kernel@nn7.de>
Date		: 2008-02-23 18:55 (37 days old)
References	: http://lkml.org/lkml/2008/2/23/263
		  http://marc.info/?l=linux-acpi&amp;m=120387537018467&amp;w=4
Handled-By	: Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10082
Subject		: 2.6.25-rc2-git4 - Kernel oops while running kernbench and tbench on powerpc
Submitter	: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Date		: 2008-02-20 16:01 (40 days old)
References	: http://lkml.org/lkml/2008/2/20/218
		  http://lkml.org/lkml/2008/1/18/71


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10067
Subject		: TUNER_TDA8290=y, VIDEO_DEV=n build error
Submitter	: Toralf Förster <toralf.foerster@gmx.de>
Date		: 2008-02-22 10:36 (38 days old)
References	: http://lkml.org/lkml/2008/2/19/262


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10027
Subject		: 2.6.25-rc[12] Video4Linux Bttv Regression
Submitter	: Bongani Hlope <bonganilinux@mweb.co.za>
Date		: 2008-02-17 09:36 (43 days old)
References	: http://lkml.org/lkml/2008/2/17/55


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10011
Subject		: The computer is blocked when X is started - unless max_cstate=2 - Acer Travelmate 4001 Lmi
Submitter	: François Valenduc <francois.valenduc@tvcablenet.be>
Date		: 2008-02-17 06:28 (43 days old)
Handled-By	: Thomas Gleixner <tglx@linutronix.de>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=9980
Subject		: 2.6.25-rc1 on Sun Ultra 40- HPET clocksource which causes it to hang
Submitter	: Jasper Bryant-Greene <jasper@unix.geek.nz>
Date		: 2008-02-13 12:25 (47 days old)
References	: http://lkml.org/lkml/2008/2/13/181


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=9978
Subject		: 2.6.25-rc1: volanoMark regression
Submitter	: Zhang, Yanmin <yanmin_zhang@linux.intel.com>
Date		: 2008-02-13 10:30 (47 days old)
References	: http://lkml.org/lkml/2008/2/13/128
Handled-By	: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=9962
Subject		: mount: could not find filesystem
Submitter	: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Date		: 2008-02-12 14:34 (48 days old)
References	: http://lkml.org/lkml/2008/2/12/91
Handled-By	: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>


Regressionn with patches
------------------------

Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10340
Subject		: suspend order - again
Submitter	: Shaohua Li <shaohua.li@intel.com>
Date		: 2008-03-14 09:22 (17 days old)
References	: http://marc.info/?l=linux-acpi&amp;m=120549574009914&amp;w=4
Handled-By	: Shaohua Li <shaohua.li@intel.com>
Patch		: http://marc.info/?l=linux-acpi&amp;m=120649617317396&amp;w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10326
Subject		: inconsistent lock state in net_rx_action
Submitter	: Marcus Better <marcus@better.se>
Date		: 2008-03-25 13:21 (6 days old)
Patch		: http://bugzilla.kernel.org/show_bug.cgi?id=10326#c20


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10153
Subject		: (regression) kernel/timeconst.h bugs with HZ=128
Submitter	: David Brownell <david-b@pacbell.net>
Date		: 2008-02-26 19:32 (34 days old)
References	: http://lkml.org/lkml/2008/2/26/294
Handled-By	: H. Peter Anvin <hpa@zytor.com>
Patch		: http://bugzilla.kernel.org/attachment.cgi?id=15114&amp;action=view
		  http://bugzilla.kernel.org/attachment.cgi?id=15115&amp;action=view


For details, please visit the bug entries and follow the links given in
references.

As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.24,
unresolved as well as resolved, at:

http://bugzilla.kernel.org/show_bug.cgi?id=9832

Please let me know if there are any Bugzilla entries that should be added to
the list in there.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31  0:28 2.6.25-rc7-git5: Reported regressions from 2.6.24 Rafael J. Wysocki
@ 2008-03-31 17:48 ` Mark Lord
  2008-03-31 19:17   ` Adrian Bunk
  2008-04-02 21:00 ` Bongani Hlope
  1 sibling, 1 reply; 8+ messages in thread
From: Mark Lord @ 2008-03-31 17:48 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: LKML, Adrian Bunk, Andrew Morton, Linus Torvalds,
	Natalie Protasevich

Rafael,

Add this one to the list?


* * * * *

Subject: + driver-core-fix-uevent-action-string-regression.patch added to -mm tree
From: akpm
To: mm-commits
Date: 28/03/08 07:51 PM

The patch titled
     driver core: fix uevent action-string regression
has been added to the -mm tree.  Its filename is
     driver-core-fix-uevent-action-string-regression.patch
...

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: driver core: fix uevent action-string regression
From: Mark Lord <lkml@rtr.ca>

On boot, syslog is flooded with "uevent: unsupported action-string;" messages.
..
Mar 28 14:43:29 shrimp kernel: tty ptyqd: uevent: unsupported
action-string; this will be ignored in a future kernel version
Mar 28 14:43:29 shrimp kernel: tty ptyqe: uevent: unsupported
action-string; this will be ignored in a future kernel version
Mar 28 14:43:29 shrimp kernel: tty ptyqf: uevent: unsupported
action-string; this will be ignored in a future kernel version
Mar 28 14:43:29 shrimp kernel: tty ptyr0: uevent: unsupported
action-string; this will be ignored in a future kernel version


These messages are a regression compared with 2.6.24, which did not flood the
syslog with them.

The actual underlying problem was introduced in 2.6.23, when somebody made the
string parsing no longer accept nul-terminated strings as a valid input to
store_uevent().

Eg.  "add\0" was valid prior to 2.6.23, where the code regressed to require
"add" without the '\0'.

This patch fixes the 2.6.23 / 2.6.24 regressions, by having the code once
again tolerate the trailing '\0', if present.

According to GregKH, this mainly affects older Ubuntu systems, such as the one
I have here that requires this fix.

Signed-off-by: Mark Lord <mlord@pobox.com>
Cc: Greg KH <greg@kroah.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/kobject_uevent.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression lib/kobject_uevent.c
--- a/lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression
+++ a/lib/kobject_uevent.c
@@ -59,7 +59,7 @@ int kobject_action_type(const char *buf,
 	enum kobject_action action;
 	int ret = -EINVAL;
 
-	if (count && buf[count-1] == '\n')
+	if (count && (buf[count-1] == '\n' || buf[count-1] == '\0'))
 		count--;
 
 	if (!count)
_

Patches currently in -mm which might be from lkml@rtr.ca are

driver-core-fix-uevent-action-string-regression.patch

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31 17:48 ` Mark Lord
@ 2008-03-31 19:17   ` Adrian Bunk
  2008-03-31 19:24     ` Mark Lord
  0 siblings, 1 reply; 8+ messages in thread
From: Adrian Bunk @ 2008-03-31 19:17 UTC (permalink / raw)
  To: Mark Lord
  Cc: Rafael J. Wysocki, LKML, Andrew Morton, Linus Torvalds,
	Natalie Protasevich

On Mon, Mar 31, 2008 at 01:48:15PM -0400, Mark Lord wrote:
> Rafael,
>
> Add this one to the list?


That's not a regression from 2.6.24


> * * * * *
>
> Subject: + driver-core-fix-uevent-action-string-regression.patch added to -mm tree
> From: akpm
> To: mm-commits
> Date: 28/03/08 07:51 PM
>
> The patch titled
>     driver core: fix uevent action-string regression
> has been added to the -mm tree.  Its filename is
>     driver-core-fix-uevent-action-string-regression.patch
> ...
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: driver core: fix uevent action-string regression
> From: Mark Lord <lkml@rtr.ca>
>
> On boot, syslog is flooded with "uevent: unsupported action-string;" messages.
> ..
> Mar 28 14:43:29 shrimp kernel: tty ptyqd: uevent: unsupported
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyqe: uevent: unsupported
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyqf: uevent: unsupported
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyr0: uevent: unsupported
> action-string; this will be ignored in a future kernel version
>
>
> These messages are a regression compared with 2.6.24, which did not flood the
> syslog with them.
>
> The actual underlying problem was introduced in 2.6.23, when somebody made the
> string parsing no longer accept nul-terminated strings as a valid input to
> store_uevent().
>
> Eg.  "add\0" was valid prior to 2.6.23, where the code regressed to require
> "add" without the '\0'.
>
> This patch fixes the 2.6.23 / 2.6.24 regressions, by having the code once
> again tolerate the trailing '\0', if present.
>
> According to GregKH, this mainly affects older Ubuntu systems, such as the one
> I have here that requires this fix.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> Cc: Greg KH <greg@kroah.com>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: <stable@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> lib/kobject_uevent.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression lib/kobject_uevent.c
> --- a/lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression
> +++ a/lib/kobject_uevent.c
> @@ -59,7 +59,7 @@ int kobject_action_type(const char *buf,
> 	enum kobject_action action;
> 	int ret = -EINVAL;
>
> -	if (count && buf[count-1] == '\n')
> +	if (count && (buf[count-1] == '\n' || buf[count-1] == '\0'))
> 		count--;
>
> 	if (!count)
> _
>
> Patches currently in -mm which might be from lkml@rtr.ca are
>
> driver-core-fix-uevent-action-string-regression.patch

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31 19:17   ` Adrian Bunk
@ 2008-03-31 19:24     ` Mark Lord
  2008-03-31 19:35       ` Adrian Bunk
  0 siblings, 1 reply; 8+ messages in thread
From: Mark Lord @ 2008-03-31 19:24 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Rafael J. Wysocki, LKML, Andrew Morton, Linus Torvalds,
	Natalie Protasevich

Adrian Bunk wrote:
> On Mon, Mar 31, 2008 at 01:48:15PM -0400, Mark Lord wrote:
>> Rafael,
>>
>> Add this one to the list?
> 
> 
> That's not a regression from 2.6.24
..

2.6.24 does not flood my syslog with those messages.
2.6.25-rc* does.   Looks like a regression.

The original bug was a hidden regression in 2.6.23,
which nobody bothered to identify until now.

Just because some code "gets away with" a regression
for a kernel or two, doesn't mean that regression shouldn't be fixed.

Cheers



> 
> 
>> * * * * *
>>
>> Subject: + driver-core-fix-uevent-action-string-regression.patch added to -mm tree
>> From: akpm
>> To: mm-commits
>> Date: 28/03/08 07:51 PM
>>
>> The patch titled
>>     driver core: fix uevent action-string regression
>> has been added to the -mm tree.  Its filename is
>>     driver-core-fix-uevent-action-string-regression.patch
>> ...
>>
>> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>>
>> ------------------------------------------------------
>> Subject: driver core: fix uevent action-string regression
>> From: Mark Lord <lkml@rtr.ca>
>>
>> On boot, syslog is flooded with "uevent: unsupported action-string;" messages.
>> ..
>> Mar 28 14:43:29 shrimp kernel: tty ptyqd: uevent: unsupported
>> action-string; this will be ignored in a future kernel version
>> Mar 28 14:43:29 shrimp kernel: tty ptyqe: uevent: unsupported
>> action-string; this will be ignored in a future kernel version
>> Mar 28 14:43:29 shrimp kernel: tty ptyqf: uevent: unsupported
>> action-string; this will be ignored in a future kernel version
>> Mar 28 14:43:29 shrimp kernel: tty ptyr0: uevent: unsupported
>> action-string; this will be ignored in a future kernel version
>>
>>
>> These messages are a regression compared with 2.6.24, which did not flood the
>> syslog with them.
>>
>> The actual underlying problem was introduced in 2.6.23, when somebody made the
>> string parsing no longer accept nul-terminated strings as a valid input to
>> store_uevent().
>>
>> Eg.  "add\0" was valid prior to 2.6.23, where the code regressed to require
>> "add" without the '\0'.
>>
>> This patch fixes the 2.6.23 / 2.6.24 regressions, by having the code once
>> again tolerate the trailing '\0', if present.
>>
>> According to GregKH, this mainly affects older Ubuntu systems, such as the one
>> I have here that requires this fix.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>> Cc: Greg KH <greg@kroah.com>
>> Cc: Kay Sievers <kay.sievers@vrfy.org>
>> Cc: <stable@kernel.org>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> ---
>>
>> lib/kobject_uevent.c |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -puN lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression lib/kobject_uevent.c
>> --- a/lib/kobject_uevent.c~driver-core-fix-uevent-action-string-regression
>> +++ a/lib/kobject_uevent.c
>> @@ -59,7 +59,7 @@ int kobject_action_type(const char *buf,
>> 	enum kobject_action action;
>> 	int ret = -EINVAL;
>>
>> -	if (count && buf[count-1] == '\n')
>> +	if (count && (buf[count-1] == '\n' || buf[count-1] == '\0'))
>> 		count--;
>>
>> 	if (!count)
>> _
>>
>> Patches currently in -mm which might be from lkml@rtr.ca are
>>
>> driver-core-fix-uevent-action-string-regression.patch
> 
> cu
> Adrian
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31 19:24     ` Mark Lord
@ 2008-03-31 19:35       ` Adrian Bunk
  2008-03-31 20:31         ` Rafael J. Wysocki
  0 siblings, 1 reply; 8+ messages in thread
From: Adrian Bunk @ 2008-03-31 19:35 UTC (permalink / raw)
  To: Mark Lord
  Cc: Rafael J. Wysocki, LKML, Andrew Morton, Linus Torvalds,
	Natalie Protasevich

On Mon, Mar 31, 2008 at 03:24:10PM -0400, Mark Lord wrote:
> Adrian Bunk wrote:
>> On Mon, Mar 31, 2008 at 01:48:15PM -0400, Mark Lord wrote:
>>> Rafael,
>>>
>>> Add this one to the list?
>>
>>
>> That's not a regression from 2.6.24
> ..
>
> 2.6.24 does not flood my syslog with those messages.
> 2.6.25-rc* does.   Looks like a regression.
>
> The original bug was a hidden regression in 2.6.23,
> which nobody bothered to identify until now.

Let's try to get this patch into Linus' tree without arguing 
whether it might be called a post 2.6.24 regression or not.  ;)

> Just because some code "gets away with" a regression
> for a kernel or two, doesn't mean that regression shouldn't be fixed.

No disagreement on this one.

We already have over 200 known (and many more once reported) regressions 
in the kernel, and all of them should be fixed...

> Cheers

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31 19:35       ` Adrian Bunk
@ 2008-03-31 20:31         ` Rafael J. Wysocki
  0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-03-31 20:31 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Mark Lord, LKML, Andrew Morton, Linus Torvalds,
	Natalie Protasevich

On Monday, 31 of March 2008, Adrian Bunk wrote:
> On Mon, Mar 31, 2008 at 03:24:10PM -0400, Mark Lord wrote:
> > Adrian Bunk wrote:
> >> On Mon, Mar 31, 2008 at 01:48:15PM -0400, Mark Lord wrote:
> >>> Rafael,
> >>>
> >>> Add this one to the list?
> >>
> >>
> >> That's not a regression from 2.6.24
> > ..
> >
> > 2.6.24 does not flood my syslog with those messages.
> > 2.6.25-rc* does.   Looks like a regression.
> >
> > The original bug was a hidden regression in 2.6.23,
> > which nobody bothered to identify until now.
> 
> Let's try to get this patch into Linus' tree without arguing 
> whether it might be called a post 2.6.24 regression or not.  ;)
> 
> > Just because some code "gets away with" a regression
> > for a kernel or two, doesn't mean that regression shouldn't be fixed.
> 
> No disagreement on this one.
> 
> We already have over 200 known (and many more once reported) regressions 
> in the kernel, and all of them should be fixed...

The patch have already been merged, BTW.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-03-31  0:28 2.6.25-rc7-git5: Reported regressions from 2.6.24 Rafael J. Wysocki
  2008-03-31 17:48 ` Mark Lord
@ 2008-04-02 21:00 ` Bongani Hlope
  2008-04-02 21:57   ` Rafael J. Wysocki
  1 sibling, 1 reply; 8+ messages in thread
From: Bongani Hlope @ 2008-04-02 21:00 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: LKML, Mauro Carvalho Chehab, Andrew Morton, Linus Torvalds,
	video4linux-list

On Monday 31 March 2008 02:28:10 Rafael J. Wysocki wrote:
> This message contains a list of some regressions from 2.6.24, for which
> there are no fixes in the mainline I know of.  If any of them have been
> fixed already, please let me know.
>
> If you know of any other unresolved regressions from 2.6.24, please let me
> know either and I'll add them to the list.  Also, please let me know if any
> of the entries below are invalid.
>

Hi Rafael

8<

>
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10027
> Subject		: 2.6.25-rc[12] Video4Linux Bttv Regression
> Submitter	: Bongani Hlope <bonganilinux@mweb.co.za>
> Date		: 2008-02-17 09:36 (43 days old)
> References	: http://lkml.org/lkml/2008/2/17/55
>

This has been fixed and tested, the patch is in Linus' tree this is the git 
commit 49115b7cb1483a14c557666b61fe81d3c23780d6. You can close the bug now.

Thanks

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 2.6.25-rc7-git5: Reported regressions from 2.6.24
  2008-04-02 21:00 ` Bongani Hlope
@ 2008-04-02 21:57   ` Rafael J. Wysocki
  0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-04-02 21:57 UTC (permalink / raw)
  To: Bongani Hlope
  Cc: LKML, Mauro Carvalho Chehab, Andrew Morton, Linus Torvalds,
	video4linux-list

On Wednesday, 2 of April 2008, Bongani Hlope wrote:
> On Monday 31 March 2008 02:28:10 Rafael J. Wysocki wrote:
> > This message contains a list of some regressions from 2.6.24, for which
> > there are no fixes in the mainline I know of.  If any of them have been
> > fixed already, please let me know.
> >
> > If you know of any other unresolved regressions from 2.6.24, please let me
> > know either and I'll add them to the list.  Also, please let me know if any
> > of the entries below are invalid.
> >
> 
> Hi Rafael

Hi,

> 8<
> 
> >
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10027
> > Subject		: 2.6.25-rc[12] Video4Linux Bttv Regression
> > Submitter	: Bongani Hlope <bonganilinux@mweb.co.za>
> > Date		: 2008-02-17 09:36 (43 days old)
> > References	: http://lkml.org/lkml/2008/2/17/55
> >
> 
> This has been fixed and tested, the patch is in Linus' tree this is the git 
> commit 49115b7cb1483a14c557666b61fe81d3c23780d6. You can close the bug now.

Closed.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-04-02 21:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-31  0:28 2.6.25-rc7-git5: Reported regressions from 2.6.24 Rafael J. Wysocki
2008-03-31 17:48 ` Mark Lord
2008-03-31 19:17   ` Adrian Bunk
2008-03-31 19:24     ` Mark Lord
2008-03-31 19:35       ` Adrian Bunk
2008-03-31 20:31         ` Rafael J. Wysocki
2008-04-02 21:00 ` Bongani Hlope
2008-04-02 21:57   ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.