From: Mark Lord <lkml@rtr.ca>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>, Pavel Machek <pavel@suse.cz>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
jikos@suse.cz, linux-usb@vger.kernel.org
Subject: Re: 2.6.25-rc7: Ugh. ---> PATCH
Date: Wed, 02 Apr 2008 11:44:03 -0400 [thread overview]
Message-ID: <47F3A9C3.7030702@rtr.ca> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0804021106320.6272-100000@iolanthe.rowland.org>
This patch seems to fix it.
Could you guys look this over some more,
as I really am not familiar with the USB code.
* * * *
When comparing 2.6.24 against 2.6.25, this line of code
stood out as not looking entirely correct, given the new
uses of QH_STATE_UNLINK_WAIT in 2.6.25.
Applying this patch seems to fix the USB suspend/resume deaths
on my machine here. More testing is needed to be sure.
Signed-off-by: Mark Lord <mlord@pobox.com>
--- linux-2.6.25-rc8/drivers/usb/host/ehci-hcd.c 2008-03-11 11:18:40.000000000 -0400
+++ linux/drivers/usb/host/ehci-hcd.c 2008-04-02 11:36:13.000000000 -0400
@@ -815,7 +815,7 @@
end_unlink_async(ehci);
/* if it's not linked then there's nothing to do */
- if (qh->qh_state != QH_STATE_LINKED)
+ if (qh->qh_state != QH_STATE_LINKED && qh->qh_state != QH_STATE_UNLINK_WAIT)
;
/* defer till later if busy */
next prev parent reply other threads:[~2008-04-02 15:44 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 15:29 2.6.25-rc7: Ugh Mark Lord
2008-03-27 16:07 ` Greg KH
2008-03-28 0:32 ` Jiri Kosina
2008-03-28 1:57 ` Mark Lord
2008-03-28 3:12 ` David Miller
2008-03-28 4:42 ` Bob Tracy
2008-03-28 4:56 ` David Miller
2008-03-28 5:17 ` Mark Lord
2008-03-28 6:01 ` david
2008-03-28 16:34 ` Bob Tracy
2008-04-05 18:23 ` Bill Davidsen
2008-03-28 5:36 ` Mike Galbraith
2008-03-28 5:46 ` Mark Lord
2008-03-28 5:52 ` Mark Lord
2008-03-28 6:05 ` Mark Lord
2008-03-28 6:58 ` David Brownell
2008-03-28 9:16 ` Ingo Molnar
2008-03-28 9:49 ` David Brownell
2008-03-28 10:20 ` Ingo Molnar
2008-03-28 11:01 ` Pavel Machek
2008-03-28 15:03 ` Jan Engelhardt
2008-03-28 20:14 ` David Brownell
2008-03-28 12:51 ` Kconfig RTC selection (was: 2.6.25-rc7: Ugh.) Tilman Schmidt
2008-03-28 13:49 ` Kconfig RTC selection Mark Lord
2008-03-28 19:22 ` Kconfig RTC selection (was: 2.6.25-rc7: Ugh.) David Brownell
2008-03-29 12:55 ` Kconfig RTC selection Tilman Schmidt
2008-03-28 13:47 ` 2.6.25-rc7: Ugh Mark Lord
2008-03-28 20:04 ` Kconfig RTC selection (was: 2.6.25-rc7: Ugh.) David Brownell
2008-03-28 21:06 ` Adrian Bunk
2008-03-28 21:23 ` David Brownell
2008-03-28 21:33 ` Adrian Bunk
2008-03-28 21:45 ` David Brownell
2008-03-28 21:59 ` Adrian Bunk
2008-03-28 22:18 ` David Brownell
2008-03-28 22:36 ` Adrian Bunk
2008-03-29 11:40 ` [rtc-linux] " Alessandro Zummo
2008-03-28 14:56 ` 2.6.25-rc7: Ugh Jan Engelhardt
2008-03-28 17:47 ` Adrian Bunk
2008-03-29 3:58 ` Mark Lord
2008-03-28 1:51 ` Mark Lord
2008-03-28 2:11 ` Mark Lord
2008-03-28 2:13 ` Mark Lord
2008-03-28 14:34 ` Alan Stern
2008-03-28 14:57 ` Mark Lord
2008-03-27 22:00 ` Rafael J. Wysocki
2008-03-28 5:22 ` Mark Lord
2008-03-28 2:14 ` Mark Lord
2008-03-28 9:24 ` Pavel Machek
2008-03-30 21:04 ` Mark Lord
2008-03-30 21:09 ` Mark Lord
2008-03-31 11:55 ` Oliver Neukum
2008-03-31 14:39 ` Mark Lord
2008-03-31 15:04 ` Oliver Neukum
2008-03-31 15:04 ` Mark Lord
2008-03-31 15:14 ` Mark Lord
2008-03-31 16:37 ` Oliver Neukum
2008-03-31 17:03 ` Mark Lord
2008-03-31 17:06 ` Mark Lord
2008-03-31 17:15 ` Mark Lord
2008-03-31 17:21 ` Mark Lord
2008-03-31 17:30 ` Mark Lord
2008-03-31 18:05 ` Oliver Neukum
2008-03-31 19:21 ` Mark Lord
2008-04-02 8:04 ` Oliver Neukum
2008-04-02 14:38 ` Mark Lord
2008-04-02 14:38 ` Mark Lord
2008-04-02 15:05 ` 2.6.25-rc7/rc8 USB dead on resume Mark Lord
2008-04-02 15:21 ` Oliver Neukum
2008-04-02 15:08 ` 2.6.25-rc7: Ugh Alan Stern
2008-04-02 15:44 ` Mark Lord [this message]
2008-04-02 15:47 ` 2.6.25-rc7: Ugh. ---> PATCH Mark Lord
2008-04-02 15:49 ` Mark Lord
2008-04-02 20:09 ` Alan Stern
2008-04-02 16:04 ` 2.6.25-rc7: Ugh David Brownell
2008-04-02 16:09 ` Mark Lord
2008-04-02 20:22 ` David Brownell
2008-04-02 16:20 ` [PATCH] usb ehci_iaa_watchdog fix Mark Lord
2008-04-02 16:48 ` Alan Stern
2008-04-02 17:34 ` Mark Lord
2008-04-02 18:08 ` Mark Lord
2008-04-02 19:20 ` Alan Stern
2008-04-02 20:42 ` David Brownell
2008-04-02 21:08 ` Alan Stern
2008-04-07 23:37 ` David Brownell
2008-04-08 2:13 ` Alan Stern
2008-04-02 20:31 ` David Brownell
2008-04-02 20:55 ` Alan Stern
2008-04-02 23:07 ` David Brownell
2008-04-02 16:56 ` David Brownell
2008-04-01 9:59 ` 2.6.25-rc7: Ugh Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F3A9C3.7030702@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jikos@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pavel@suse.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.