[lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all addresses

[lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all addresses

[Juerg Haefliger]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

This patch adds a module load parameter to enable probing of 
non-standard LPC addresses 0x162e and 0x164e when scanning for supported 
ISA chips.

Signed-Off-By: Juerg Haefliger <juergh at gmail.com>

[-- Attachment #2: dme1737-probe-all-addresses.patch --]
[-- Type: text/x-patch, Size: 1907 bytes --]

This patch adds a module load parameter to enable probing of non-standard LPC
addresses 0x162e and 0x164e when scanning for supported ISA chips.

Signed-Off-By: Juerg Haefliger <juergh at gmail.com>

Index: linux/Documentation/hwmon/dme1737
===================================================================
--- linux.orig/Documentation/hwmon/dme1737	2008-01-24 14:58:37.000000000 -0800
+++ linux/Documentation/hwmon/dme1737	2008-04-03 21:38:25.000000000 -0700
@@ -22,6 +22,10 @@
 			and PWM output control functions. Using this parameter
 			shouldn't be required since the BIOS usually takes care
 			of this.
+* probe_all_addr: bool	Include non-standard LPC addresses 0x162e and 0x164e
+			when probing for ISA devices. This is required for the
+			following boards:
+			- VIA EPIA SN18000
 
 Note that there is no need to use this parameter if the driver loads without
 complaining. The driver will say so if it is necessary.
Index: linux/drivers/hwmon/dme1737.c
===================================================================
--- linux.orig/drivers/hwmon/dme1737.c	2008-03-15 22:12:39.000000000 -0700
+++ linux/drivers/hwmon/dme1737.c	2008-04-03 21:16:13.000000000 -0700
@@ -48,6 +48,11 @@
 module_param(force_id, ushort, 0);
 MODULE_PARM_DESC(force_id, "Override the detected device ID");
 
+static int probe_all_addr;
+module_param(probe_all_addr, bool, 0);
+MODULE_PARM_DESC(probe_all_addr, "Include probing of non-standard LPC "
+		 "addresses");
+
 /* Addresses to scan */
 static const unsigned short normal_i2c[] = {0x2c, 0x2d, 0x2e, I2C_CLIENT_END};
 
@@ -2430,7 +2435,10 @@
 	}
 
 	if (dme1737_isa_detect(0x2e, &addr) &&
-	    dme1737_isa_detect(0x4e, &addr)) {
+	    dme1737_isa_detect(0x4e, &addr) &&
+	    (!probe_all_addr ||
+	     (dme1737_isa_detect(0x162e, &addr) &&
+	      dme1737_isa_detect(0x164e, &addr)))) {
 		/* Return 0 if we didn't find an ISA device */
 		return 0;
 	}

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all

[Jean Delvare]

On Thu, 03 Apr 2008 21:34:19 -0700, Juerg Haefliger wrote:
> This patch adds a module load parameter to enable probing of 
> non-standard LPC addresses 0x162e and 0x164e when scanning for supported 
> ISA chips.
> 
> Signed-Off-By: Juerg Haefliger <juergh at gmail.com>

Looks good this time.

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/3 RESEND] hwmon (dme1737): probe all

[Mark M. Hoffman]

Hi:

* Jean Delvare <khali@linux-fr.org> [2008-04-04 09:32:55 +0200]:
> On Thu, 03 Apr 2008 21:34:19 -0700, Juerg Haefliger wrote:
> > This patch adds a module load parameter to enable probing of 
> > non-standard LPC addresses 0x162e and 0x164e when scanning for supported 
> > ISA chips.
> > 
> > Signed-Off-By: Juerg Haefliger <juergh at gmail.com>
> 
> Looks good this time.
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors