From: Jeff Garzik <jeff@garzik.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning
Date: Fri, 04 Apr 2008 01:46:18 -0400 [thread overview]
Message-ID: <47F5C0AA.4000109@garzik.org> (raw)
In-Reply-To: <1207182815.5740.21.camel@brick>
Harvey Harrison wrote:
> The other if blocks don't redeclare temp, remove the redeclaration in
> the final if() block.
>
> drivers/net/phy/marvell.c:214:7: warning: symbol 'temp' shadows an earlier one
> drivers/net/phy/marvell.c:160:6: originally declared here
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/phy/marvell.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 3353991..32a8503 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -211,8 +211,6 @@ static int m88e1111_config_init(struct phy_device *phydev)
> }
>
> if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
> - int temp;
> -
applied
prev parent reply other threads:[~2008-04-04 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 0:33 [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning Harvey Harrison
2008-04-04 5:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F5C0AA.4000109@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.