* [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning
@ 2008-04-03 0:33 Harvey Harrison
2008-04-04 5:46 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-04-03 0:33 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Al Viro, Andrew Morton, LKML
The other if blocks don't redeclare temp, remove the redeclaration in
the final if() block.
drivers/net/phy/marvell.c:214:7: warning: symbol 'temp' shadows an earlier one
drivers/net/phy/marvell.c:160:6: originally declared here
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/net/phy/marvell.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 3353991..32a8503 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -211,8 +211,6 @@ static int m88e1111_config_init(struct phy_device *phydev)
}
if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
- int temp;
-
temp = phy_read(phydev, MII_M1111_PHY_EXT_SR);
if (temp < 0)
return temp;
--
1.5.5.rc1.135.g8527
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning
2008-04-03 0:33 [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning Harvey Harrison
@ 2008-04-04 5:46 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-04 5:46 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Al Viro, Andrew Morton, LKML
Harvey Harrison wrote:
> The other if blocks don't redeclare temp, remove the redeclaration in
> the final if() block.
>
> drivers/net/phy/marvell.c:214:7: warning: symbol 'temp' shadows an earlier one
> drivers/net/phy/marvell.c:160:6: originally declared here
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/phy/marvell.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 3353991..32a8503 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -211,8 +211,6 @@ static int m88e1111_config_init(struct phy_device *phydev)
> }
>
> if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
> - int temp;
> -
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-04 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-03 0:33 [PATCH 2/7] net: marvell.c fix sparse shadowed variable warning Harvey Harrison
2008-04-04 5:46 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.