[PATCH] create proper net device for hvm guests

[PATCH] create proper net device for hvm guests

[Jim Fehlig]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

I've noticed that hvm guests using pv network device also get an
emulated network device.  Conversely, hvm guests using emulated network
device also get pv network device.  I'm surprised that this hasn't been
fixed already, which makes me think there is some unforeseen issue that
results from not providing both.  I guess one drawback is that the guest
config file must be edited to remove 'model=foo, type=ioemu' when using
pv network device  - but it seems the guest config file should be the
place where these types of settings are explicitly stated.

I've attached a patch the creates either the emulated or pv network
device (but not both) depending on setting in guest configuation, i.e.
'type=ioemu'.  Please apply if my reasoning is sane.  If not, please
clarify reason for presenting both :-).

Cheers,
Jim


Create either the emulated or pv network device (but not both) depending
on setting in guest configuation, i.e. 'type=ioemu'.

    Signed-off-by: Jim Fehlig <jfehlig@novell.com>



[-- Attachment #2: xend-netdev-fix.diff --]
[-- Type: text/x-patch, Size: 1142 bytes --]

diff -r db943e8d1051 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py	Tue Apr 01 10:09:33 2008 +0100
+++ b/tools/python/xen/xend/image.py	Fri Apr 04 17:09:45 2008 -0600
@@ -571,7 +571,7 @@ class HVMImageHandler(ImageHandler):
 
         for devuuid in vmConfig['vif_refs']:
             devinfo = vmConfig['devices'][devuuid][1]
-            dtype = devinfo.get('type', 'ioemu')
+            dtype = devinfo.get('type', '')
             if dtype != 'ioemu':
                 continue
             nics += 1
diff -r db943e8d1051 tools/python/xen/xend/server/netif.py
--- a/tools/python/xen/xend/server/netif.py	Tue Apr 01 10:09:33 2008 +0100
+++ b/tools/python/xen/xend/server/netif.py	Fri Apr 04 17:10:13 2008 -0600
@@ -99,6 +99,13 @@ class NetifController(DevController):
     
     def __init__(self, vm):
         DevController.__init__(self, vm)
+
+    def createDevice(self, config):
+        typ = config.get('type', '')
+        if typ == 'ioemu':
+            return 0
+
+        DevController.createDevice(self, config)
 
     def getDeviceDetails(self, config):
         """@see DevController.getDeviceDetails"""

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] create proper net device for hvm guests

[Daniel P. Berrange]

On Fri, Apr 04, 2008 at 05:25:57PM -0600, Jim Fehlig wrote:
> I've noticed that hvm guests using pv network device also get an
> emulated network device.  Conversely, hvm guests using emulated network
> device also get pv network device.  I'm surprised that this hasn't been
> fixed already, which makes me think there is some unforeseen issue that
> results from not providing both.  I guess one drawback is that the guest
> config file must be edited to remove 'model=foo, type=ioemu' when using
> pv network device  - but it seems the guest config file should be the
> place where these types of settings are explicitly stated.
> 
> I've attached a patch the creates either the emulated or pv network
> device (but not both) depending on setting in guest configuation, i.e.
> 'type=ioemu'.  Please apply if my reasoning is sane.  If not, please
> clarify reason for presenting both :-).

The guest administrator does not have control over the Dom0, and thus has
no ability to change the config. Since installing Xen PV drivers is a post
install task, you can't create the guest with pv-only mode straightaway,
and nor can the guest admin change the config. Thus the presenting both the
devices lets the guest admin choose between the two at will. They can
easily blacklist the '8139too' driver in modprobe.conf if they only want
to use the pv driver and prevent the 2nd nic from being mistakenly used.

IIRC, the logic is supposed to currently be:

  - type=ioemu  - only present emulated rtl8139 (or as per model=)
  - type=netfront - only present the pv driver
  - no type= setting - present both pv & rtl8139 nic

Regards,
Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Re: [PATCH] create proper net device for hvm guests

[Jim Fehlig]

Daniel P. Berrange wrote:
> On Fri, Apr 04, 2008 at 05:25:57PM -0600, Jim Fehlig wrote:
>   
>> I've noticed that hvm guests using pv network device also get an
>> emulated network device.  Conversely, hvm guests using emulated network
>> device also get pv network device.  I'm surprised that this hasn't been
>> fixed already, which makes me think there is some unforeseen issue that
>> results from not providing both.  I guess one drawback is that the guest
>> config file must be edited to remove 'model=foo, type=ioemu' when using
>> pv network device  - but it seems the guest config file should be the
>> place where these types of settings are explicitly stated.
>>
>> I've attached a patch the creates either the emulated or pv network
>> device (but not both) depending on setting in guest configuation, i.e.
>> 'type=ioemu'.  Please apply if my reasoning is sane.  If not, please
>> clarify reason for presenting both :-).
>>     
>
> The guest administrator does not have control over the Dom0, and thus has
> no ability to change the config. Since installing Xen PV drivers is a post
> install task, you can't create the guest with pv-only mode straightaway,
> and nor can the guest admin change the config.

Yes, that was the drawback I noted above.

>  Thus the presenting both the
> devices lets the guest admin choose between the two at will. They can
> easily blacklist the '8139too' driver in modprobe.conf if they only want
> to use the pv driver and prevent the 2nd nic from being mistakenly used.
>
> IIRC, the logic is supposed to currently be:
>
>   - type=ioemu  - only present emulated rtl8139 (or as per model=)
>   - type=netfront - only present the pv driver
>   - no type= setting - present both pv & rtl8139 nic
>   

On 3.2 I observe

  - type=ioemu - both emulated and pv presented
  - type=netfront - only pv presented
  - no type setting - both emulated and pv presented

The second hunk of this patch provides the behavior you described. 
However, when using it, I noticed that no vif entries are created in
xenstore frontend/backend paths (DevController.createDevice is not
called when 'type=ioemu').  Oddly, I don't see any ill affects from that
though ;-).

The first hunk changes

  -no type setting - both emulated and pv presented

to

-no type setting - only pv presented

so ignore that.  I would suspect that many guests targeted for pv driver
installation have 'type=ioemu' in their config, making the second hunk
of this patch distasteful as well.  Sigh ...

Jim


> Regards,
> Dan.
>   

Re: [PATCH] create proper net device for hvm guests

[David Edmondson]

On 5 Apr 2008, at 3:21am, Jim Fehlig wrote:
> However, when using it, I noticed that no vif entries are created in
> xenstore frontend/backend paths (DevController.createDevice is not
> called when 'type=ioemu').  Oddly, I don't see any ill affects from  
> that
> though ;-).

This would break Solaris dom0, which relies on the existence of the  
backend paths in the ioemu case.