From: Anthony Liguori <anthony@codemonkey.ws>
To: dor.laor@qumranet.com
Cc: kvm-devel@lists.sourceforge.net,
Marcelo Tosatti <marcelo@kvack.org>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio for QEMU
Date: Fri, 04 Apr 2008 22:09:28 -0500 [thread overview]
Message-ID: <47F6ED68.5090200@codemonkey.ws> (raw)
In-Reply-To: <1206897941.3357.15.camel@localhost.localdomain>
Dor Laor wrote:
>
>> +static uint32_t vring_desc_len(VirtQueue *vq, unsigned int i)
>> +{
>
> Below there were place you did use offsetof(vq->vring.desc[i], len) so
> we better be consistent + its nicer
>
>> + return ldl_phys(vq->vring.desc + i * sizeof(VRingDesc) +
>> + offsetof(VRingDesc, len));
>> +}
>> +
Oh, this bit is different because you need to do offsetof(Type, member)
and vq->vring.desc[i] is not a type. It only works when you're doing an
array with member[X].
Regards,
Anthony Liguori
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: dor.laor@qumranet.com
Cc: kvm-devel@lists.sourceforge.net,
Marcelo Tosatti <marcelo@kvack.org>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio for QEMU
Date: Fri, 04 Apr 2008 22:09:28 -0500 [thread overview]
Message-ID: <47F6ED68.5090200@codemonkey.ws> (raw)
In-Reply-To: <1206897941.3357.15.camel@localhost.localdomain>
Dor Laor wrote:
>
>> +static uint32_t vring_desc_len(VirtQueue *vq, unsigned int i)
>> +{
>
> Below there were place you did use offsetof(vq->vring.desc[i], len) so
> we better be consistent + its nicer
>
>> + return ldl_phys(vq->vring.desc + i * sizeof(VRingDesc) +
>> + offsetof(VRingDesc, len));
>> +}
>> +
Oh, this bit is different because you need to do offsetof(Type, member)
and vq->vring.desc[i] is not a type. It only works when you're doing an
array with member[X].
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-04-05 3:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 21:55 [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] " Anthony Liguori
2008-03-29 21:55 ` [PATCH 2/6] PCI DMA API Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] " Anthony Liguori
2008-03-30 7:06 ` Blue Swirl
2008-03-30 7:06 ` Blue Swirl
2008-03-30 14:44 ` Anthony Liguori
2008-03-30 14:44 ` Anthony Liguori
2008-03-30 14:49 ` Avi Kivity
2008-03-30 14:49 ` Avi Kivity
2008-03-30 14:56 ` Anthony Liguori
2008-03-30 14:56 ` [kvm-devel] " Anthony Liguori
2008-03-30 14:58 ` Blue Swirl
2008-03-30 14:58 ` Blue Swirl
2008-03-30 15:11 ` Anthony Liguori
2008-03-30 15:11 ` Anthony Liguori
2008-03-30 10:18 ` Paul Brook
2008-03-30 10:18 ` Paul Brook
2008-03-30 14:42 ` Anthony Liguori
2008-03-30 14:42 ` Anthony Liguori
2008-03-30 18:19 ` Paul Brook
2008-03-30 18:19 ` Paul Brook
2008-03-30 19:02 ` Anthony Liguori
2008-03-30 19:02 ` Anthony Liguori
2008-03-30 10:25 ` Avi Kivity
2008-03-30 10:25 ` [Qemu-devel] Re: [kvm-devel] " Avi Kivity
2008-03-30 14:49 ` Anthony Liguori
2008-03-30 14:49 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-03-29 21:55 ` [PATCH 3/6] virtio for QEMU Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] " Anthony Liguori
2008-03-30 17:25 ` Dor Laor
2008-03-30 17:25 ` Dor Laor
2008-03-30 22:59 ` Anthony Liguori
2008-03-30 22:59 ` [kvm-devel] " Anthony Liguori
2008-04-05 3:09 ` Anthony Liguori [this message]
2008-04-05 3:09 ` Anthony Liguori
2008-03-29 21:55 ` [PATCH 4/6] virtio network driver Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] " Anthony Liguori
2008-03-30 10:27 ` Paul Brook
2008-03-30 10:27 ` Paul Brook
2008-03-30 14:47 ` Anthony Liguori
2008-03-30 14:47 ` [Qemu-devel] " Anthony Liguori
2008-03-29 21:55 ` [PATCH 5/6] virtio block driver Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] " Anthony Liguori
2008-03-29 21:56 ` [PATCH 6/6] virtio balloon driver Anthony Liguori
2008-03-29 21:56 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F6ED68.5090200@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=dor.laor@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=marcelo@kvack.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.