All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Juliusz Chroboczek <Juliusz.Chroboczek@pps.jussieu.fr>
Cc: Andi Kleen <andi@firstfloor.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] Stochastic Fair Blue queue discipline
Date: Tue, 08 Apr 2008 17:45:25 +0200	[thread overview]
Message-ID: <47FB9315.5030109@trash.net> (raw)
In-Reply-To: <7iy77o9wzb.fsf@lanthane.pps.jussieu.fr>

Juliusz Chroboczek wrote:
>>> I think we have multiple qdiscs now doing very similar such hashes.
>>> Any chance this could be factored out into a common library function
>>> first?
> 
>> I'd suggest to use the flow classifier for this. For simplicity
>> you could attach a default classifier that uses the same keys as
>> this one.
> 
> I'm not sure I know what you're speaking about.  Could you please
> point me at code somewhere?

Check out a recent tree (either Linus' current tree or ideally
the net-2.6.26.git tree from

git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.26.git

and look at net/sched/cls_flow.c and the recent changes to
net/sched/sch_sfq.c for external classifiers. There are also
a number of other incompatible changes that your patch needs
to be adapter to, most importantly the use of the new netlink
infrastructure.

  reply	other threads:[~2008-04-08 15:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-07 22:37 [PATCH] Stochastic Fair Blue queue discipline Juliusz Chroboczek
2008-04-08  0:04 ` Patrick McHardy
2008-04-08  0:56   ` Patrick McHardy
2008-04-08 15:28   ` Juliusz Chroboczek
2008-04-08  8:20 ` Andi Kleen
2008-04-08 12:11   ` Patrick McHardy
2008-04-08 15:39     ` Juliusz Chroboczek
2008-04-08 15:45       ` Patrick McHardy [this message]
2008-04-09 15:48         ` Juliusz Chroboczek
2008-04-09 16:00           ` Patrick McHardy
2008-04-08 15:38   ` Juliusz Chroboczek
2008-04-08 16:32     ` Andi Kleen
2008-04-08 17:35       ` Juliusz Chroboczek
2008-04-08 17:53         ` Andi Kleen
2008-04-09 15:45           ` Juliusz Chroboczek
2008-04-09 17:49             ` Andi Kleen
2008-04-10  1:23               ` Patrick McHardy
2008-04-10  1:38                 ` Patrick McHardy
2008-04-10 11:17                   ` Juliusz Chroboczek
2008-04-11 13:07                     ` Patrick McHardy
2008-04-10 14:04                   ` Stephen Hemminger
2008-04-10  7:36                 ` Andi Kleen
2008-04-08 16:44 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FB9315.5030109@trash.net \
    --to=kaber@trash.net \
    --cc=Juliusz.Chroboczek@pps.jussieu.fr \
    --cc=andi@firstfloor.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.