From: Roel Kluin <12o3l@tiscali.nl>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: linux-mm@kvack.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pagewalk: don't pte_unmap(NULL) in walk_pte_range()
Date: Thu, 10 Apr 2008 13:42:52 +0200 [thread overview]
Message-ID: <47FDFD3C.1030708@tiscali.nl> (raw)
In-Reply-To: <87zls3qhop.fsf@saeurebad.de>
Johannes Weiner wrote:
> Hi,
>
> Roel Kluin <12o3l@tiscali.nl> writes:
>
>> This is right isn't it?
>> ---
>> Don't pte_unmap a NULL pointer, but the previous.
>
> Which NULL pointer?
>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
>> index 1cf1417..6615f0b 100644
>> --- a/mm/pagewalk.c
>> +++ b/mm/pagewalk.c
>> @@ -15,7 +15,7 @@ static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
>> break;
>> } while (pte++, addr += PAGE_SIZE, addr != end);
>>
>> - pte_unmap(pte);
>> + pte_unmap(pte - 1);
>> return err;
>> }
>
> This does not make any sense to me.
you are right, please ignore.
> Hannes
thanks,
Roel
WARNING: multiple messages have this Message-ID (diff)
From: Roel Kluin <12o3l@tiscali.nl>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: linux-mm@kvack.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pagewalk: don't pte_unmap(NULL) in walk_pte_range()
Date: Thu, 10 Apr 2008 13:42:52 +0200 [thread overview]
Message-ID: <47FDFD3C.1030708@tiscali.nl> (raw)
In-Reply-To: <87zls3qhop.fsf@saeurebad.de>
Johannes Weiner wrote:
> Hi,
>
> Roel Kluin <12o3l@tiscali.nl> writes:
>
>> This is right isn't it?
>> ---
>> Don't pte_unmap a NULL pointer, but the previous.
>
> Which NULL pointer?
>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
>> index 1cf1417..6615f0b 100644
>> --- a/mm/pagewalk.c
>> +++ b/mm/pagewalk.c
>> @@ -15,7 +15,7 @@ static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
>> break;
>> } while (pte++, addr += PAGE_SIZE, addr != end);
>>
>> - pte_unmap(pte);
>> + pte_unmap(pte - 1);
>> return err;
>> }
>
> This does not make any sense to me.
you are right, please ignore.
> Hannes
thanks,
Roel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-10 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 10:08 [PATCH] pagewalk: don't pte_unmap(NULL) in walk_pte_range() Roel Kluin
2008-04-09 10:08 ` Roel Kluin
2008-04-09 13:30 ` Johannes Weiner
2008-04-09 13:30 ` Johannes Weiner
2008-04-10 11:42 ` Roel Kluin [this message]
2008-04-10 11:42 ` Roel Kluin
2008-04-10 12:09 ` Andreas Schwab
2008-04-10 12:09 ` Andreas Schwab
2008-04-10 14:01 ` [PATCH] Stay below upper pmd boundary on pte range walk Johannes Weiner
2008-04-10 14:01 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FDFD3C.1030708@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.