From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com
Cc: suravee.suthikulpanit@amd.com, will@kernel.org,
robin.murphy@arm.com, sven@kernel.org, j@jannau.net,
robin.clark@oss.qualcomm.com, m.szyprowski@samsung.com,
krzk@kernel.org, dwmw2@infradead.org, yong.wu@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
tjeznach@rivosinc.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, heiko@sntech.de, schnelle@linux.ibm.com,
mjrosato@linux.ibm.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
jean-philippe@linaro.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev
Date: Thu, 23 Oct 2025 12:50:13 +0800 [thread overview]
Message-ID: <47b5dfbe-dda7-419d-9032-d61bda44eb9f@linux.intel.com> (raw)
In-Reply-To: <276875013de662fe50f3fdd9e9a5bfbc0f12602e.1761017765.git.nicolinc@nvidia.com>
On 10/23/25 10:21, Nicolin Chen wrote:
> The last gdev is the device that failed the __iommu_device_set_domain().
> So, it doesn't need to be reverted, given it's attached to group->domain
> already.
>
> This is not a problem currently, since it's a simply re-attach. However,
> the core will need to pass in the old domain to __iommu_device_set_domain
> so the old domain pointers would be inconsistent between a failed device
> and all its prior succeeded devices, as all the prior devices need to be
> reverted.
>
> Avoid the re-attach for the last gdev, by breaking before the revert.
>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> drivers/iommu/iommu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com
Cc: suravee.suthikulpanit@amd.com, will@kernel.org,
robin.murphy@arm.com, sven@kernel.org, j@jannau.net,
robin.clark@oss.qualcomm.com, m.szyprowski@samsung.com,
krzk@kernel.org, dwmw2@infradead.org, yong.wu@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
tjeznach@rivosinc.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, heiko@sntech.de, schnelle@linux.ibm.com,
mjrosato@linux.ibm.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
jean-philippe@linaro.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev
Date: Thu, 23 Oct 2025 12:50:13 +0800 [thread overview]
Message-ID: <47b5dfbe-dda7-419d-9032-d61bda44eb9f@linux.intel.com> (raw)
In-Reply-To: <276875013de662fe50f3fdd9e9a5bfbc0f12602e.1761017765.git.nicolinc@nvidia.com>
On 10/23/25 10:21, Nicolin Chen wrote:
> The last gdev is the device that failed the __iommu_device_set_domain().
> So, it doesn't need to be reverted, given it's attached to group->domain
> already.
>
> This is not a problem currently, since it's a simply re-attach. However,
> the core will need to pass in the old domain to __iommu_device_set_domain
> so the old domain pointers would be inconsistent between a failed device
> and all its prior succeeded devices, as all the prior devices need to be
> reverted.
>
> Avoid the re-attach for the last gdev, by breaking before the revert.
>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> drivers/iommu/iommu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com
Cc: suravee.suthikulpanit@amd.com, will@kernel.org,
robin.murphy@arm.com, sven@kernel.org, j@jannau.net,
robin.clark@oss.qualcomm.com, m.szyprowski@samsung.com,
krzk@kernel.org, dwmw2@infradead.org, yong.wu@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
tjeznach@rivosinc.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, heiko@sntech.de, schnelle@linux.ibm.com,
mjrosato@linux.ibm.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
jean-philippe@linaro.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev
Date: Thu, 23 Oct 2025 12:50:13 +0800 [thread overview]
Message-ID: <47b5dfbe-dda7-419d-9032-d61bda44eb9f@linux.intel.com> (raw)
In-Reply-To: <276875013de662fe50f3fdd9e9a5bfbc0f12602e.1761017765.git.nicolinc@nvidia.com>
On 10/23/25 10:21, Nicolin Chen wrote:
> The last gdev is the device that failed the __iommu_device_set_domain().
> So, it doesn't need to be reverted, given it's attached to group->domain
> already.
>
> This is not a problem currently, since it's a simply re-attach. However,
> the core will need to pass in the old domain to __iommu_device_set_domain
> so the old domain pointers would be inconsistent between a failed device
> and all its prior succeeded devices, as all the prior devices need to be
> reverted.
>
> Avoid the re-attach for the last gdev, by breaking before the revert.
>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> drivers/iommu/iommu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-10-23 4:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 2:21 [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 1/6] iommu: Generic support for RMRs during device release Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 4:43 ` Baolu Lu
2025-10-23 4:43 ` Baolu Lu
2025-10-23 4:43 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 2/6] iommu/arm-smmu-v3: Set release_domain to arm_smmu_blocked_domain Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 3/6] iommu/exynos-iommu: Set release_domain to exynos_identity_domain Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 4/6] iommu/amd: Set release_domain to blocked_domain Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 4:50 ` Baolu Lu [this message]
2025-10-23 4:50 ` Baolu Lu
2025-10-23 4:50 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 6/6] iommu: Pass in old domain to attach_dev callback functions Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen
2025-10-23 4:58 ` Baolu Lu
2025-10-23 4:58 ` Baolu Lu
2025-10-23 4:58 ` Baolu Lu
2025-10-27 12:55 ` [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Jörg Rödel
2025-10-27 12:55 ` Jörg Rödel
2025-10-27 12:55 ` Jörg Rödel
2025-12-19 8:10 ` patchwork-bot+linux-riscv
2025-12-19 8:10 ` patchwork-bot+linux-riscv
2025-12-19 8:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b5dfbe-dda7-419d-9032-d61bda44eb9f@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jean-philippe@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=pjw@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=schnelle@linux.ibm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tjeznach@rivosinc.com \
--cc=virtualization@lists.linux.dev \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.