Re: [PATCH iperf3 v3] add MPTCPv1 support

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 19/06/2024 03:52, Geliang Tang wrote:
> On Tue, 2024-03-12 at 16:14 +0800, Geliang Tang wrote:

(...)

>> Sorry, I open a new one before reading this:
>>
>> https://github.com/esnet/iperf/pull/1661
> 
> This pull request has not been merged yet, and I recently found that it
> has conflicted with other code, so I resolved the conflict and updated
> it this pull request again.

Thank you for having done that!

> In addition, I found that before my pull request, there was already a
> pull request for MPTCP support waiting
> (https://github.com/esnet/iperf/pull/1615 by "marcosfsch"). I guess it
> is because there are two conflicting requests with the same purpose
> that MPTCP support has not been merged. If this is the reason, can we
> contact "marcosfsch" to see if these two requests can be merged into
> one? It doesn't matter whether mine or his is merged.

I don't think that's the reason, but I just added a message on PR #1615.

> Or the reason why it has not been merged is that iperf maintainers are
> not interested in MPTCP support because he has not given us any
> feedback. If this is the case, it seems we have no choice but to give
> up supporting MPTCP in iperf.

Yes, that's a shame they didn't even provide any feedback... If they
don't want it, they should at least be clear about that. I just added a
message on your PR #1661, will see... Because I don't think we want to
maintain an MPTCP version on our side (who will use it apart from us?).

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.